From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Banel Subject: fix bug in ascii plot Date: Mon, 14 Dec 2015 22:38:19 +0100 Message-ID: <566F36CB.2060702@free.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070008000809090906050008" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8ap8-00017d-Ts for emacs-orgmode@gnu.org; Mon, 14 Dec 2015 16:38:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8ap3-00084o-TR for emacs-orgmode@gnu.org; Mon, 14 Dec 2015 16:38:26 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:12344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8ap3-00084W-NK for emacs-orgmode@gnu.org; Mon, 14 Dec 2015 16:38:21 -0500 Received: from [IPv6:2a01:e35:2e21:def0:4d17:273f:116b:90e4] (unknown [IPv6:2a01:e35:2e21:def0:4d17:273f:116b:90e4]) by smtp5-g21.free.fr (Postfix) with ESMTP id 18D05D48052 for ; Mon, 14 Dec 2015 22:36:59 +0100 (CET) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org-Mode mailing list This is a multi-part message in MIME format. --------------070008000809090906050008 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The 16c7594 commit (found by bisecting) revealeda bug in ascii-plot. Attached is a fix. To test, consider this table: | 1 | | 2 | | 3 | The cursor being in the table, type C-c " a Result with the bug: | 1 | | | 2 | | | 3 | | #+TBLFM: 2='(orgtbl-ascii-draw $1 1 3 12) Result with the fix: | 1 | | | 2 | WWWWWW | | 3 | WWWWWWWWWWWW | #+TBLFM: $2='(orgtbl-ascii-draw $1 1 3 12) --------------070008000809090906050008 Content-Type: text/x-diff; name="0001-Fix-missing-dollar-bug-revealed-by-commit-16c7594.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-missing-dollar-bug-revealed-by-commit-16c7594.patch" >From 19f0712d8bdefb76f54218068599b5abce6b18b9 Mon Sep 17 00:00:00 2001 From: Thierry Banel Date: Mon, 14 Dec 2015 22:22:03 +0100 Subject: [PATCH] Fix missing dollar bug revealed by commit 16c7594 * org-table.el (orgtbl-ascii-plot): add missing dollar in formula --- lisp/org-table.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-table.el b/lisp/org-table.el index 474a44f..265e74b 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -5295,7 +5295,7 @@ characters width of the plot. ASK may also be the (org-table-store-formulas (cons (cons - (number-to-string (1+ col)) + (concat "$" (number-to-string (1+ col))) (format "'(%s $%s %s %s %s)" "orgtbl-ascii-draw" col min max length)) (org-table-get-stored-formulas))) -- 2.1.4 --------------070008000809090906050008--