emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tim Ruffing <crypto@timruffing.de>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Don't reset `org-todo-keywords-for-agenda' when org-agenda-multi
Date: Thu, 09 Mar 2023 13:46:45 +0100	[thread overview]
Message-ID: <55a16edf3c8e04e9f1f7be7ab281ddacac81d9c1.camel@timruffing.de> (raw)

* org-agenda.el (org-prepare-agenda): Don't reset
`org-todo-keywords-for-agenda' when org-agenda-multi.

Fixes a bug with TODO keywords that came to light in org-modern,
see https://github.com/minad/org-modern/issues/26.

This is very similar to cd2d138883a55cad48394a3f473da8b973a99a5e,
which fixed the same for `org-done-keywords-for-agenda` (to fix
a similar styling issue).
---
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 7e54121dc..8e3cc693a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3956,7 +3956,6 @@ FILTER-ALIST is an alist of filters we need to
apply when
      (message "Sticky Agenda buffer, use `r' to refresh")
      (or org-agenda-multi (org-agenda-fit-window-to-buffer))
      (throw 'exit "Sticky Agenda buffer, use `r' to refresh"))
-      (setq org-todo-keywords-for-agenda nil)
       (if org-agenda-multi
      (progn
        (setq buffer-read-only nil)
@@ -3969,6 +3968,7 @@ FILTER-ALIST is an alist of filters we need to
apply when
            (make-string (window-max-chars-per-line) org-agenda-block-
separator))
              "\n"))
        (narrow-to-region (point) (point-max)))
+        (setq org-todo-keywords-for-agenda nil)
    (setq org-done-keywords-for-agenda nil)
    ;; Setting any org variables that are in org-agenda-local-vars
    ;; list need to be done after the prepare call
-- 
2.39.2


             reply	other threads:[~2023-03-09 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 12:46 Tim Ruffing [this message]
2023-03-10 11:48 ` [PATCH] Don't reset `org-todo-keywords-for-agenda' when org-agenda-multi Ihor Radchenko
2023-03-10 12:08   ` Tim Ruffing
2023-03-10 12:32   ` Max Nikulin
2023-03-10 14:16     ` Tim Ruffing
2023-03-11 10:22       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55a16edf3c8e04e9f1f7be7ab281ddacac81d9c1.camel@timruffing.de \
    --to=crypto@timruffing.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).