emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] docstring improvement of org-agenda-refile
@ 2014-08-09 23:49 Daimrod
  0 siblings, 0 replies; 6+ messages in thread
From: Daimrod @ 2014-08-09 23:49 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

Hi,

Here is a small patch to improve the docstring of `org-agenda-refile'.
Can I apply it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org-agenda.el-org-agenda-refile-Documentation-i.patch --]
[-- Type: text/x-diff, Size: 1291 bytes --]

From acd2830755849a055ce46a34b65af89b9547fcb2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= <gregoire.jadi@gmail.com>
Date: Sun, 10 Aug 2014 01:41:16 +0200
Subject: [PATCH] lisp/org-agenda.el (org-agenda-refile): Documentation
 improvement

* lisp/org-agenda.el (org-agenda-refile): State explicitly that
  '(16) = C-u C-u and that '(64) = C-u C-u C-u.
---
 lisp/org-agenda.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 3919328..8244eeb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8475,8 +8475,8 @@ If this information is not given, the function uses the tree at point."
 (defun org-agenda-refile (&optional goto rfloc no-update)
   "Refile the item at point.
 
-When GOTO is 0 or '(64), clear the refile cache.
-When GOTO is '(16), go to the location of the last refiled item.
+When GOTO is 0 or '(64) or \\[universal-argument] \\[universal-argument] \\[universal-argument], clear the refile cache.
+When GOTO is '(14) or \\[universal-argument] \\[universal-argument], go to the location of the last refiled item.
 RFLOC can be a refile location obtained in a different way.
 When NO-UPDATE is non-nil, don't redo the agenda buffer."
   (interactive "P")
-- 
1.8.0.2722.gc0242e5


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


-- 
Daimrod/Greg

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] docstring improvement of org-agenda-refile
@ 2014-08-09 23:50 Daimrod
  2014-08-11  9:27 ` Suvayu Ali
  2014-08-11 12:07 ` Charles Millar
  0 siblings, 2 replies; 6+ messages in thread
From: Daimrod @ 2014-08-09 23:50 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

Hi,

Here is a small patch to improve the docstring of `org-agenda-refile'.
Can I apply it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org-agenda.el-org-agenda-refile-Documentation-i.patch --]
[-- Type: text/x-diff, Size: 1291 bytes --]

From acd2830755849a055ce46a34b65af89b9547fcb2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= <gregoire.jadi@gmail.com>
Date: Sun, 10 Aug 2014 01:41:16 +0200
Subject: [PATCH] lisp/org-agenda.el (org-agenda-refile): Documentation
 improvement

* lisp/org-agenda.el (org-agenda-refile): State explicitly that
  '(16) = C-u C-u and that '(64) = C-u C-u C-u.
---
 lisp/org-agenda.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 3919328..8244eeb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8475,8 +8475,8 @@ If this information is not given, the function uses the tree at point."
 (defun org-agenda-refile (&optional goto rfloc no-update)
   "Refile the item at point.
 
-When GOTO is 0 or '(64), clear the refile cache.
-When GOTO is '(16), go to the location of the last refiled item.
+When GOTO is 0 or '(64) or \\[universal-argument] \\[universal-argument] \\[universal-argument], clear the refile cache.
+When GOTO is '(14) or \\[universal-argument] \\[universal-argument], go to the location of the last refiled item.
 RFLOC can be a refile location obtained in a different way.
 When NO-UPDATE is non-nil, don't redo the agenda buffer."
   (interactive "P")
-- 
1.8.0.2722.gc0242e5


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


-- 
Daimrod/Greg

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] docstring improvement of org-agenda-refile
  2014-08-09 23:50 [PATCH] docstring improvement of org-agenda-refile Daimrod
@ 2014-08-11  9:27 ` Suvayu Ali
  2014-08-11 12:07 ` Charles Millar
  1 sibling, 0 replies; 6+ messages in thread
From: Suvayu Ali @ 2014-08-11  9:27 UTC (permalink / raw)
  To: emacs-orgmode

On Sun, Aug 10, 2014 at 01:50:50AM +0200, Daimrod wrote:
>  
> -When GOTO is 0 or '(64), clear the refile cache.
> -When GOTO is '(16), go to the location of the last refiled item.
> +When GOTO is 0 or '(64) or \\[universal-argument] \\[universal-argument] \\[universal-argument], clear the refile cache.
> +When GOTO is '(14) or \\[universal-argument] \\[universal-argument], go to the location of the last refiled item.
>  RFLOC can be a refile location obtained in a different way.
>  When NO-UPDATE is non-nil, don't redo the agenda buffer."

I would say this is an improvement :).

-- 
Suvayu

Open source is the future. It sets us free.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] docstring improvement of org-agenda-refile
  2014-08-09 23:50 [PATCH] docstring improvement of org-agenda-refile Daimrod
  2014-08-11  9:27 ` Suvayu Ali
@ 2014-08-11 12:07 ` Charles Millar
  2014-08-11 12:13   ` Charles Millar
  1 sibling, 1 reply; 6+ messages in thread
From: Charles Millar @ 2014-08-11 12:07 UTC (permalink / raw)
  To: emacs-orgmode

Daimrod wrote:
> +When GOTO is '(14) or \\[universal-argument] \\[universal-argument], go to the location of the last refiled item.
                                     ^^
                                  '(16)


---
This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] docstring improvement of org-agenda-refile
  2014-08-11 12:07 ` Charles Millar
@ 2014-08-11 12:13   ` Charles Millar
  2014-08-12 18:51     ` Daimrod
  0 siblings, 1 reply; 6+ messages in thread
From: Charles Millar @ 2014-08-11 12:13 UTC (permalink / raw)
  To: emacs-orgmode

Charles Millar wrote:
> Daimrod wrote:
>> +When GOTO is '(14) or \\[universal-argument] \\[universal-argument], 
>> go to the location of the last refiled item.
>                                     ^^
>                                  '(16)
Just opened my own reply and the '(16) may be misaligned.

Charlie

---
This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] docstring improvement of org-agenda-refile
  2014-08-11 12:13   ` Charles Millar
@ 2014-08-12 18:51     ` Daimrod
  0 siblings, 0 replies; 6+ messages in thread
From: Daimrod @ 2014-08-12 18:51 UTC (permalink / raw)
  To: emacs-orgmode

Charles Millar <millarc@verizon.net> writes:

> Charles Millar wrote:
>> Daimrod wrote:
>>> +When GOTO is '(14) or \\[universal-argument]
>>> \\[universal-argument], go to the location of the last refiled
>>> item.
>>                                     ^^
>>                                  '(16)
> Just opened my own reply and the '(16) may be misaligned.

Good catch.

I've applied the patch with the correction.

--
Daimrod/Greg

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-08-12 18:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-09 23:50 [PATCH] docstring improvement of org-agenda-refile Daimrod
2014-08-11  9:27 ` Suvayu Ali
2014-08-11 12:07 ` Charles Millar
2014-08-11 12:13   ` Charles Millar
2014-08-12 18:51     ` Daimrod
  -- strict thread matches above, loose matches on Subject: below --
2014-08-09 23:49 Daimrod

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).