From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Shlyakhter Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags Date: Fri, 16 Mar 2012 10:13:08 -0400 Message-ID: <4F634A74.6010806@alum.mit.edu> References: <3953.1331867583@alphaville> <4695.1331878200@alphaville> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080707050709010102000801" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8XuO-0000Ds-D8 for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8XuH-0006xk-Ut for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:13:31 -0400 Received: from plane.gmane.org ([80.91.229.3]:59058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8XuH-0006wS-Ng for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:13:25 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S8XuE-000499-JI for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 15:13:22 +0100 Received: from pool-74-104-102-162.bstnma.east.verizon.net ([74.104.102.162]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Mar 2012 15:13:22 +0100 Received: from ilya_shl by pool-74-104-102-162.bstnma.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Mar 2012 15:13:22 +0100 In-Reply-To: <4695.1331878200@alphaville> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Cc: emacs-orgmode This is a multi-part message in MIME format. --------------080707050709010102000801 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 3/16/2012 2:10 AM, Nick Dokos wrote: > One more thing that you'll need to do is put your patches in attachments > of a type that will allow patchwork to snag the patch: Thanks, I was wondering why they're not showing up. Here is another try (attached) for the org.el patch. ilya --------------080707050709010102000801 Content-Type: text/plain; name="0002-Tags-properties-matcher-faster-matching-by-trusting-.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-Tags-properties-matcher-faster-matching-by-trusting-.pa"; filename*1="tch" >From 95c38b06803aec0787bc2eaab3d0062221390292 Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter Date: Fri, 16 Mar 2012 00:10:25 -0400 Subject: [PATCH 2/2] Tags/properties matcher: faster matching by trusting org-scanner-tags * lisp/org.el (org-scan-tags): Bind org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index ad63213..951f692 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12906,7 +12906,8 @@ headlines matching this string." ;; eval matcher only when the todo condition is OK (and (or (not todo-only) (member todo org-not-done-keywords)) - (let ((case-fold-search t)) (eval matcher))) + (let ((case-fold-search t) (org-trust-scanner-tags t)) + (eval matcher))) ;; Call the skipper, but return t if it does not skip, ;; so that the `and' form continues evaluating -- 1.7.9.3 --------------080707050709010102000801--