Bug: Bug reporting doesn't work [7.8.03 (release_7.8.03.583.gd7943.dirty)]

[Shaun Johnson <shaun@slugfest.demon.co.uk>]

Attempting to send a bug report using org-submit-bug-report results in the following backtrace:

   (expand-file-name "scripts" (file-name-as-directory (expand-file-name "../contrib" ...)))
   (file-name-as-directory (expand-file-name "scripts" (file-name-as-directory ...)))
   (expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name "scripts" ...)))
   eval((expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name "scripts" ...))))
   (equal (symbol-value v) (eval (car ...)))
   (not (equal (symbol-value v) (eval ...)))
   (and (get v (quote custom-type)) (get v (quote standard-value)) (not (equal ... ...)))
   (or (and (symbol-value v) (string-match "\\(-hook\\|-function\\)\\'" ...)) (and (get v ...) (get v ...) (not ...)))
   (and (boundp v) (string-match "\\`\\(org-\\|outline-\\)" (symbol-name v)) (or (and ... ...) (and ... ... ...)) (push v list))
   (lambda (v) (and (boundp v) (string-match "\\`\\(org-\\|outline-\\)" ...) (or ... ...) (push v list)))(org-ditaa-jar-path)
   mapatoms((lambda (v) (and (boundp v) (string-match "\\`\\(org-\\|outline-\\)" ...) (or ... ...) (push v list))))
   (progn (mapatoms (lambda ... ...)))
   (if (yes-or-no-p "Include your Org-mode configuration ") (progn (mapatoms ...)))
   (when (yes-or-no-p "Include your Org-mode configuration ") (mapatoms (lambda ... ...)))
   (save-window-excursion (org-pop-to-buffer-same-window (get-buffer-create "*Warn about privacy*")) (delete-other-windows) (erase-buffer) (insert "You are about to submit a bug report to the Org-mode mailing list.\n\nWe would like to add your full Org-mode and Outline configuration to the\nbug report.  This greatly simplifies the work of the maintainer and\nother experts on the mailing list.\n\nHOWEVER, some variables you have customized may contain private\ninformation.  The names of customers, colleagues, or friends, might\nappear in the form of file names, tags, todo states, or search strings.\nIf you answer yes to the prompt, you might want to check and remove\nsuch private information before sending the email.") (add-text-properties (point-min) (point-max) (quote ...)) (when (yes-or-
 no-p "Include your Org-mode configuration ") (mapatoms ...)) (kill-buffer (get-buffer "*Warn about privacy*")) list)
   (let (list) (save-window-excursion (org-pop-to-buffer-same-window ...) (delete-other-windows) (erase-buffer) (insert "You are about to submit a bug report to the Org-mode mailing list.\n\nWe would like to add your full Org-mode and Outline configuration to the\nbug report.  This greatly simplifies the work of the maintainer and\nother experts on the mailing list.\n\nHOWEVER, some variables you have customized may contain private\ninformation.  The names of customers, colleagues, or friends, might\nappear in the form of file names, tags, todo states, or search strings.\nIf you answer yes to the prompt, you might want to check and remove\nsuch private information before sending the email.") (add-text-properties ... ... ...) (when ... ...) (kill-buffer ...) list))
   (reporter-submit-bug-report "emacs-orgmode@gnu.org" (org-version) (let (list) (save-window-excursion ... ... ... ... ... ... ... list)) nil nil "Remember to cover the basics, that is, what you expected to happen and\nwhat in fact did happen.  You don't know how to make a good report?  See\n\n     http://orgmode.org/manual/Feedback.html#Feedback\n\nYour bug report will be posted to the Org-mode mailing list.\n------------------------------------------------------------------------")
   (let ((reporter-prompt-for-summary-p "Bug report subject: ")) (reporter-submit-bug-report "emacs-orgmode@gnu.org" (org-version) (let ... ...) nil nil "Remember to cover the basics, that is, what you expected to happen and\nwhat in fact did happen.  You don't know how to make a good report?  See\n\n     http://orgmode.org/manual/Feedback.html#Feedback\n\nYour bug report will be posted to the Org-mode mailing list.\n------------------------------------------------------------------------") (save-excursion (if ... ...)))
   org-submit-bug-report()
   call-interactively(org-submit-bug-report nil nil)


This can be traced to evaluating the standard-value property of
org-ditaa-jar-path. The relevant defcustom (in org-exp-blocks) is:

     (defcustom org-ditaa-jar-path (expand-file-name
                     "ditaa.jar"
                     (file-name-as-directory
                      (expand-file-name
                       "scripts"
                       (file-name-as-directory
                        (expand-file-name
                     "../contrib"
                     (file-name-directory (or load-file-name buffer-file-name)))))))
       "Path to the ditaa jar executable."
       :group 'org-babel
       :type 'string)

The second argument (specifying the standard value) can not be evaluated
in other contexts where load-file-name and buffer-file-name are
undefined. I think this can be traced to changing the original defvar to
a defcustom.

The following patch seems to fix the problem (at least well enough to
enable me to send this bug report):

diff --git a/lisp/org-exp-blocks.el b/lisp/org-exp-blocks.el
index 78eaa15..4ebbe34 100644
--- a/lisp/org-exp-blocks.el
+++ b/lisp/org-exp-blocks.el
@@ -233,7 +233,7 @@ which defaults to the value of `org-export-blocks-witheld'."
  			      (file-name-as-directory
  			       (expand-file-name
  				"../contrib"
-				(file-name-directory (or load-file-name buffer-file-name)))))))
+				(file-name-directory (find-library-name "org")))))))
    "Path to the ditaa jar executable."
    :group 'org-babel
    :type 'string)

Shaun Johnson.

Emacs  : GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600)
  of 2011-03-10 on 3249CTO
Package: Org-mode version 7.8.03 (release_7.8.03.583.gd7943.dirty)

current state:
==============
(setq
  org-export-preprocess-before-backend-specifics-hook '(org-inlinetask-export-handler)
  org-emphasis-alist '(("*" bold "<b>" "</b>") ("/" italic "<i>" "</i>")
                       ("_" underline "<span style=\"text-decoration:underline;\">" "</span>") ("=" org-code "<code>" "</code>" verbatim)
                       ("~" org-verbatim "<code>" "</code>" verbatim))
  org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
  org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
  org-agenda-files '("e:/Home/Shaun/Org/personal.org" "~/Play/Alexandria/alexandria.org" "e:/Home/Shaun/Org/Farrers.org"
                     "e:/Home/Shaun/Org/ScottishWater.org" "e:/Home/Shaun/Org/TEV.org" "e:/Home/Shaun/Org/Tesco.org"
                     "e:/Home/Shaun/Org/general.org" "e:/Home/Shaun/Org/hoj.org" "e:/Home/Shaun/Org/thor.org" "e:/Home/Shaun/Org/Sincal.org")
  org-agenda-include-diary t
  org-src-fontify-natively t
  org-clock-into-drawer "CLOCK"
  org-metaup-hook '(org-babel-load-in-session-maybe)
  org-footnote-section nil
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-id-method 'org
  org-log-note-clock-out t
  org-export-latex-format-toc-function 'org-export-latex-format-toc-default
  org-hide-emphasis-markers t
  org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe)
  org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
  org-confirm-shell-link-function 'yes-or-no-p
  org-export-first-hook '(org-beamer-initialize-open-trackers)
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-directory "~/Org"
  org-imenu-depth 4
  org-babel-pre-tangle-hook '(save-buffer)
  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                   org-optimize-window-after-visibility-change)
  org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
  org-mode-hook '((lambda nil (org-add-hook (quote change-major-mode-hook) (quote org-babel-show-result-all) (quote append) (quote local)))
                  (lambda nil (org-add-hook (quote change-major-mode-hook) (quote org-show-block-all) (quote append) (quote local)))
                  #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
                  #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                  org-babel-result-hide-spec org-babel-hide-all-hashes)
  org-font-lock-hook '(org-inlinetask-fontify)
  org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
  org-emphasis-regexp-components '(" 	('\"" "- 	.,:?;'\")_" " 	
\n,\"'" "." 1)
  org-confirm-elisp-link-function 'yes-or-no-p
  org-export-interblocks '((src org-babel-exp-non-block-elements))
  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
  org-occur-hook '(org-first-headline-recenter)
  org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
  org-modules '(org-bbdb org-bibtex org-gnus org-id org-info org-jsinfo org-inlinetask org-irc org-mew org-mhe org-rmail org-vm org-wl org-w3m)
  org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames
                                org-beamer-place-default-actions-for-lists)
  org-metadown-hook '(org-babel-pop-to-session-maybe)
  org-export-blocks '((src org-babel-exp-src-block nil) (export-comment org-export-blocks-format-comment t)
                      (ditaa org-export-blocks-format-ditaa nil) (dot org-export-blocks-format-dot nil))
  )