emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jonathan BISSON <bissonjonathan@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Adding features to contrib/lisp/org-collector.el (propview)
Date: Fri, 28 Oct 2011 16:41:32 +0200	[thread overview]
Message-ID: <4EAABF1C.1040202@gmail.com> (raw)
In-Reply-To: <87obx19og2.fsf@gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

On 10/28/2011 04:32 PM, Bastien wrote:
> Hi Jonathan,
> 
> Jonathan BISSON <bissonjonathan@gmail.com> writes:
> 
>> I did a small patch for org-collector.
> 
> Thanks for this -- can you resend the patch by attaching 
> it, instead of inserting it in the body of the email?  It 
> is not readable here.
> 
> Thanks!
> 

Here it is,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: bjonnh.patch --]
[-- Type: text/x-patch; name="bjonnh.patch", Size: 1122 bytes --]

121a122,123
> 	    (noquote (plist-get params :noquote))
> 	    (colnames (plist-get params :colnames))
132a135
> 	  (setq stringformat (if noquote "%s" "%S"))
134c137,138
< 		       (org-propview-collect cols conds match scope inherit)))
---
> 		       (org-propview-collect cols stringformat conds match scope inherit 
> 					     (if colnames colnames cols)) stringformat))
170c174
< (defun org-propview-collect (cols &optional conds match scope inherit)
---
> (defun org-propview-collect (cols stringformat &optional conds match scope inherit colnames)
194,195c198,199
<       (mapcar (lambda (el) (format "%S" el)) cols) ;; output headers
<       'hline) ;; ------------------------------------------------
---
>       (if colnames colnames (mapcar (lambda (el) (format stringformat el)) cols))
>        'hline) ;; ------------------------------------------------
214c218
< (defun org-propview-to-table (results)
---
> (defun org-propview-to-table (results stringformat)
221c225
< 	(mapcar (lambda (el) (format "%S" el)) row)))
---
> 	(mapcar (lambda (el) (format stringformat el)) row)))

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]

  reply	other threads:[~2011-10-28 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28  9:33 [PATCH] Adding features to contrib/lisp/org-collector.el (propview) Jonathan BISSON
2011-10-28 14:32 ` Bastien
2011-10-28 14:41   ` Jonathan BISSON [this message]
2011-10-28 14:56     ` Bastien
2011-10-28 17:01       ` Eric Schulte
2011-10-28 14:37 ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAABF1C.1040202@gmail.com \
    --to=bissonjonathan@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).