Bug: Tangling indirect buffers [7.5 (release_7.5.6.g11f19)]

[Shaun Johnson <shaun@slugfest.demon.co.uk>]

I reported this problem earlier against 7.4, it still occurs
with the latest GIT version. Maybe (probably) I'm being stupid,
if so could someone please tell me.

Tangling from an indirect buffer fails with the following stack trace:

     Debugger entered--Lisp error: (wrong-type-argument stringp nil)
       file-name-nondirectory(nil)
       (message "tangled %d code block%s from %s" block-counter (if (= block-counter 1) "" "s") (file-name-nondirectory (buffer-file-name ...)))
       (let ((block-counter 0) (org-babel-default-header-args ...) path-collector) (mapc (lambda ... ...) (org-babel-tangle-collect-blocks lang)) (message "tangled %d code block%s from %s" block-counter (if ... "" "s") (file-name-nondirectory ...)) (when org-babel-post-tangle-hook (mapc ... path-collector)) path-collector)
       (save-excursion (let (... ... path-collector) (mapc ... ...) (message "tangled %d code block%s from %s" block-counter ... ...) (when org-babel-post-tangle-hook ...) path-collector))
       org-babel-tangle()
       call-interactively(org-babel-tangle t nil)
       execute-extended-command(nil)
       call-interactively(execute-extended-command nil nil)

The problem seems to be in this fragment of org-babel-tangle:

       (message "tangled %d code block%s from %s" block-counter
                (if (= block-counter 1) "" "s")
            (file-name-nondirectory (buffer-file-name (current-buffer))))

On an indirect buffer buffer-file-name returns nil, replacing this by:

       (message "tangled %d code block%s from %s" block-counter
                (if (= block-counter 1) "" "s")
            (file-name-nondirectory (buffer-file-name
                                     (or (buffer-base-buffer) (current-buffer)))))

seems to do the right thing.

Shaun.

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

      http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------



Emacs  : GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600)
  of 2010-05-08 on G41R2F1
Package: Org-mode version 7.5 (release_7.5.6.g11f19)

current state:
==============
(setq
  org-emphasis-alist '(("*" bold "<b>" "</b>") ("/" italic "<i>" "</i>")
                       ("_" underline
                        "<span style=\"text-decoration:underline;\">" "</span>")
                       ("=" org-code "<code>" "</code>" verbatim)
                       ("~" org-verbatim "<code>" "</code>" verbatim))
  org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
  org-speed-command-hook '(org-speed-command-default-hook
                           org-babel-speed-command-hook)
  org-agenda-files '("e:/Home/Shaun/Org/personal.org"
                     "~/Play/Alexandria/alexandria.org"
                     "e:/Home/Shaun/Org/Farrers.org"
                     "e:/Home/Shaun/Org/ScottishWater.org"
                     "e:/Home/Shaun/Org/TEV.org" "e:/Home/Shaun/Org/Tesco.org"
                     "e:/Home/Shaun/Org/general.org"
                     "e:/Home/Shaun/Org/hoj.org" "e:/Home/Shaun/Org/thor.org"
                     "e:/Home/Shaun/Org/Sincal.org")
  org-agenda-include-diary t
  org-clock-into-drawer "CLOCK"
  org-metaup-hook '(org-babel-load-in-session-maybe)
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-id-method 'org
  org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
  org-log-note-clock-out t
  org-export-latex-format-toc-function 'org-export-latex-format-toc-default
  org-hide-emphasis-markers t
  org-tab-first-hook '(org-hide-block-toggle-maybe
                       org-src-native-tab-command-maybe
                       org-babel-hide-result-toggle-maybe)
  org-src-mode-hook '(org-src-babel-configure-edit-buffer
                      org-src-mode-configure-edit-buffer)
  org-confirm-shell-link-function 'yes-or-no-p
  org-export-first-hook '(org-beamer-initialize-open-trackers)
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-directory "~/Org"
  org-babel-pre-tangle-hook '(save-buffer)
  org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
                   org-cycle-show-empty-lines
                   org-optimize-window-after-visibility-change)
  org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
  org-mode-hook '((lambda nil
                   (org-add-hook (quote change-major-mode-hook)
                    (quote org-show-block-all) (quote append) (quote local))
                   )
                  (lambda nil
                   (org-add-hook (quote change-major-mode-hook)
                    (quote org-babel-show-result-all) (quote append)
                    (quote local))
                   )
                  org-babel-result-hide-spec org-babel-hide-all-hashes)
  org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
                           org-babel-execute-safely-maybe)
  org-emphasis-regexp-components '(" 	('\"" "- 	.,:?;'\")_" " 	
\n,\"'"
                                   "." 1)
  org-confirm-elisp-link-function 'yes-or-no-p
  org-export-interblocks '((lob org-babel-exp-lob-one-liners)
                           (src org-babel-exp-inline-src-blocks))
  org-occur-hook '(org-first-headline-recenter)
  org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
  org-modules '(org-bbdb org-bibtex org-gnus org-id org-info org-jsinfo org-irc
                org-mew org-mhe org-rmail org-vm org-wl org-w3m)
  org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
                                org-beamer-auto-fragile-frames
                                org-beamer-place-default-actions-for-lists)
  org-metadown-hook '(org-babel-pop-to-session-maybe)
  org-export-blocks '((src org-babel-exp-src-block nil)
                      (comment org-export-blocks-format-comment t)
                      (ditaa org-export-blocks-format-ditaa nil)
                      (dot org-export-blocks-format-dot nil))
  )