From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Iverson Subject: Re: Re: org-indent mode not indenting free text? Date: Fri, 03 Dec 2010 15:21:45 -0600 Message-ID: <4CF95F69.3050303@ccbr.umn.edu> References: <4CEBF039.6040503@ccbr.umn.edu> <87aakzj2l9.wl%n.goaziou@gmail.com> <87r5ebzsll.wl%dmaus@ictsoc.de> <87oc94hqv2.fsf@Rainer.invalid> <4CF91853.9090001@ccbr.umn.edu> <47210110-87A0-4895-9194-F6ACC1B4EF16@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=60694 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POd4j-0004Yn-3t for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 16:21:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POd4h-00056s-6j for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 16:21:52 -0500 Received: from walleye.ccbr.umn.edu ([128.101.116.11]:1599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POd4g-00055s-Tr for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 16:21:51 -0500 In-Reply-To: <47210110-87A0-4895-9194-F6ACC1B4EF16@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Achim Gratz , emacs-orgmode@gnu.org, Antti Kaihola Carsten Dominik wrote: > Hi Erik, > > On Dec 3, 2010, at 5:18 PM, Erik Iverson wrote: > >> Just a guess here: This may be some weirdness >> because the check in org-indent *will* allow >> people using GNU Emacs 23.1.50 to turn on >> org-indent, as far as I can tell. > > org-indent-mode should work in 23.1.50, this is the > release where the fix was made. > >> >> The message "org-indent-mode can crash Emacs 23.1" >> does not fully explain if it can also crash 23.1.50. > > Yes, may be this is not so clear. The current setup forbids it > before 23.1.50, and allows it from 23.1.50. At least that is > what I meant. Is there a bug? No, I did not realize that this is what was indeed meant. More below... >>>> Could you back out the change >>>> (most likely the defmacro for with-silent-modifications in org-macs.el, >>>> even though I have no clue why this would interact with org-indent-mode >>>> as it should not be defined for versions >23.1) and tell us if that >>>> solves your problem (which I can't test because org-indent-mode doesn't >>>> even start on Emacs 23.1)? >>> Yes it does! I commented out: >>> ;;(if (or (< emacs-major-version 23) >>> ;; (and (<= emacs-major-version 23) >>> ;; (< emacs-minor-version 2))) >>> ;; (defmacro with-silent-modifications >>> ;; (org-unmodified))) >>> and it now works correctly. Thanks a lot! > > > I have now changed the definition like this: > > (if (and (not (fboundp 'with-silent-modifications)) > (or (< emacs-major-version 23) > (and (= emacs-major-version 23) > (< emacs-minor-version 2)))) > (defmacro with-silent-modifications (&rest body) > `(org-unmodified ,@body))) I must admit I don't understand the above macro, but what I was getting at before was: It only appears defined for Emacs < 23.2, So in particular, 23.1.50 is 'stuck' in between these two version checks, and maybe that's causing Antti's issue? > May I ask you to pull and check if this is > working for you out of the box? Works for me fine on Emacs 23.2, we will see if it does for Antti also.