From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pohlack Subject: Re: Re: skip entry with inherited tags Date: Wed, 04 Aug 2010 23:38:07 +0200 Message-ID: <4C59DDBF.8080105@os.inf.tu-dresden.de> References: <20100518074232.GA10524@mteege.de> <4BF2778D.9070702@os.inf.tu-dresden.de> <87mxvxdsv7.fsf@fastmail.fm> <4C082225.6020007@os.inf.tu-dresden.de> <4C08ED73.1000104@os.inf.tu-dresden.de> <4C343FB2.3080204@os.inf.tu-dresden.de> <4C3CA546.3060000@os.inf.tu-dresden.de> <3BFF4D35-CD16-4A41-B0A4-383538586592@gmail.com> <4C3CCDE4.9000600@os.inf.tu-dresden.de> <6694F386-1367-43D6-9587-7F26ECBC9C57@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=53107 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OglfB-0004IF-Rq for emacs-orgmode@gnu.org; Wed, 04 Aug 2010 17:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OglfA-0007JH-Hx for emacs-orgmode@gnu.org; Wed, 04 Aug 2010 17:38:13 -0400 Received: from os.inf.tu-dresden.de ([141.76.48.99]:38115) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OglfA-0007J3-Cq for emacs-orgmode@gnu.org; Wed, 04 Aug 2010 17:38:12 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Matt Lundin , emacs-orgmode@gnu.org Hi Carsten, On 22.07.2010 09:38, Carsten Dominik wrote: > Hi Martin, > > On Jul 21, 2010, at 4:32 PM, Carsten Dominik wrote: > >> Hi Martin, >> >> I just looked at your patch. >> >> If I have a normal agenda (i.e. *not* a block agenda), then your >> patch will cause the preset filter *not* to be applied. > > OK, that was obviously incorrect, sorry about that. > > However, it still does not work correctly, here is the counter example: > > ----------------------------------------------------------------------------- > * TODO test 1 :a: > * TODO test 2 :b: > > * at 1 :a: > SCHEDULED: <2010-07-22 Thu> > * at 1 :b: > SCHEDULED: <2010-07-22 Thu> > ------------------------------------------------------------------------------ Here is what I found to be incorrect. * For unmodified org-mode, this ignores the org-agenda-filter-preset. Is this what you mean or is anything else broken? * For my patched version, too much is hidden and only revealed after clearing the global filter. Did you mean anything else? > With this custom command: > > (setq org-agenda-custom-commands > '(("x" "testmartin" > ((agenda "" ((org-agenda-filter-preset '("+a")))) > (alltodo "" ((org-agenda-filter-preset '("+b"))))) > nil nil))) > > the result is incorrect, both with and without your patch. But in different ways, as state above. > The internal logic of the filter and the preset filter is such that > it applies to the entire view, and you should not set in the local > options for a command that is part of a block agenda view. Well, it is already partly there in that local filters are stored in text properties for each line. Maybe we can extend this a bit to remove this limitation? I will look into it if I have more time. Cheers, Martin