From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: org-html link building diff Date: Tue, 18 May 2010 06:47:45 +0200 Message-ID: <45F35E60-E0C4-4FF3-BBC4-F55F0B39BD90@gmail.com> References: <047c96c5361a8739fc4e8bb94abeef8e.squirrel@mail.panix.com> <9D0A8669-60C2-462F-8235-881573A664D6@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=49335 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEEij-0007Il-CI for emacs-orgmode@gnu.org; Tue, 18 May 2010 00:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEEid-00020U-RG for emacs-orgmode@gnu.org; Tue, 18 May 2010 00:47:57 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:47135) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEEid-000206-Mi for emacs-orgmode@gnu.org; Tue, 18 May 2010 00:47:51 -0400 Received: by wyb33 with SMTP id 33so196816wyb.0 for ; Mon, 17 May 2010 21:47:50 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Tom Breton (Tehom)" Cc: emacs-orgmode@gnu.org On May 18, 2010, at 2:59 AM, Tom Breton (Tehom) wrote: > > Hi, Carsten. The new changes are pushed as > tehom-html-export-refactor-build-link > > I couldn't undo the basing onto tehom-master, try though I might. > Something to do with intermediate changes that I couldn't fast-forward > and that I probably edited wrong. So I made a separate branch, > tehom-html-export-refactor-build-link, which is now pushed to the > repo. So tehom-master and html-export-refactor-build-link are already > obsolete. > > I moved the tests into top-level directory testing, as you asked. I'm > going to write a separate post describing the test conventions I use. > > Now a question: IIUC you want a branch that has no tests, that > "contains only the changes that would go into org". Since I develop > tests and code at about the same time (tests slightly before code), > I'm not sure how to arrange the branching in a maintainable way. Hi Tom, If we decide to use your emtests framework for Org on a brader basis, then there would be no reason to have a branch free of tests. This is only necessary because I am supposed to apply your patches, but without the testing framework at the moment. Maybe we should just go ahead and start using emtest for Org-mode. Why don't you go ahead and propose this in a mail to emacs-orgmode. Lets see if there is any resistance by people who understand more about testing than I do. If not, we go ahead and do it. I would still prefer to have the tests in a separate directory if your package allows to do so. Hope that this is no problem? I guess all the emtest code itself would then have to go into the org- mode git repo as well, so that we can use it? And we should develop a make target that will run all tests. - Carsten > > I could of course make a one-time branch that just removes the testing > directory. But then what happens for any future fixes? Seems like > each time I'd have to rebase that branch and pick thru changes and > make it discard each change that deals with testing/. It seems hard > to maintain. > > Tom Breton (Tehom) > > - Carsten