From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SGCGOgEFmWJfXAAAbAwnHQ (envelope-from ) for ; Thu, 02 Jun 2022 20:44:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SDCOOgEFmWIp9QAA9RJhRA (envelope-from ) for ; Thu, 02 Jun 2022 20:44:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A89C3E973 for ; Thu, 2 Jun 2022 20:44:17 +0200 (CEST) Received: from localhost ([::1]:59638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwpns-0003Ow-6P for larch@yhetil.org; Thu, 02 Jun 2022 14:44:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpmt-0003Om-Ms for emacs-orgmode@gnu.org; Thu, 02 Jun 2022 14:43:15 -0400 Received: from mail.sift.net ([50.249.120.161]:58108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpms-0003RN-3i for emacs-orgmode@gnu.org; Thu, 02 Jun 2022 14:43:15 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.sift.net (Postfix) with ESMTP id 5CA628309E67 for ; Thu, 2 Jun 2022 13:43:12 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sift.net; h= content-type:content-type:mime-version:message-id:x-mailer:date :date:subject:subject:from:from:received:received; s=sift-net; t=1654195391; x=1655059392; bh=lYlws77S7aE12LRmZNtBRdBkN9nWQ3FK r7I11O17Wmo=; b=RKc66OQ6aL408g1uEatZrF8aSFQ0nZB2agONJRi39MDnzowi +VBQlo45WTF2dbgTXsLwEbZIoTta7uhu2Wd+Xtnq/3E5y91z/kjAt8RAd7mtNDYs niXY2wmw6LQA3KqjB0OcNlHioExcCyWEsL/jARMX+4vP4WmjAaBF+gpR/NaN8SeJ J59auhXmQqmj7hPGoWLd141t11pP7HxJli+VftcalFIpV1SSX0OEJNmMwQ2Q3bwC DpYBHhn5plTIUeRfahnPE1OSR5+P5laueeY0tKVXElChZoI77qzz78vnb55kXVyj oqS0rMmO97XauXbXO+VcJPLGyY8FoSfr2I7cgQ== X-Virus-Scanned: Debian amavisd-new at sift.net Received: from mail.sift.net ([127.0.0.1]) by localhost (mail.sift.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rVQSYayoprVw for ; Thu, 2 Jun 2022 13:43:11 -0500 (CDT) Received: from [10.7.8.208] (RPG-MacBook-Pro.sift.net [10.7.8.208]) (Authenticated sender: rpg) by mail.sift.net (Postfix) with ESMTPSA id 61F3C8309DD1 for ; Thu, 2 Jun 2022 13:43:11 -0500 (CDT) From: Robert Goldman To: emacs-orgmode@gnu.org Subject: Error with org-agenda with 9.5.3 Date: Thu, 02 Jun 2022 13:43:10 -0500 X-Mailer: MailMate (1.14r5897) Message-ID: <45E5BD65-878F-4BF8-A5CF-C42CE7B63A75@sift.net> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_5598B5CC-D0BD-4E64-8978-298B4374CB2F_=" Received-SPF: pass client-ip=50.249.120.161; envelope-from=rpgoldman@sift.net; helo=mail.sift.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654195457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b/mQgkSNuXxMRnnrkfUb8m0dEzqQo61cwOzwyFxHvI4=; b=X/d/cobAMBITT/nSFDdIf6FF4rAuKPbus96aA1qHYnTfXv2CfXEB8CzfOC8Q8kxUJooBq/ yEhTwTk0T7BTZedeUfkQrEUWyV9pWsOJTKMjKBEXEKrL+9tp3IIxJs1SMLR9JQ/KD4xA6j qr01mCppRmUVy9DYI4VfoRL6pzkPD287UJaspclKhYtKMc5AyDPp6e3XSoNxxn9vLTJ6l2 I4OvHam+4oKUrENpxVd+LVsylo/aLBtHYRuRdcnqitGYaO2vQVL8RysX0apMeFKKlHxdd+ 5nwXIbhafxTBktxQFcZ5NuT9akn1bh5tYAq0p76H2i/qJe/GUTVvqpsa3avBXg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654195457; a=rsa-sha256; cv=none; b=PR1MSx5zAthYJ7Xvh73VHZcImENdPbwSSiuOrf60jdzO/n4PO8xfZoQ1BgJR/6ameTGrrE pHSUv0VPuoY2cL1+K4a2nyScfJ0TjVmCISym62V/b0jKs0xPBDEWd4nCdOvCBQ+uw/iUAm qhyHr3c4OHktbpnRDAyapXdgDguksN0FGjxFP5cslQzPjZJuzZcqkvo29GQln9XUV7K6ni V0UsPGF+p6XcVRyoatxig7i9norRq6w0B2JxOBgHObwNm+eaTZY6L1NKKafV1HXlveHlFc x5rgzXxA4kmchLhWcwI3DNKta7s0HjSqoMGRtc+4MLA9S1O4qt8BNKQDOfxZ2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=sift.net header.s=sift-net header.b=RKc66OQ6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.52 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=sift.net header.s=sift-net header.b=RKc66OQ6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A89C3E973 X-Spam-Score: -3.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: tjxFuzITO7Ti --=_MailMate_5598B5CC-D0BD-4E64-8978-298B4374CB2F_= Content-Type: text/plain; format=flowed; markup=markdown I just updated org-mode using package.el and got release 9.5.3 Now I get an error in `org-at-timestamp-p` (OATP), which is invoked when calling `org-agenda`. I checked the repository and the problem is in commit 1f617727f1, which added to this function the following code block: ``` - (let* ((regexp (if extended - (if (eq extended 'agenda) - org-element--timestamp-regexp - org-ts-regexp3) - org-ts-regexp2)) + (let* ((regexp + (if extended + (if (eq extended 'agenda) + (rx (or (regexp org-ts-regexp3) + (regexp org-element--timestamp-regexp))) + org-ts-regexp3) + org-ts-regexp2)) ``` The issue arises where OATP uses `rx` to process a regex stored in `org-ts-regexp3`: ``` (rx (or (regexp org-ts-regexp3) ; here (regexp org-element--timestamp-regexp))) ``` This fails because `rx-check` checks the sub-expression `(regexp org-ts-regexp3)` to make sure that `org-ts-regexp3` is a string, but `org-ts-regexp3` is not evaluated, and the *symbol* `org-ts-regexp3` is not a string (it's a symbol), even though it's *value* is a string. I'm not sure whether this is a bug in org-mode proper (I would have thought this would be caught before release) or perhaps org-mode expects some version of `rx.el` that I do not have. Unfortunately, I don't see a version number in `rx.el`, only a copyright date. I am running Emacs 25 (Aquamacs). So, maybe this code requires Emacs 26? If so, it would be nice if org-mode 9.5.3 was tagged as incompatible with Emacs 25? (It would also be nice if package mode supported roll-back, but that's OT here!) --=_MailMate_5598B5CC-D0BD-4E64-8978-298B4374CB2F_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

I just updated org-mode using package.el and got release = 9.5.3

Now I get an error in org-at-timest= amp-p (OATP), which is invoked when calling = org-agenda.

I checked the repository and the problem is in commit 1f6= 17727f1, which added to this function the following code block:

-  (let* ((regexp (if extended
-                     (if (eq extended 'agenda)
-                         org-element--timestamp-regexp
-		       org-ts-regexp3)
-                   org-ts-regexp2))
+  (let* ((regexp
+          (if extended
+              (if (eq extended 'agenda)
+                  (rx (or (regexp org-ts-regexp3)
+                          (regexp org-element--timestamp-regexp)))
+		org-ts-regexp3)
+            org-ts-regexp2))

The issue arises where OATP uses rx= to process a regex stored in org-ts-regexp3= :

(rx (or (regexp org-ts-regexp3) ; here
        (regexp org-element--timestamp-regexp)))

This fails because rx-check = checks the sub-expression (regexp org-ts-regexp3) to make sure that org-ts-regexp3 is a = string, but org-ts-regexp3 is not evaluated,= and the symbol org-ts-regexp3 is n= ot a string (it's a symbol), even though it's value is a string.=

I'm not sure whether this is a bug in org-mode proper (I = would have thought this would be caught before release) or perhaps org-mo= de expects some version of rx.el that I do n= ot have. Unfortunately, I don't see a version number in rx.el, only a copyright date.

I am running Emacs 25 (Aquamacs). So, maybe this code req= uires Emacs 26? If so, it would be nice if org-mode 9.5.3 was tagged as i= ncompatible with Emacs 25? (It would also be nice if package mode support= ed roll-back, but that's OT here!)

--=_MailMate_5598B5CC-D0BD-4E64-8978-298B4374CB2F_=--