Bug when following a link (org-open-at-point)

Bug when following a link (org-open-at-point)

[Stephan Schmitt]

hello,

i just downloaded org-mode 4.50 and
got an error when i tried to follow
an internal link (C-c C-o, Mouse-2).

i traced the problem back to following
function in org.el:

(defun org-file-remote-p (file)
  "Test whether FILE specifies a location on a remote system.
Return non-nil if the location is indeed remote.

For example, the filename \"/user@host:/foo\" specifies a location
on the system \"/user@host:\"."
  (cond ((fboundp 'file-remote-p)
         (file-remote-p file))
        ((fboundp 'tramp-handle-file-remote-p)
         (tramp-handle-file-remote-p file))
        ((and (boundp 'ange-ftp-name-format)
              (string-match ange-ftp-name-format file))
         t)
        (t nil)))

the third condition (string-match ange-ftp-name-format file)
tries to match a list against a string,
ange-ftp.el:

(defcustom ange-ftp-name-format
  '("^/\\(\\([^@/:]*\\)@\\)?\\([^@/:]*[^@/:.]\\):\\(.*\\)" . (3 2 4))
  "*Format of a fully expanded remote file name.

This is a list of the form \(REGEXP HOST USER NAME\),
where REGEXP is a regular expression matching
the full remote name, and HOST, USER, and NAME are the numbers of
parenthesized expressions in REGEXP for the components (in that order)."
  :group 'ange-ftp
  :type '(list regexp
	       (integer :tag "Host group")
	       (integer :tag "User group")
	       (integer :tag "Name group")))

i solved the problem by changing the condition
(string-match ange-ftp-name-format file)
into
(string-match (car ange-ftp-name-format) file)

best regards,
	stephan

Re: Bug when following a link (org-open-at-point)

[Carsten Dominik]

Hi Stefan,

I really love it when someone goes all the way to analyze and fix a bug.
Thank you very much, this fix will be in the next version of org-mode.

- Carsten

On Sep 27, 2006, at 11:41, Stephan Schmitt wrote:

> hello,
>
> i just downloaded org-mode 4.50 and
> got an error when i tried to follow
> an internal link (C-c C-o, Mouse-2).
>
> i traced the problem back to following
> function in org.el:
>
> (defun org-file-remote-p (file)
>  "Test whether FILE specifies a location on a remote system.
> Return non-nil if the location is indeed remote.
>
> For example, the filename \"/user@host:/foo\" specifies a location
> on the system \"/user@host:\"."
>  (cond ((fboundp 'file-remote-p)
>         (file-remote-p file))
>        ((fboundp 'tramp-handle-file-remote-p)
>         (tramp-handle-file-remote-p file))
>        ((and (boundp 'ange-ftp-name-format)
>              (string-match ange-ftp-name-format file))
>         t)
>        (t nil)))
>
> the third condition (string-match ange-ftp-name-format file)
> tries to match a list against a string,
> ange-ftp.el:
>
> (defcustom ange-ftp-name-format
>  '("^/\\(\\([^@/:]*\\)@\\)?\\([^@/:]*[^@/:.]\\):\\(.*\\)" . (3 2 4))
>  "*Format of a fully expanded remote file name.
>
> This is a list of the form \(REGEXP HOST USER NAME\),
> where REGEXP is a regular expression matching
> the full remote name, and HOST, USER, and NAME are the numbers of
> parenthesized expressions in REGEXP for the components (in that 
> order)."
>  :group 'ange-ftp
>  :type '(list regexp
> 	       (integer :tag "Host group")
> 	       (integer :tag "User group")
> 	       (integer :tag "Name group")))
>
> i solved the problem by changing the condition
> (string-match ange-ftp-name-format file)
> into
> (string-match (car ange-ftp-name-format) file)
>
> best regards,
> 	stephan
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477