emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug when following a link (org-open-at-point)
@ 2006-09-27  9:41 Stephan Schmitt
  2006-09-27 21:52 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Stephan Schmitt @ 2006-09-27  9:41 UTC (permalink / raw)
  To: emacs-orgmode

hello,

i just downloaded org-mode 4.50 and
got an error when i tried to follow
an internal link (C-c C-o, Mouse-2).

i traced the problem back to following
function in org.el:

(defun org-file-remote-p (file)
  "Test whether FILE specifies a location on a remote system.
Return non-nil if the location is indeed remote.

For example, the filename \"/user@host:/foo\" specifies a location
on the system \"/user@host:\"."
  (cond ((fboundp 'file-remote-p)
         (file-remote-p file))
        ((fboundp 'tramp-handle-file-remote-p)
         (tramp-handle-file-remote-p file))
        ((and (boundp 'ange-ftp-name-format)
              (string-match ange-ftp-name-format file))
         t)
        (t nil)))

the third condition (string-match ange-ftp-name-format file)
tries to match a list against a string,
ange-ftp.el:

(defcustom ange-ftp-name-format
  '("^/\\(\\([^@/:]*\\)@\\)?\\([^@/:]*[^@/:.]\\):\\(.*\\)" . (3 2 4))
  "*Format of a fully expanded remote file name.

This is a list of the form \(REGEXP HOST USER NAME\),
where REGEXP is a regular expression matching
the full remote name, and HOST, USER, and NAME are the numbers of
parenthesized expressions in REGEXP for the components (in that order)."
  :group 'ange-ftp
  :type '(list regexp
	       (integer :tag "Host group")
	       (integer :tag "User group")
	       (integer :tag "Name group")))

i solved the problem by changing the condition
(string-match ange-ftp-name-format file)
into
(string-match (car ange-ftp-name-format) file)

best regards,
	stephan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug when following a link (org-open-at-point)
  2006-09-27  9:41 Bug when following a link (org-open-at-point) Stephan Schmitt
@ 2006-09-27 21:52 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2006-09-27 21:52 UTC (permalink / raw)
  To: Stephan Schmitt; +Cc: emacs-orgmode

Hi Stefan,

I really love it when someone goes all the way to analyze and fix a bug.
Thank you very much, this fix will be in the next version of org-mode.

- Carsten

On Sep 27, 2006, at 11:41, Stephan Schmitt wrote:

> hello,
>
> i just downloaded org-mode 4.50 and
> got an error when i tried to follow
> an internal link (C-c C-o, Mouse-2).
>
> i traced the problem back to following
> function in org.el:
>
> (defun org-file-remote-p (file)
>  "Test whether FILE specifies a location on a remote system.
> Return non-nil if the location is indeed remote.
>
> For example, the filename \"/user@host:/foo\" specifies a location
> on the system \"/user@host:\"."
>  (cond ((fboundp 'file-remote-p)
>         (file-remote-p file))
>        ((fboundp 'tramp-handle-file-remote-p)
>         (tramp-handle-file-remote-p file))
>        ((and (boundp 'ange-ftp-name-format)
>              (string-match ange-ftp-name-format file))
>         t)
>        (t nil)))
>
> the third condition (string-match ange-ftp-name-format file)
> tries to match a list against a string,
> ange-ftp.el:
>
> (defcustom ange-ftp-name-format
>  '("^/\\(\\([^@/:]*\\)@\\)?\\([^@/:]*[^@/:.]\\):\\(.*\\)" . (3 2 4))
>  "*Format of a fully expanded remote file name.
>
> This is a list of the form \(REGEXP HOST USER NAME\),
> where REGEXP is a regular expression matching
> the full remote name, and HOST, USER, and NAME are the numbers of
> parenthesized expressions in REGEXP for the components (in that 
> order)."
>  :group 'ange-ftp
>  :type '(list regexp
> 	       (integer :tag "Host group")
> 	       (integer :tag "User group")
> 	       (integer :tag "Name group")))
>
> i solved the problem by changing the condition
> (string-match ange-ftp-name-format file)
> into
> (string-match (car ange-ftp-name-format) file)
>
> best regards,
> 	stephan
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-27 21:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-27  9:41 Bug when following a link (org-open-at-point) Stephan Schmitt
2006-09-27 21:52 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).