From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uM5HDhO8gmCfkwAAgWs5BA (envelope-from ) for ; Fri, 23 Apr 2021 14:22:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CFQXChO8gmCNKAAA1q6Kng (envelope-from ) for ; Fri, 23 Apr 2021 12:22:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 971019C10 for ; Fri, 23 Apr 2021 14:22:42 +0200 (CEST) Received: from localhost ([::1]:45522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZupU-0008Og-T6 for larch@yhetil.org; Fri, 23 Apr 2021 08:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZuoH-0008OO-58 for emacs-orgmode@gnu.org; Fri, 23 Apr 2021 08:21:25 -0400 Received: from ciao.gmane.io ([116.202.254.214]:60782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZuoF-0001VZ-NW for emacs-orgmode@gnu.org; Fri, 23 Apr 2021 08:21:24 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lZuo8-0007bT-Gr for emacs-orgmode@gnu.org; Fri, 23 Apr 2021 14:21:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] org-protocol: Fix missing '+' in js snippet Date: Fri, 23 Apr 2021 19:21:10 +0700 Message-ID: <41e021be-e973-652b-fd04-b1b4524b959b@gmail.com> References: <20210419105316.10227-1-vid@bina.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210419105316.10227-1-vid@bina.me> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Asabina Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619180562; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=T64oL+jIVRmbJxdc8PEUrCrwGirXx4uUByiOndqOKx4=; b=Mc5UR0lgUFgRVzfcVYYtyA4DtZQ74UUTSSlfpo4BKFwOxHecZ/oND/A3IQd1mtsAx2CbB5 hiK5EH0TVWJ15Dhd+ZKd1ScES8hyefjSI48ExWnlF8q6mBauKqDEWgVkIt0ZdcTQWSSHlV TX1vG5N7FEefuHD1mO1hTzaqMdcmW2PYvuJlE4ZWdjp28ID/gAhoQALnEOzzrAokEWXXAx CTDcFOH9DQIV1OwFhPuHkxZIgSAIo5dpYuj0y1mrxDvA4isK9GYC8VRJXOFU2NqvXpTPtO tRmw6dXorwE6kspPAqME7FY6z18SbGyHRG5dQZls4ZckhXVLCus2Hf/ImogcOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619180562; a=rsa-sha256; cv=none; b=irboWIauNdsDwhif9jJ2uRbBhBvf/EFxhlypUjth9Urkvfc7kyJTfsXVzPnDNx5JChazyA 1FRGr0Hntwg2PMGN33XIXk1yFF26GbPWsyNgOVbmDQhyg5g5bNPHSbc2Tg9ux1yNeX/Y6+ I5mZB+90ZKeAGKWbU4hvMoApafaj0MjzpMgxlmfzU8/Xfjih12TpWT8uz6aYukEO9/enFr x8rLB3bo5hBp3T7YsFPknRVnlWUhbET8lfQg560kPxPveR78oFwbOsI4j2XVXpSni9Zduf nGeAsvAIRtxfqtkZ2Wr99lwbeysFkk1zzgCeXz8Nr7FstwmKm7xHBS62B/Qhcw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.34 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 971019C10 X-Spam-Score: -0.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: hwyFeVwZh4EU On 19/04/2021 17:53, David Asabina wrote: > > javascript:location.href = \\='org-protocol://capture?url=\\='+ \\ > - encodeURIComponent(location.href) + \\='&title=\\=' \\ > + encodeURIComponent(location.href) + \\='&title=\\=' + \\ > encodeURIComponent(document.title) + \\='&body=\\=' + \\ > encodeURIComponent(window.getSelection()) I am not a maintainer, so I can not merge the patch. I hope, finally it will happen, maybe some months later. I have a question that is a bit off-topic in this thread however. Since you are setting up org-protocol, you may notice other issues. There were reports that two slashes after "org-protocol:" cause some problems. My guess is that capture is recognized as hostname, so another slash is inserted after it. There was a patch allowing "/" before "?" to get things work (perhaps on Windows). Could you try, please, if one or three slashes in org-protocol URIs ("org-protocol:/capture?url=..." and "org-protocol:///capture?url=...") works properly in your environment? Maybe code examples in docs would benefit from one more correction.