From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gKjbHkwcbWKybQAAbAwnHQ (envelope-from ) for ; Sat, 30 Apr 2022 13:23:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cK4YHkwcbWLVhAAAG6o9tA (envelope-from ) for ; Sat, 30 Apr 2022 13:23:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2459B29DF1 for ; Sat, 30 Apr 2022 13:23:56 +0200 (CEST) Received: from localhost ([::1]:54022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nklCc-0006Kp-9b for larch@yhetil.org; Sat, 30 Apr 2022 07:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nklB2-000622-GJ for emacs-orgmode@gnu.org; Sat, 30 Apr 2022 07:22:16 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:39732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nklB0-0002i7-Mv for emacs-orgmode@gnu.org; Sat, 30 Apr 2022 07:22:16 -0400 Received: by mail-lf1-x134.google.com with SMTP id y32so18074799lfa.6 for ; Sat, 30 Apr 2022 04:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:cc:from:in-reply-to :content-transfer-encoding; bh=vRBh76f0PKBPfzVyG71Y2c4FgwX3TWlymRhCNLptNMA=; b=f5vw0XHXNEgsQoohfB0hRYgbj70k4EnbsjWtPbTYpMC6s69nvvLOG4YolZXX+VN1dW 7IukFRlhj09FRIIZIBDv34YEHFcSrguvBA3gCCSa5lMu4MYUAbnxLpJ8tX2l43lUg8J0 CPAynlwLsSq/zKOcAXhv1zKeCnJ4PbiBmxVh5V+2a02susWysAPGOxzmRCe8yzQeW81Q vH/kp5rluQuGq3MygUCqiHp/zgtXXdwz6x0Kgw1ub7lNbLTlQuBXww7tn9WgVnKJKA5t oMt9nww9kaFLG67xXFKpSOGL4NH9gBAMyQgZ10f2UK0gof4UGTP2Fy22l3pLE0Ul0/MQ fOyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:cc:from:in-reply-to :content-transfer-encoding; bh=vRBh76f0PKBPfzVyG71Y2c4FgwX3TWlymRhCNLptNMA=; b=YAlip0FRvyVXX32sZyjwkdVNPV01PeHdJ1uEov20S798NWdRJGGgAgcaiBNVVracXu pSetT1lxhVif7JlxkFYCNuKqNOlkPYHrR2mJOTcL5lf2ALshg7QpB5cfNjVddXYnsPrd PHkNt9c9keDd0LV+zsSQvy+enc6RqDD/HAWLBsDB0174dE8YQKKyMa7y3kMMxzw22PyD TA8sJvzfzGcw1/J+ROsPkLnQ7w6EJvg8ddsNY1AUBSiLrkd2xVQS0huyr4jbfBOw/Rzd P8q5OdlWUbW3t0IfE1eK0/4T5fK+95wjI50A5BZNk1A2ibX9rZCkNNyAvOnFFfUPFATk Yl3w== X-Gm-Message-State: AOAM533lCcdGvMCjX5c8O3ERQQfJ966vQZ4cT1KkFSUDzGLy6fa5Ay+r f5GeLvA3WXKrBv6KCmZfxnw= X-Google-Smtp-Source: ABdhPJw4uoDDc85jRNVSJESABVScu54VC7gg+b+sgdQam8vyYv/3gZExw6dgJW3X35+PD74Gsp78Rw== X-Received: by 2002:a05:6512:1046:b0:471:b73e:f55d with SMTP id c6-20020a056512104600b00471b73ef55dmr2773799lfb.390.1651317732814; Sat, 30 Apr 2022 04:22:12 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id f15-20020ac251af000000b0047255d21118sm168997lfk.71.2022.04.30.04.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Apr 2022 04:22:12 -0700 (PDT) Message-ID: <3c017c45-c82a-cb0e-6352-fabb21e7ac37@gmail.com> Date: Sat, 30 Apr 2022 18:22:11 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones Content-Language: en-US To: 54764@debbugs.gnu.org, eggert@cs.ucla.edu References: <5ed963b2-3fa8-48d8-627e-bc0571d15b43@gmail.com> <149de00f-115b-5367-414f-c7700ef8966b@cs.ucla.edu> <2dd15844-01b3-0144-740c-185ec8488a81@cs.ucla.edu> <4a23f3a4-fe8f-d396-49d8-10034803be63@gmail.com> <52fb10fb-892a-f273-3be8-28793f27e204@cs.ucla.edu> <5cd820d4-ae67-43d4-9e63-c284d51ff1e4@gmail.com> <25d90a4b-f47d-01b4-2bfe-9951e97fe676@gmail.com> <355c422f-6945-e670-4610-70e67035e193@gmail.com> <4bd57f21-0660-fce0-d796-08c534402340@cs.ucla.edu> <42fc4072-4f8f-c6d3-ca39-2308f4597523@cs.ucla.edu> From: Max Nikulin In-Reply-To: <42fc4072-4f8f-c6d3-ca39-2308f4597523@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=manikulin@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651317836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vRBh76f0PKBPfzVyG71Y2c4FgwX3TWlymRhCNLptNMA=; b=a8qNgEnE+Zb34SCFoydLhCrkghYkinIxfkvr0/mRNwwD9vx9BQI58jyKlafuBFfVw1+SuV i+4qI70PwqOHMv8JTQGEbMvaaITyZzAINhBcOeW4+1ie46ifS+CPzNKSaIvfkZc88fphlw R6tOuyDh83ECwGVLK6NvLx+PtIUu41oDWviVYf7VMglDGzc8SRqBLga/bLljYDR/xSpJQ4 dteQtx4RQY4xeKErd/YGzWiEGwE9Q+l4p3ZqKhSDPygMHwGdee6wzDOjoStcSGMqtQ9C/S qkhfeuK2QRdrCQ8zsCbpE1m7ikqHxrBlJ9b2WbUMWHPKg9bvf6n1GLqI1rCR0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651317836; a=rsa-sha256; cv=none; b=sETK8newB2eW0xAIoAmD0dAcHdsKqViH29Bu6JB3FcS0UKPmyIZGm9lxSIYXe09N/+qFlI eeFLyiHiye6McWrTBIFAMPYJRBb+Nk+H71WLzswGi8nBYxUGjr9BXpDod/NEuHNukSruBm DNN7T0YCHal4kwxMoENX/UryXLJItyPVklQX9M7nzRqhE0HgtnjJzkLstaZnMkeQa0HYVN kEDzPSh1V6IfKi9K7iJ51Ib1/mt6ZLG1trea4toFtf0iN/JdKvnVOK0zVV7C3vssAh8QOy mXf4MR/04/bn564SI1Zp4WrE4Lxjj3ZQsfIDkg4qxr6+3+htrfbmnu+KeDfjSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=f5vw0XHX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=f5vw0XHX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2459B29DF1 X-Spam-Score: 7.70 X-Migadu-Scanner: scn1.migadu.com X-TUID: +6UOhAbWc3Vd On 26/04/2022 02:49, Paul Eggert wrote: > On 4/25/22 08:37, Paul Eggert wrote: > > I'll be happy to review the revised org-encode-time implementation, > whenever you think it could use a review. (Sorry, I've lost track of > what the proposal is.) I suspended my activity due to discussions of other changes and waiting for commits related to your fixes of `org-parse-time-string' and `org-store-link' that do not require introducing of `org-encode-time-1'. I mean excerpts from https://debbugs.gnu.org/cgi/bugreport.cgi?att=1;msg=10;bug=54764;filename=0001-Improve-Org-usage-of-timestamps.patch I posted a corrected version of my `org-encode-time' macro, but I did not add you to Cc (I sent reply through news.gmane.io), and it has no special case to check whether `encode-time' supports 6 elements list argument: Max Nikulin to emacs-orgmode. [DRAFT][PATCH v2] org-encode-time compatibility and convenience helper. Sun, 24 Apr 2022 18:34:40 +0700. https://list.orgmode.org/t43cki$ct$1@ciao.gmane.io In my drafts I have the following changes in tests related to `org-parse-time-string': diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index 6aecc3af8..551d17d64 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -268,15 +268,15 @@ (ert-deftest test-org/org-parse-time-string () "Test `org-parse-time-string'." (should (equal (org-parse-time-string "2012-03-29 16:40") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "[2012-03-29 16:40]") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29 16:40>") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>") - '(0 0 0 29 3 2012 nil nil nil))) + '(0 0 0 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>" t) - '(0 nil nil 29 3 2012 nil nil nil)))) + '(0 nil nil 29 3 2012 nil -1 nil)))) (ert-deftest test-org/closest-date () "Test `org-closest-date' specifications."