emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Dan Davison <davison@stats.ox.ac.uk>
Cc: emacs org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] why is '-' not allowed in radio table name?
Date: Sun, 18 Apr 2010 08:10:37 +0200	[thread overview]
Message-ID: <3CF86F83-6856-49EB-9167-135DF9FD8237@gmail.com> (raw)
In-Reply-To: <87k4s53gxm.fsf@stats.ox.ac.uk>

Applied, thanks.

- Carsten

On Apr 17, 2010, at 11:30 PM, Dan Davison wrote:

> I was using a radio table to convert an org table to texinfo, and got
> stuck for a bit until looking at the code and seeing that the name  
> used
> for the radio table can not contain '-' (only letters, numbers and
> underscore). Is there a reason for this restriction? An alternative
> regexp is below (which also allows tabs as whitespace).
>
> Dan
>
>
> 	Modified lisp/org-table.el
> diff --git a/lisp/org-table.el b/lisp/org-table.el
> index 5839203..1d463a0 100644
> --- a/lisp/org-table.el
> +++ b/lisp/org-table.el
> @@ -3800,7 +3800,7 @@ a radio table."
>     (goto-char (org-table-begin))
>     (let (rtn)
>       (beginning-of-line 0)
> -      (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND +\\([a- 
> zA-Z0-9_]+\\) +\\([^ \t\r\n]+\\)\\( +.*\\)?")
> +      (while (looking-at "[ \t]*#\\+ORGTBL[: \t][ \t]*SEND[ \t]+\\ 
> ([^ \t\r\n]+\\)[ \t]+\\([^ \t\r\n]+\\)\\([ \t]+.*\\)?")
> 	(let ((name (org-no-properties (match-string 1)))
> 	      (transform (intern (match-string 2)))
> 	      (params (if (match-end 3)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

      reply	other threads:[~2010-04-18  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-17 21:30 [PATCH] why is '-' not allowed in radio table name? Dan Davison
2010-04-18  6:10 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CF86F83-6856-49EB-9167-135DF9FD8237@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=davison@stats.ox.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).