[BUG] Newlines after links are fontified with the org-link face after an incremental search

[BUG] Newlines after links are fontified with the org-link face after an incremental search

[Rohit Patnaik]

Hello everyone,

I've noticed a potential regression in the way that org-mode fontifies links in
the latest git main branch version of org-mode. When the user conducts an
incremental search that matches a link that runs to the end of the line, for 
some reason the =org-link= face is extended to cover the newline as well.

Detailed repro steps:
1. Run =make repro= from the =main= branch
2. Switch the scratch buffer to org-mode with =M-x org-mode=
3. Add two lines
   - The first line should be a link, for example:
     [[https://www.google.com][Link]]
   - The second line should be a blank line
4. Place the point at the beginning of the first line
5. Hit =C-s= to begin an incremental search and search for the link description
   (i.e. =Link=)
6. Hit =RET= to leave the search
7. Note that the link underline now seems to extend past the end of the link
   text
8. Place the point at the end of the line and hit =M-x describe-char=. You
   should see that the character is a =C-j=, and the face is =org-link=

The above result does not occur when I check out the =release_9.6.17= tag, which
is why I think it might be a regression. 

My version of emacs is: 

GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.8, 
Xaw3d scroll bars) of 2023-08-02

My operating system is Fedora Linux 39, running Gnome 45.3 on Wayland.

Thanks,
Rohit Patnaik

Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Ihor Radchenko]

"Rohit Patnaik" <quanticle@quanticle.net> writes:

> I've noticed a potential regression in the way that org-mode fontifies links in
> the latest git main branch version of org-mode. When the user conducts an
> incremental search that matches a link that runs to the end of the line, for 
> some reason the =org-link= face is extended to cover the newline as well.
>
> Detailed repro steps:
> 1. Run =make repro= from the =main= branch
> 2. Switch the scratch buffer to org-mode with =M-x org-mode=
> 3. Add two lines
>    - The first line should be a link, for example:
>      [[https://www.google.com][Link]]
>    - The second line should be a blank line
> 4. Place the point at the beginning of the first line
> 5. Hit =C-s= to begin an incremental search and search for the link description
>    (i.e. =Link=)
> 6. Hit =RET= to leave the search
> 7. Note that the link underline now seems to extend past the end of the link
>    text

Fixed, on main; for Emacs >=29. Will not be fixed for earlier Emacs versions.

isearch + folding is very hard to make work reliably. We need to have
ugly workarounds. And not only for isearch - a number of other parts of
Emacs and third-party code exclusively support overlay folding.

Considering that overlays are no longer performance bottleneck, switched
back to using overlays for folding by default, except in Emacs <=28
where the overlays were slow. After Emacs 31 is released, folding via
text properties will be removed.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Rohit Patnaik]

> Fixed, on main; for Emacs >=29. Will not be fixed for earlier Emacs versions.

I've confirmed that it's fixed. Thanks so much for the fast turnaround!

Rohit Patnaik

Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Rohit Patnaik]

Hello,

It seems like this fix regressed as a result of commit
5d186b499dde97f59a91dc11f4c4a15113d29f4d. After I updated to the latest version
of org-mode again, I noticed that the fontification of newlines was back. When I
created a branch that reverted 5d186b499dde97f59a91dc11f4c4a15113d29f4d, the
fontification behaving as it should.

Thanks,
Rohit Patnaik

Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Ihor Radchenko]

"Rohit Patnaik" <quanticle@quanticle.net> writes:

> It seems like this fix regressed as a result of commit
> 5d186b499dde97f59a91dc11f4c4a15113d29f4d. After I updated to the latest version
> of org-mode again, I noticed that the fontification of newlines was back. When I
> created a branch that reverted 5d186b499dde97f59a91dc11f4c4a15113d29f4d, the
> fontification behaving as it should.

Thanks for the heads up!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9f6894c10

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Newlines after links are fontified with the org-link face after an incremental search

[Rohit Patnaik]

Confirmed fixed.

Thanks for the quick turnaround!

Rohit