emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Rohit Patnaik" <quanticle@quanticle.net>
To: emacs-orgmode@gnu.org
Subject: [BUG] Newlines after links are fontified with the org-link face after an incremental search
Date: Fri, 02 Feb 2024 01:03:04 -0600	[thread overview]
Message-ID: <38cddb14-78a9-424a-b83f-5b9f9217f8bc@app.fastmail.com> (raw)

Hello everyone,

I've noticed a potential regression in the way that org-mode fontifies links in
the latest git main branch version of org-mode. When the user conducts an
incremental search that matches a link that runs to the end of the line, for 
some reason the =org-link= face is extended to cover the newline as well.

Detailed repro steps:
1. Run =make repro= from the =main= branch
2. Switch the scratch buffer to org-mode with =M-x org-mode=
3. Add two lines
   - The first line should be a link, for example:
     [[https://www.google.com][Link]]
   - The second line should be a blank line
4. Place the point at the beginning of the first line
5. Hit =C-s= to begin an incremental search and search for the link description
   (i.e. =Link=)
6. Hit =RET= to leave the search
7. Note that the link underline now seems to extend past the end of the link
   text
8. Place the point at the end of the line and hit =M-x describe-char=. You
   should see that the character is a =C-j=, and the face is =org-link=

The above result does not occur when I check out the =release_9.6.17= tag, which
is why I think it might be a regression. 

My version of emacs is: 

GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.8, 
Xaw3d scroll bars) of 2023-08-02

My operating system is Fedora Linux 39, running Gnome 45.3 on Wayland.

Thanks,
Rohit Patnaik


             reply	other threads:[~2024-02-02  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02  7:03 Rohit Patnaik [this message]
2024-02-02 13:23 ` [BUG] Newlines after links are fontified with the org-link face after an incremental search Ihor Radchenko
2024-02-02 16:30   ` Rohit Patnaik
2024-02-25 20:34     ` Rohit Patnaik
2024-02-26 12:54       ` Ihor Radchenko
2024-02-26 22:41         ` Rohit Patnaik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38cddb14-78a9-424a-b83f-5b9f9217f8bc@app.fastmail.com \
    --to=quanticle@quanticle.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).