From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#25132: 26.0.50; emacs hangs when loading org file with python
 source blocks
Date: Mon, 23 Jan 2017 06:53:21 +0300
Message-ID: <345079d3-9578-9ab9-1444-353843a70f8b__13399.7557139539$1485143693$gmane$org@yandex.ru>
References: <m2fulz4mjc.fsf@CIVIC-TV.local> <qwa8c75g0r.fsf@fencepost.gnu.org>
	<4aa23451-b6cd-88b0-369e-99f6fe5f2175@gmail.com>
	<m260murisv.fsf@block-party.net> <87y3yn2x4j.fsf@users.sourceforge.net>
	<87eg0e36un.fsf@users.sourceforge.net>
	<aa494e14-f35a-92c4-b954-c7ba8e4ab4b1@yandex.ru>
	<878tq6wo1p.fsf@users.sourceforge.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cVVhn-00080y-6b
	for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 22:54:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cVVhm-0002Oj-CX
	for emacs-orgmode@gnu.org; Sun, 22 Jan 2017 22:54:07 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25132.B25132.148514361130274@debbugs.gnu.org>
In-Reply-To: <878tq6wo1p.fsf@users.sourceforge.net>
Content-Language: en-US
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: npostavs@users.sourceforge.net
Cc: David Dynerman <emperordali@block-party.net>, 25132@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pit@gmail.com>

On 20.01.2017 03:52, npostavs@users.sourceforge.net wrote:

> My feeling is that inhibit-modification-hooks should usually be buffer
> local anyway.

Maybe you're right.

inhibit-read-only, bound nearby, seems to be in the same situation.

>> If we are not, why not make inhibit-modification-hooks always
>> buffer-local instead?
>
> It would have to be in addition to, because even after doing
> (make-variable-buffer-local 'var), (let ((var 'foo))...) still makes a
> global binding.  `make-variable-buffer-local' only has effect for
> `setq', which I think will hardly ever happen for
> `inhibit-modification-hooks'.

You're right, and that sounds a little too complicated for my taste.

So, personally, I'd try to fix the particular instance first. Switching 
buffers inside with-silent-modifications is not a very common usage, I 
think.

Maybe org-src should itself let-bind the aforementioned variable(s) 
where it visits other buffers.

Up to you, of course, since you've already been given the go-ahead for 
the proposed fix.