Bug: logging & PROPERTIES [6.36trans]

Bug: logging & PROPERTIES [6.36trans]

[Giovanni Ridolfi]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Emacs  : GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600)
 of 2010-05-08 on G41R2F1
Org-version: org-latest.zip;  6.36trans,    last commit:
        committer	Carsten Dominik <carsten.dominik@gmail.com>	
	Fri, 2 Jul 2010 07:20:15 +0000 (09:20 +0200)
        commit	f693238dfe6472b650ad59d0044f2c2a00c9f08d
        Fix naming and docstring issues in `org-iswitchb

Hello everybody,

I have a problem with the logging feature in (sub)tree
defined via :PROPERTIES:

I set up a file according to the manual
-------------------------------------
    -*- mode: org; -*-
* TODO Log each state with only a time
       :PROPERTIES:
       :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
       :END:
* TODO Only log when switching to WAIT, and when repeating
       :PROPERTIES:
       :LOGGING: WAIT(@) logrepeat
       :END:
* TODO No logging at all
       :PROPERTIES:
       :LOGGING: nil
       :END:
 ------------------------------
Then I restarted Emacs and opened such file.

If I C--> 1 time on the first heading I have the following 
result:
* DONE Log each state with only a time
  - State "DONE"       from "TODO"       [2010-07-02 ven 14:10]
       :PROPERTIES:
       :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
       :END:

Q: why I was not prompted for the WAIT & DONE & CANCELED todo-keywords?

If I C--> on the second heading I have this result:
* DONE Only log when switching to WAIT, and when repeating
       :PROPERTIES:
       :LOGGING: WAIT(@) logrepeat
       :END:
Q: why I was not prompted for the WAIT todo-keywords?

If I C--> on the 3rd heading I have this result:
* DONE No logging at all
  CLOSED: [2010-07-02 ven 14:11]
       :PROPERTIES:
       :LOGGING: nil
       :END:       

Q: why a timestamp is added ? shulden't the default be overidden by the 
   value in the :PROPERTY:?

Is this
+ a bug?
+ incomplete documentation? 
+ my mistake: I didn't set-up some variable?

cheers,
Giovanni

current state:
==============
(setq
 org-log-done 'time
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-agenda-files '()
 org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-remember-clock-out-on-exit nil
 org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-export-preprocess-hook '(org-export-blocks-preprocess)
 org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe)
 org-src-mode-hook '(org-src-mode-configure-edit-buffer)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
 org-mode-hook '((lambda nil
		  (org-add-hook (quote change-major-mode-hook) (quote org-show-block-all) (quote append)
		   (quote local))
		  )
		 (lambda nil
		  (org-add-hook (quote change-major-mode-hook) (quote org-babel-show-result-all)
		   (quote append) (quote local))
		  )
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe org-babel-hash-at-point
			  org-babel-execute-src-block-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org-babel-exp-inline-src-blocks))
 org-enforce-todo-dependencies t
 org-occur-hook '(org-first-headline-recenter)
 org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
 org-remember-templates '((  ))
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames
			       org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-export-blocks '((src org-babel-exp-src-blocks nil) (comment org-export-blocks-format-comment t)
		     (ditaa org-export-blocks-format-ditaa nil) (dot org-export-blocks-format-dot nil))
 )

Re: Bug: logging & PROPERTIES [6.36trans]

[Carsten Dominik]

Hi Giovanni,

On Jul 2, 2010, at 2:52 PM, Giovanni Ridolfi wrote:

>
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?   
> See
>
>     http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> Emacs  : GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600)
> of 2010-05-08 on G41R2F1
> Org-version: org-latest.zip;  6.36trans,    last commit:
>        committer	Carsten Dominik <carsten.dominik@gmail.com>	
> 	Fri, 2 Jul 2010 07:20:15 +0000 (09:20 +0200)
>        commit	f693238dfe6472b650ad59d0044f2c2a00c9f08d
>        Fix naming and docstring issues in `org-iswitchb
>
> Hello everybody,
>
> I have a problem with the logging feature in (sub)tree
> defined via :PROPERTIES:
>
> I set up a file according to the manual
> -------------------------------------
>    -*- mode: org; -*-
> * TODO Log each state with only a time
>       :PROPERTIES:
>       :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
>       :END:
> * TODO Only log when switching to WAIT, and when repeating
>       :PROPERTIES:
>       :LOGGING: WAIT(@) logrepeat
>       :END:
> * TODO No logging at all
>       :PROPERTIES:
>       :LOGGING: nil
>       :END:
> ------------------------------
> Then I restarted Emacs and opened such file.
>
> If I C--> 1 time on the first heading I have the following

What key is this supposed to be? Shift-right, maybe?
If yes, take a look at the variable

org-treat-S-cursor-todo-selection-as-state-change

The default is t, but maybe you have set it to nil?

> result:
> * DONE Log each state with only a time
>  - State "DONE"       from "TODO"       [2010-07-02 ven 14:10]
>       :PROPERTIES:
>       :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
>       :END:
>
> Q: why I was not prompted for the WAIT & DONE & CANCELED todo- 
> keywords?
>
> If I C--> on the second heading I have this result:
> * DONE Only log when switching to WAIT, and when repeating
>       :PROPERTIES:
>       :LOGGING: WAIT(@) logrepeat
>       :END:
> Q: why I was not prompted for the WAIT todo-keywords?
>
> If I C--> on the 3rd heading I have this result:
> * DONE No logging at all
>  CLOSED: [2010-07-02 ven 14:11]
>       :PROPERTIES:
>       :LOGGING: nil
>       :END:
>
> Q: why a timestamp is added ? shulden't the default be overidden by  
> the
>   value in the :PROPERTY:?

Yes, this was a bug, fixed now.

- Carsten

>
> Is this
> + a bug?
> + incomplete documentation?
> + my mistake: I didn't set-up some variable?
>
> cheers,
> Giovanni
>
> current state:
> ==============
> (setq
> org-log-done 'time
> org-export-latex-after-initial-vars-hook '(org-beamer-after-initial- 
> vars)
> org-agenda-files '()
> org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
> org-metaup-hook '(org-babel-load-in-session-maybe)
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-remember-clock-out-on-exit nil
> org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
> org-export-latex-format-toc-function 'org-export-latex-format-toc- 
> default
> org-export-preprocess-hook '(org-export-blocks-preprocess)
> org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide- 
> result-toggle-maybe)
> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
> org-confirm-shell-link-function 'yes-or-no-p
> org-export-first-hook '(org-beamer-initialize-open-trackers)
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide- 
> drawers org-cycle-show-empty-lines
> 		  org-optimize-window-after-visibility-change)
> org-export-preprocess-before-normalizing-links-hook '(org-remove- 
> file-link-modifiers)
> org-mode-hook '((lambda nil
> 		  (org-add-hook (quote change-major-mode-hook) (quote org-show- 
> block-all) (quote append)
> 		   (quote local))
> 		  )
> 		 (lambda nil
> 		  (org-add-hook (quote change-major-mode-hook) (quote org-babel- 
> show-result-all)
> 		   (quote append) (quote local))
> 		  )
> 		 org-babel-result-hide-spec org-babel-hide-all-hashes)
> org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe org-babel-hash- 
> at-point
> 			  org-babel-execute-src-block-maybe)
> org-confirm-elisp-link-function 'yes-or-no-p
> org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org- 
> babel-exp-inline-src-blocks))
> org-enforce-todo-dependencies t
> org-occur-hook '(org-first-headline-recenter)
> org-export-preprocess-before-selecting-backend-code-hook '(org- 
> beamer-select-beamer-code)
> org-remember-templates '((  ))
> org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix- 
> toc org-beamer-auto-fragile-frames
> 			       org-beamer-place-default-actions-for-lists)
> org-metadown-hook '(org-babel-pop-to-session-maybe)
> org-export-blocks '((src org-babel-exp-src-blocks nil) (comment org- 
> export-blocks-format-comment t)
> 		     (ditaa org-export-blocks-format-ditaa nil) (dot org-export- 
> blocks-format-dot nil))
> )
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

Re: Bug: logging & PROPERTIES [6.36trans]

[Giovanni Ridolfi]

Carsten Dominik <carsten.dominik@gmail.com> writes:
Hi, Carsten, 
>> a file according to the manual
>> -------------------------------------
>>    -*- mode: org; -*-
>> * TODO Log each state with only a time
>>       :PROPERTIES:
>>       :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
>>       :END:
>> ------------------------------
>> Then I restarted Emacs and opened such file.
>>
yes is S-right-cursor

> If yes, take a look at the variable
>
> org-treat-S-cursor-todo-selection-as-state-change
> The default is t, but maybe you have set it to nil?
The value is  "t": in the *Help* buffer I read:

"org-treat-S-cursor-todo-selection-as-state-change is a variable defined in `org.el'.
Its value is t"

I downloaded the latest org-version, last commit:
      commit	9e9bc164760f2c4b428ce06c48367ac4fb364204
      Capture: fix the function target

But, also in this version, the value of the TODO sequence 
in the :PROPERTY: drawer  (i.e.  TODO(!) WAIT(!) DONE(!) CANCELED(!)   )
is *not* considered,  when I change the todo state
and it is used only the default value: TODO, DONE.

If I change the "todo-keyword" and write "WAIT", 'WAIT' reamins in a plain
font and does not become red, it is not fontified.

Giovanni

P.S.
>> * TODO No logging at all
>>       :PROPERTIES:
>>       :LOGGING: nil

>> Q: why a timestamp is added ? shulden't the default be overidden by
>> the   value in the :PROPERTY:?
>
> Yes, this was a bug, fixed now.
Thanks, I saw it yesterday: 
"Repair the working of a LOGGING property value `nil'"

Re: Bug: logging & PROPERTIES [6.36trans]

[Carsten Dominik]

On Jul 5, 2010, at 12:52 PM, Giovanni Ridolfi wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi, Carsten,
>>> a file according to the manual
>>> -------------------------------------
>>>   -*- mode: org; -*-
>>> * TODO Log each state with only a time
>>>      :PROPERTIES:
>>>      :LOGGING: TODO(!) WAIT(!) DONE(!) CANCELED(!)
>>>      :END:
>>> ------------------------------
>>> Then I restarted Emacs and opened such file.
>>>
> yes is S-right-cursor
>
>> If yes, take a look at the variable
>>
>> org-treat-S-cursor-todo-selection-as-state-change
>> The default is t, but maybe you have set it to nil?
> The value is  "t": in the *Help* buffer I read:
>
> "org-treat-S-cursor-todo-selection-as-state-change is a variable  
> defined in `org.el'.
> Its value is t"
>
> I downloaded the latest org-version, last commit:
>      commit	9e9bc164760f2c4b428ce06c48367ac4fb364204
>      Capture: fix the function target
>
> But, also in this version, the value of the TODO sequence
> in the :PROPERTY: drawer  (i.e.  TODO(!) WAIT(!) DONE(!)  
> CANCELED(!)   )
> is *not* considered,  when I change the todo state
> and it is used only the default value: TODO, DONE.
>
> If I change the "todo-keyword" and write "WAIT", 'WAIT' reamins in a  
> plain
> font and does not become red, it is not fontified.


THis is probably because you have neither configured org-todo- 
keywords, nor have you put a

#+TODO: TODO WAIT | DONE CANCEL

line into the buffer.  You need to tell Org mode what the todo  
keywords are.

- Carsten

Re: Bug: logging & PROPERTIES [6.36trans]

[Giovanni Ridolfi]

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

Carsten Dominik <carsten.dominik@gmail.com> writes:

>> If I change the "todo-keyword" and write "WAIT", 'WAIT' reamins in a
>> plain font 
>
> THis is probably because you have neither configured org-todo-
> keywords, nor have you put a
>
> #+TODO: TODO WAIT | DONE CANCEL
>
> line into the buffer.  You need to tell Org mode what the todo
> keywords are.

I see. I found the documentation not so explicit.

Do you think the following patch will clarify the sentence?

cheers,
Giovanni

P.S. I sent a patch for the documentation, but Stephen Eglen sent a more
     complete patch, including also the typo I found.
Please reject or archive the patch
http://patchwork.newartisans.com/patch/106/


[-- Attachment #2: patch-for-logging --]
[-- Type: text/plain, Size: 476 bytes --]

--- org.texi	2010-07-05 17:22:17.923843200 +0200
+++ org-gio.texi	2010-07-05 17:38:24.764091200 +0200
@@ -3775,5 +3775,6 @@
 
 @cindex property, LOGGING
-In order to define logging settings that are local to a subtree or a
+Once the TODO keywords have been set, in order to define logging 
+settings that are local to a subtree or a
 single item, define a LOGGING property in this entry.  Any non-empty
 LOGGING property resets all logging settings to nil.  You may then turn

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug: logging & PROPERTIES [6.36trans]

[Carsten Dominik]

On Jul 5, 2010, at 5:49 PM, Giovanni Ridolfi wrote:

> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>>> If I change the "todo-keyword" and write "WAIT", 'WAIT' reamins in a
>>> plain font
>>
>> THis is probably because you have neither configured org-todo-
>> keywords, nor have you put a
>>
>> #+TODO: TODO WAIT | DONE CANCEL
>>
>> line into the buffer.  You need to tell Org mode what the todo
>> keywords are.
>
> I see. I found the documentation not so explicit.
>
> Do you think the following patch will clarify the sentence?

Hmmm, not really.   think it is kind of obvious from the docs that you
need to define TODO states before you can use them, and I think it must
be bad luck that you first were reading about LOGGING, before
defining your TODO keywords.

>
> cheers,
> Giovanni
>
> P.S. I sent a patch for the documentation, but Stephen Eglen sent a  
> more
>     complete patch, including also the typo I found.
> Please reject or archive the patch
> http://patchwork.newartisans.com/patch/106/

Done.

Thanks!

- Carsten

>
> --- org.texi	2010-07-05 17:22:17.923843200 +0200
> +++ org-gio.texi	2010-07-05 17:38:24.764091200 +0200
> @@ -3775,5 +3775,6 @@
>
> @cindex property, LOGGING
> -In order to define logging settings that are local to a subtree or a
> +Once the TODO keywords have been set, in order to define logging
> +settings that are local to a subtree or a
> single item, define a LOGGING property in this entry.  Any non-empty
> LOGGING property resets all logging settings to nil.  You may then  
> turn

- Carsten