emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <dominik@science.uva.nl>
To: Eddward DeVilla <eddward@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: link bug
Date: Tue, 7 Nov 2006 08:19:46 +0100	[thread overview]
Message-ID: <3199c869c75f4496038ba138bf3fcd71@science.uva.nl> (raw)
In-Reply-To: <b71b18520611060944m3c750229uecb9bcc595384593@mail.gmail.com>

There are two issues here:

The first is when you want to *store* a link to a file-less buffer,
using `C-c l'.
This should be an error, because links are for the future and if there
is no file, there is no point linking to it.  Org-mode is throwing
an error, but there is a bug if the file-less buffer is in org-mode.

The second problem is the one you describe.  I am fixing it in the way
you propose.

Both problems fixed for 4.54.  Thanks for the report.

- Carsten

On Nov 6, 2006, at 18:44, Eddward DeVilla wrote:

> Hi,
>
>    I'm not on the latest version yet and it will be a few day until I
> can get there.  However, I found a bug in 4.51 when trying to store a
> link using C-c C-l.  I believe that's org-insert-link.  In any case
> org-insert-link gets called in there somewhere and dies calling
> (file-truename buffer-file-name) to determine if the link is in the
> same file as the org buffer.  This is invalid when the buffer doesn't
> have a file behind it.   There needs to be a check to make sure
> buffer-file-name is not nil.  (Or org has to not allow file-less
> buffers).  The reason for the file-less buffer was that I've started
> creating small outlines with links when I want to throw together a
> quick code review.
>
> I'm not sure what the right answer is.  may you just skip the case if
> there is not file behind the buffer since links into file-less buffer
> would seem to be impossible.  On the other hand, You may want to allow
> links back to the same buffer just in case the user decides to save it
> to a file later.  For now, I'm going to hack mine by wrapping the "(if
> (equal ..." inside an "(if (buffer-file-name) ..."
>
> Edd
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

      reply	other threads:[~2006-11-07  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 17:44 link bug Eddward DeVilla
2006-11-07  7:19 ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3199c869c75f4496038ba138bf3fcd71@science.uva.nl \
    --to=dominik@science.uva.nl \
    --cc=eddward@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).