have =make cleanall= remove .texi files in doc/

have =make cleanall= remove .texi files in doc/

[Greg Minshall]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

hi.  neither =make clean= nor =make cleanall= remove the two .texi files
built (by, e.g., =make info=) in the doc subdirectory.  this patch
removes those files with =make cleanall=.  i wasn't sure which to use,
but it sort of looked like =cleanall= might be the place.

i also noticed that =make cleanall= invokes =find= on =./contrib=, which
no longer (i assume) exists so =find= complains (which is logged, but
then ignored, by =make=).  i'm happy to do a patch for that (though it
would be, presumably, as trivial as this one).

cheers, Greg


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cleanall .texi files --]
[-- Type: text/x-diff, Size: 855 bytes --]

From 0584aec533d556bed94f6e90affb3ff11faca3b0 Mon Sep 17 00:00:00 2001
From: Greg Minshall <minshall@umich.edu>
Date: Fri, 21 May 2021 18:42:35 +0300
Subject: [PATCH] doc/Makefile: `cleanall` target now deletes
 doc/{org,orgguide}.texi

* doc/Makefile: `cleanall` target now deletes doc/{org,orgguide}.texi

In the past, at least one of these seems to have been a tracked
(source?) file.  That is no longer the case.
---
 doc/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/Makefile b/doc/Makefile
index da5a07ad9..d934258f3 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -58,6 +58,7 @@ clean:
 	      org-version.tex *.aux *.cp *.cps *.dvi *.fn *.fns *.ky *.kys \
               *.pg *.pgs *.toc *.tp *.tps *.vr *.vrs *.log *.html *.ps
 cleanall:	clean
+	$(RM) org.texi orgguide.texi
 	$(RMR) guide manual
 
 clean-install:
-- 
2.31.1

Re: have =make cleanall= remove .texi files in doc/

[Nicolas Goaziou]

Hello,

Greg Minshall <minshall@umich.edu> writes:

> hi.  neither =make clean= nor =make cleanall= remove the two .texi files
> built (by, e.g., =make info=) in the doc subdirectory.  this patch
> removes those files with =make cleanall=.  i wasn't sure which to use,
> but it sort of looked like =cleanall= might be the place.

Applied. Thank you.

> i also noticed that =make cleanall= invokes =find= on =./contrib=, which
> no longer (i assume) exists so =find= complains (which is logged, but
> then ignored, by =make=).  i'm happy to do a patch for that (though it
> would be, presumably, as trivial as this one).

Sure. Please go ahead.

Regards,
-- 
Nicolas Goaziou