From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mCH7BM02sWQaygAASxT56A (envelope-from ) for ; Fri, 14 Jul 2023 13:51:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uKHJBM02sWR4jAAA9RJhRA (envelope-from ) for ; Fri, 14 Jul 2023 13:51:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B68675995C for ; Fri, 14 Jul 2023 13:51:40 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="hgB3W/8+"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689335500; a=rsa-sha256; cv=none; b=IuUzmSX4BvIOp3Da+Ipx0lv0i395u7z2II8h2sqbxQkminn/fIaIVXZv4GV/Rij0whE5o9 gZ/Z7znb1ljdnPo4KOqfM5ijr7pR8ne4WPnbNMAegM8mLgQ8P99lVE4xvQtPpFnZ3cuFqf 2XwzmbiZHnnSAytB5kRhIkfrkoQ2oPWUorJ9FAQmmwMua8rYn6roJIg7ikp7rbFwhNbw4y Tp5wFc6jtmxLQz3z+fhW8f++tlePBhAHCtCExwrFv2c46jqaWe3+Vw3Og+F8zI6QpPWQbL NEMZEsxaDO8st/K1uMTQqhlOf57ALGUW4vRFMz+PPO+HzrNcd7Zm3+3A0eKb5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="hgB3W/8+"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689335500; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PdFIDHaFDXUHt+ImpS7t0nYOhRogBJ9ABFnXcGhxm1s=; b=oNqfms47cfF1Z6ah1BJlU0DkXohiiLnP2iN06YoodjJQjItkNuMmWUe6Q5QXOpsqeo4Bk/ 62B6golokdNImdo9DpT3kIbNpGkJmCpvCArybKzNRMIXV1wBiGuCR67mnBH7peXzgL55F4 A1aw8gJ9u6+5kXRy9bpQQWCP36ynqlOwXRFCxTB+JLqucFQv4X/8LoSCGAWW6xYiKIjEWN Qz7hvglI0cP65Mt4Z5nEyFFeLFBOA6/w5sz+yuD+3yxZe7ORPt8f3NOG13WEPYKZvGI2QE n+R2rzDOgARm8DRbSSFsFSReJLiDzWSob+4RlAY5OYIs+RHheHntbysMYQQ7Ow== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKHJv-0007vN-2H; Fri, 14 Jul 2023 07:50:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKHJs-0007vD-W8 for emacs-orgmode@gnu.org; Fri, 14 Jul 2023 07:50:45 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKHJr-0002Mt-Ff for emacs-orgmode@gnu.org; Fri, 14 Jul 2023 07:50:44 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4fb73ba3b5dso3133930e87.1 for ; Fri, 14 Jul 2023 04:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689335441; x=1691927441; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=PdFIDHaFDXUHt+ImpS7t0nYOhRogBJ9ABFnXcGhxm1s=; b=hgB3W/8+lanz3zcOHaihYp+lriqEnIQs1J4AqYP1vx0el6ImoIsiu9AevUMp+hUE6n t6hCu9R4l6yYNiCYlrGDFUNo+igvVzKwWNRdedRYyvr+ZbM6McD6+v7Eoi3sobCpASIy qn/yJZuPCDldNB5YQ2R8xRIi7FfMz+nZvvoppUQ+dArZdLa2tPB0dDFZlx2Bbmv97TPW nlZ3GvjQ9D1soD3KZa0zVl1WvBgxdXxI8jSt3egvGcvt/znlpo6oiVk0d1/2v6/fm5Fl hMnLuUZnPuD426CkulLPx8QMiYn3uiLhQ6TE2LeRSSYiInv40NGjvx33BhyxKljpdfpm SOLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689335441; x=1691927441; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PdFIDHaFDXUHt+ImpS7t0nYOhRogBJ9ABFnXcGhxm1s=; b=j6S8hcWNCibcg4P+hZYLPCZB73VNX7meN5mIxklUB92/5RXufud0Q1RXo4FRrsS7fG MAhRj6zX6pYBkOhZc8PmMATxJapabi2bL3PE6aBfRgAruSFtAiRWzq3O4VF7lgiUYoai WGfUAsJpXfzrg+OPmW0LnMVZKqpv8Or2hw+jmFNK/A89dDBsYbAWJNCquckeSvAgblRw S/nsh71nMtVP3BYrLFM04zYNuSHtvcrHJ8lEsd+lPyl53HfQTP+3xX18aawq/PBehFud Td8yvuHW1LP6j11oRwIaLVz2h6AGRyFk54yhTkf5bNwzbamvCzHgnbkDigrS3wMdr3W/ BUBg== X-Gm-Message-State: ABy/qLaVFaRPB38bFxtLoyErLOIeQKSx6WVGEjaIvhR1Pa6ddJZwmb2H Vn3CYqMLQJCxzw4JPjgmzAU= X-Google-Smtp-Source: APBJJlGhYrxpA3RwPr4hJ46X/AV1svw1SU4QTUB6ddXviIoQG1c1dyx0LujcNeWbYZPpq/HM+U0D0g== X-Received: by 2002:a05:6512:2813:b0:4fc:4f3e:9cbf with SMTP id cf19-20020a056512281300b004fc4f3e9cbfmr4531886lfb.50.1689335441223; Fri, 14 Jul 2023 04:50:41 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id p11-20020ac246cb000000b004fb957ac245sm1472567lfo.59.2023.07.14.04.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 04:50:40 -0700 (PDT) Message-ID: <2e5004db-1c3c-1b5c-e665-1b538aad745c@gmail.com> Date: Fri, 14 Jul 2023 18:50:39 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] testing: Delete duplicate tests Content-Language: en-US To: Ilya Chernyshov , emacs-orgmode References: <87cz0xndem.fsf@gmail.com> From: Max Nikulin Mail-Followup-To: Ilya Chernyshov , emacs-orgmode In-Reply-To: <87cz0xndem.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=manikulin@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: B68675995C X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 2.87 X-Spam-Score: 2.87 X-TUID: xGDLPdLHwNLW On 13/07/2023 02:22, Ilya Chernyshov wrote: > +++ b/testing/lisp/test-ol.el > @@ -301,14 +301,6 @@ Seehttps://github.com/yantar92/org/issues/4." > (let ((file (buffer-file-name))) > (equal (format "[[file:%s::two]]" file file) > (org-store-link nil)))))) > - (should > - (let ((org-stored-links nil) > - (org-context-in-file-links t)) > - (org-test-with-temp-text-in-file "# two" > - (fundamental-mode) > - (let ((file (buffer-file-name))) > - (equal (format "[[file:%s::two]]" file file) > - (org-store-link nil)))))) The test was added by 7a78eb1be 2020-03-26 22:57:16 +0100 Nicolas Goaziou: ol: Fix some corner cases when normalizing context in links The intention may be to test "#two" besides "# two". Maybe somebody has a better guess what case related to the change is not covered. The idea to find duplicated tests is bright. The code may be transformed in a dedicated unit test. I would not drop existing tests blindly though.