From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: [OT] Icon problem with org-google-weather Date: Mon, 06 Jun 2011 09:51:19 -0400 Message-ID: <29857.1307368279@alphaville.dokosmarshall.org> References: <24071.1307320041@alphaville.dokosmarshall.org> <871uz7v287.fsf@member.fsf.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([140.186.70.92]:38462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTaDh-0002fB-JQ for emacs-orgmode@gnu.org; Mon, 06 Jun 2011 09:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTaDd-0003DB-0H for emacs-orgmode@gnu.org; Mon, 06 Jun 2011 09:51:53 -0400 Received: from vms173003pub.verizon.net ([206.46.173.3]:48244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTaDc-0003D5-Pp for emacs-orgmode@gnu.org; Mon, 06 Jun 2011 09:51:48 -0400 Received: from alphaville.dokosmarshall.org ([unknown] [173.76.32.106]) by vms173003.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LMD00L17FTJJF10@vms173003.mailsrvcs.net> for emacs-orgmode@gnu.org; Mon, 06 Jun 2011 08:51:32 -0500 (CDT) In-reply-to: Message from Tassilo Horn of "Mon, 06 Jun 2011 09:38:32 +0200." <871uz7v287.fsf@member.fsf.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Tassilo Horn Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org Tassilo Horn wrote: > > Nevertheless, when I insert foo, the icon is shown, but when I insert > > bar, the icon is an empty box. What am I missing? > > I have a similar problem. In one of my org files, I have > > %%(org-google-weather "Montabaur" "de") > > and since lately, I get only squares. > > That said, while trying your example, `org-google-weather' always > returned nil. The reason is that I don't have > `org-google-weather-location' set explicitly to something different as > the default value. But that default is a form and it is never evaluated > AFAICS. So that seems to be another bug. > > Ok, so when I change your testcase to this... > > --8<---------------cut here---------------start------------->8--- > (defun foobar () > (interactive) > (let ((date '(6 6 2011))) > (setq bar (org-google-weather "Montabaur" "DE")) > (setq foo (let ((org-google-weather-cache-time 0)) > (org-google-weather "Montabaur" "DE"))) > (string= foo bar) > (insert foo) > (insert bar))) > --8<---------------cut here---------------end--------------->8--- > > I get an error at the foo value evaluation. The evaluation of bar seems > to work fine... > > --8<---------------cut here---------------start------------->8--- > Debugger entered--Lisp error: (error "Data not found") Yes, the "Data not found" problem is an org-google-weather problem, I sent Julien the following patch - either apply it by hand or check Julien's git repo: it may be there already. --8<---------------cut here---------------start------------->8--- diff --git a/org-google-weather.el b/org-google-weather.el index 3ff0aa3..02db878 100644 --- a/org-google-weather.el +++ b/org-google-weather.el @@ -70,6 +70,7 @@ Valid %-sequences are: (defun org-google-weather-get-icon (url) (with-current-buffer (google-weather-retrieve-data-raw url org-google-weather-cache-time) + (goto-char (point-min)) (unless (search-forward "\n\n" nil t) (error "Data not found")) (let ((data (buffer-substring (point) (point-max)))) --8<---------------cut here---------------end--------------->8--- Nick