From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: [patch][test] Avoid writes to non-temp test-example files Date: Thu, 05 Jan 2012 10:31:52 -0500 Message-ID: <28385.1325777512@alphaville.dokosmarshall.org> References: <7798.1325701750@alphaville.americas.hpqcorp.net> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([140.186.70.92]:39702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RipIN-00053N-M7 for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 10:32:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RipIJ-0000HW-Gb for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 10:31:59 -0500 Received: from g1t0029.austin.hp.com ([15.216.28.36]:8914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RipIJ-0000HD-5n for emacs-orgmode@gnu.org; Thu, 05 Jan 2012 10:31:55 -0500 In-Reply-To: Message from Martyn Jago of "Thu, 05 Jan 2012 10:35:37 GMT." List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org Martyn Jago wrote: > Nick Dokos writes: > > > Martyn Jago wrote: > > > >> > >> Attached is a patch to modify all tests that currently write to non-temp > >> test-example files such as `testing/babel.org'. Instead, the tests now > >> write to temp files, which are thrown away at the conclusion of the > >> test. > >> > > > > Are the temp files kept if the test fails? IME, that's a useful debugging aid. > > > > Nick > > > >> All tests still pass. > >> > >> HTH > >> > >> Best, Martyn > >> > > If a test fails (or breaks in some way) and the temp-file has been > created, it remains in the `temporary-file-directory' (the test system > uses the standard Emacs make-temp-file mechanism). The file is > referenced in the ert failure backtrace, and may be viewed in Emacs (press `b' on > the failure in ert), although there is usually enough information in the > backtrace / test-case to point to the failure. > > Emacs takes care of removing the old tmp files over time. > Great - thanks! Nick