From: Nick Dokos <nicholas.dokos@hp.com>
To: Martyn Jago <martyn.jago@btinternet.com>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: [patch][test] Avoid writes to non-temp test-example files
Date: Thu, 05 Jan 2012 10:31:52 -0500 [thread overview]
Message-ID: <28385.1325777512@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Martyn Jago <martyn.jago@btinternet.com> of "Thu, 05 Jan 2012 10:35:37 GMT." <m24nwal9mu.fsf@btinternet.com>
Martyn Jago <martyn.jago@btinternet.com> wrote:
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
> > Martyn Jago <martyn.jago@btinternet.com> wrote:
> >
> >>
> >> Attached is a patch to modify all tests that currently write to non-temp
> >> test-example files such as `testing/babel.org'. Instead, the tests now
> >> write to temp files, which are thrown away at the conclusion of the
> >> test.
> >>
> >
> > Are the temp files kept if the test fails? IME, that's a useful debugging aid.
> >
> > Nick
> >
> >> All tests still pass.
> >>
> >> HTH
> >>
> >> Best, Martyn
> >>
>
> If a test fails (or breaks in some way) and the temp-file has been
> created, it remains in the `temporary-file-directory' (the test system
> uses the standard Emacs make-temp-file mechanism). The file is
> referenced in the ert failure backtrace, and may be viewed in Emacs (press `b' on
> the failure in ert), although there is usually enough information in the
> backtrace / test-case to point to the failure.
>
> Emacs takes care of removing the old tmp files over time.
>
Great - thanks!
Nick
next prev parent reply other threads:[~2012-01-05 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 17:50 [patch][test] Avoid writes to non-temp test-example files Martyn Jago
2012-01-04 18:29 ` Nick Dokos
2012-01-05 10:35 ` Martyn Jago
2012-01-05 15:31 ` Nick Dokos [this message]
2012-01-04 19:02 ` Bastien
2012-01-05 17:01 ` Achim Gratz
2012-01-05 18:31 ` Martyn Jago
2012-01-05 19:01 ` Achim Gratz
2012-01-06 16:51 ` Achim Gratz
2012-01-06 17:24 ` Martyn Jago
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28385.1325777512@alphaville.dokosmarshall.org \
--to=nicholas.dokos@hp.com \
--cc=emacs-orgmode@gnu.org \
--cc=martyn.jago@btinternet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).