emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jason May <jmay@pobox.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org mode version 9.7-pre (9.7-pre-n/a-g093879
Date: Wed, 07 Feb 2024 20:00:27 -0800	[thread overview]
Message-ID: <27899b3fba30cc984e2d8fa4701d26066471f8b9@hey.com> (raw)
In-Reply-To: <87cyt8qk0h.fsf@localhost>

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

I think you're right.

This request was prompted by an issue encounted in org-journal, and it
probably exists in org-roam and other similar packages.

Ignoring blank lines sounds like a reasonable approach.

For more significant syntax violations such as your example, perhaps
org-entry-get and other functions should raise errors instead of
silently returning nil?

I'm going to investigate how it might be possible to initiate an org-
lint if an exception situation was to arise in org-journal.




On February 7, 2024, Ihor Radchenko <yantar92@posteo.net> wrote:
> Jason May <jmay@pobox.com> writes:
>
> > Extraneous content (e.g. blank lines) in the PROPERTIES drawer
> > cause =org-entry-get= to return nil without indication of any
> problem.
> >
> > Desired behavior: =org-entry-get= should be forgiving.
> > It should ignore blank PROPERTIES lines, or any line with invalid
> > syntax.
> > A message to the *Warnings* buffer might be appropriate.
>
> Blank lines in properties might be an ok change.
> I am not so sure about invalid syntax.
>
> Consider
>
> :PROPERTIES:
> :PROP1: val1
> :PROP2: this line was
> accidentally modified
> :END:
>
> Property drawer not being recognized is more likely to be noticed
> compared to `org-entry-get' returning incomplete "this line was".
>
> In any case, M-x org-lint will report problems with property drawers.
>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

[-- Attachment #2: Type: text/html, Size: 4431 bytes --]

  reply	other threads:[~2024-02-08  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05  1:42 Org mode version 9.7-pre (9.7-pre-n/a-g093879 Jason May
2024-02-07 17:09 ` Ihor Radchenko
2024-02-08  4:00   ` Jason May [this message]
2024-02-08 15:31     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27899b3fba30cc984e2d8fa4701d26066471f8b9@hey.com \
    --to=jmay@pobox.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).