From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: Carsten Dominik <carsten@orgmode.org>, emacs-orgmode@gnu.org
Subject: Re: Agenda clock reporting
Date: Sun, 3 Jan 2010 15:41:01 +0100 [thread overview]
Message-ID: <2728B4EE-06FA-409C-9065-01F388554411@gmail.com> (raw)
In-Reply-To: <87eim7i7zd.fsf@gollum.intra.norang.ca>
On Jan 3, 2010, at 3:22 PM, Bernt Hansen wrote:
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Dec 22, 2009, at 2:03 PM, Bernt Hansen wrote:
>>
>>> Hi Carsten,
>>>
>>> I use the agenda clock report during the end of my day. Would it be
>>> difficult to have it include the currently clocking task if a
>>> clock is
>>> active?
>>>
>>> I clock billable and nonbillable tasks during the day. If I want to
>>> stop working at 8 billable hours I currently run the clock report
>>> and
>>> then find the current active clock entry (last one on the page with
>>> l'
>>> in the agenda) and manually add the time accumulated to the clock
>>> report
>>> to see when I'm done for the day. This is a bit tedious and error
>>> prone.
>>>
>>> I'm thinking that since agenda clock reports are not permanent it
>>> wouldn't hurt to include the current clocking item in the agenda
>>> report if that is easy to do. I've been digging around in the clock
>>> report code in my limited spare time but haven't yet made any useful
>>> progress on this task.
>>>
>>> Any pointers on where to make this modification would be
>>> appreciated.
>>
>> Hi Bernt,
>>
>> I think the right place would be `org-clock-sum'. Right now,
>> this looks only for complete clock lines. You could modify the
>> regexp
>> to check for incomplete lines (first time stamp only) and then check
>> if the org-clock-marker points to the current line. If yes, you
>> could
>> use the current time as the end time and proceed.
>>
>> Send me a patch if you get this to work, with a customization
>> variable
>> to turn this off.
>>
>> HTH
>
> Yes it does thanks. I found the logic that uses the regexp for
> parsing
> the times and summing them in reverse up to the headline in
> org-clock-sum. I haven't modified the regexp yet but was planning
> something similar to what you describe above.
>
> - org-clock-sum
> - Runs through headings in reverse order
> - counts clock entries bottom up to headline
> - adds a text property to the headline with total time
> - need to find out if current heading is clocking
Yes, the alternative approach would be to *not* modify the regexp, but
to
check if org-clock-hd-marker points to the current headline and then
add the time since the clock started (in `org-clock-start-time') to
the appropriate
field in the ltimes vector before extracting the total time. So you
would do
this as the first thing when you find a headline, and the proceed
normally.
Sounds simpler than modifying the regexp and would not cause any
problems
with other incomplete clock entries that may have been left behind and
never
properly resolved......
- Carsten
> - add entry for open clock time with closing time to get correct
> total
> - regexp needs to match open clock entries
> - for open clock entry matches set time to zero
> - reset time if this is the current clocking entry
>
> I'll post the patch whenever it gets done.
>
> Thanks!
> Bernt
- Carsten
next prev parent reply other threads:[~2010-01-03 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 13:03 Agenda clock reporting Bernt Hansen
2009-12-22 15:16 ` Clock logging -- possible to include seconds? Bill Powell
2009-12-22 17:11 ` Scot Becker
2009-12-26 11:14 ` Carsten Dominik
2009-12-26 12:40 ` Bernt Hansen
2010-01-03 13:24 ` Agenda clock reporting Carsten Dominik
2010-01-03 14:22 ` Bernt Hansen
2010-01-03 14:41 ` Carsten Dominik [this message]
2010-01-03 15:38 ` Bernt Hansen
2010-01-03 15:44 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2728B4EE-06FA-409C-9065-01F388554411@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=carsten@orgmode.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).