From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gKM9NZ+OjmBqxAAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 13:35:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OOvOMJ+OjmCRWwAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 11:35:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A6AC2367E for ; Sun, 2 May 2021 13:35:59 +0200 (CEST) Received: from localhost ([::1]:39436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldAOE-0005XV-DE for larch@yhetil.org; Sun, 02 May 2021 07:35:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldANO-0005W5-JT for emacs-orgmode@gnu.org; Sun, 02 May 2021 07:35:06 -0400 Received: from ciao.gmane.io ([116.202.254.214]:40560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldANM-0004x9-Re for emacs-orgmode@gnu.org; Sun, 02 May 2021 07:35:06 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ldANI-0009iY-Mf for emacs-orgmode@gnu.org; Sun, 02 May 2021 13:35:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Maxim Nikulin Subject: Re: [PATCH] org-protocol: Fix missing '+' in js snippet Date: Sun, 2 May 2021 18:34:54 +0700 Message-ID: <25d5f9ca-e59c-184b-b941-3a2dcaa8af23@gmail.com> References: <20210419105316.10227-1-vid@bina.me> <41e021be-e973-652b-fd04-b1b4524b959b@gmail.com> <87a6pj9dbc.fsf@gnu.org> <39e9dd49-8c13-e3d0-b7d3-ce75706fc5ec@gmail.com> <87v984b5kx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87v984b5kx.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619955359; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jk9Gre81X0OC+51bhnCjj4RTzukamWVfltjyBTWOWBI=; b=TDgaI9sISErl1RoOXVc/kBFWaEyuscyvsPuS5MD4mGxWH03Ltt27c8nTpTHCXVKgjEvMJc 7zqVp50VBCpD7EjfOxuGwMmpWB4giUsREkfx3snelANlczqChtxs9ZgSLv8oT1hGDtpjBf gd7argTYUvAJ/WeKeZjo7Tds8qYqAVdRcmve0BJHYOMyszeQj7prJhq+cqTgDJjBVOd+km O10b7iU+eHs6mjM3fLdtxn0C3rM3A7BNdGuuMmdJtpqwCMu9zU7woz5ef6evcXcfxUGG0k 0J3roiBJCVdMve5bjthF39Cg+vSL7kyaotOd+OemrCuX8lex2zVQ7Zc1oNZ/Xg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619955359; a=rsa-sha256; cv=none; b=QICqY1mfgLxjPPULBE10pi7cxCpAorGSJfNWVGUkDEYQACjHUJufchLaNNUlgDt4hsow3E dcr/NqgkkX/ERZE5SJzxHeKb7vslEHtGSnFQjiU3x7mV+n7IdZcmOiJvIO6TSmsAz8p/8K PPL820Iaypbj54IUe8jx+YX5V+62GAx5moXrz5eXYsDoYY5i1rxzw2CMHQrYfWGbruDt+x A5auJNlh30QUF+ntGtU3kYbDjYtMz01YrpD1Jl1yyyDtj9b0D3WISZlIf4NBbjfsWexla0 cjBBbhp/UkZTwcO1W31eDkeD9MYqDHGNi+qsLtTmSAakw68IjBvOttSVRrQdXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -0.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 5A6AC2367E X-Spam-Score: -0.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZZqbDosytkAG On 30/04/2021 14:21, Bastien wrote: > Maxim Nikulin writes: >> On 28/04/2021 12:40, Bastien wrote: >>> >>> Would you like to volunteer as the maintainer for org-protocol.el? >>> For now org-protocol.el indicates that Sebastian Rose, the original >>> author, is the maintainer, but I don't think he would mind handing it >>> to someone else. Let me rise an issue related to org protocol that I consider important enough. Test are not executed by default, so there is a chance that breaking changes will be committed untested. There are two options: 1. Add org-protocol to the list of loaded packaged. The drawback is that test run will not detect unintentional dependency of org core on org-protocol. 2. Add a separate command to Makefile that tests exclusively org-protocol and update testing/README with reminder concerning org-protocol. I believe that variant 2 is better, but opinion of core maintainers and their workflow is certainly more important. > ... >> Example of my ignorance: I suspect, I did not recognize that >> apostrophe needs special escaping in doc strings >> https://orgmode.org/list/s4hsag$ogg$1@ciao.gmane.io/ By the way, the patch (I have updated it in meanwhile) is not tracked on https://updates.orgmode.org/. I could not figure out what was the difference from e.g. https://orgmode.org/list/s6c1cm$174s$1@ciao.gmane.io/ Should I file an issue at github? >> Actually, I do not think, org-protocol requires a dedicated >> maintainer. There are a few things that may be improved, but they >> should be discussed at first. It seems, all current user already >> managed to configure their handlers and prefer to not experiment any >> more. So there is a little interest in this area. > > I don't use org-protocol.el myself and I'd rather have someone using > it being able to reproduce bugs and help maintainers fix problems. It is funny, but I am not an active org-protocol user as well. I tried it, then I decided to create a browser extension that extracts some metadata in addition to page title. Since I am not satisfied with capture quality yet, I have to inspect page structure often enough. That is why there is no point to minimize interaction (primary goal of org-protocol) and I usually copy result and call org-paste-subtree. Though I test from time to time that org-protocol is not broken in my extension. The goal of my patches to org-protocol is to avoid some surprises I have faced. Since I use linux, I can not reproduce windows or mac problems. Extrapolation of linux issues is not always applicable. There were ~10 threads related to org protocol issues over 1.5 years I have in local cache, so it is not a hot topic that deserves a maintainer. Do not worry.