emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Richard KLINDA <rklinda@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock-select-task bugfix (XEmacs incompatibility)
Date: Wed, 2 Dec 2009 06:41:32 +0100	[thread overview]
Message-ID: <252E914A-E305-4841-B39E-470700D355F6@gmail.com> (raw)
In-Reply-To: <87y6lmwj8o.fsf@gmail.com>

Hi Richard,

I don't see why this would be necessary?  Under what circumstances  
does this fail?

- Carsten

On Dec 1, 2009, at 9:07 PM, Richard KLINDA wrote:

> See attached simple patch.
>
> From 795d529d622f509f47c2bf17a0139fbe1659cc5f Mon Sep 17 00:00:00 2001
> From: Richard Klinda <rklinda@gmail.com>
> Date: Tue, 1 Dec 2009 21:03:39 +0100
> Subject: [PATCH] org-clock: org-clock-select-task bugfix (XEmacs)
>
> ---
> lisp/org-clock.el |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 56dbab5..87017fc 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -344,6 +344,10 @@ of a different task.")
>       (org-fit-window-to-buffer)
>       (message (or prompt "Select task for clocking:"))
>       (setq rpl (read-char-exclusive))
> +      (when (featurep 'xemacs)
> +        ;; in XEmacs read-char-exclusive returns character, instead  
> of
> +        ;; ascii value
> +        (setq rpl (char-octet rpl)))
>       (cond
>        ((eq rpl ?q) nil)
>        ((eq rpl ?x) nil)
> -- 
> 1.6.2.1
>
>
> -- 
> Richard
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

  reply	other threads:[~2009-12-02  5:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 20:07 [PATCH] org-clock-select-task bugfix (XEmacs incompatibility) Richard KLINDA
2009-12-02  5:41 ` Carsten Dominik [this message]
2009-12-02 12:32   ` Richard KLINDA
2009-12-03 11:47     ` Carsten Dominik
2009-12-03 12:41       ` Richard KLINDA
2009-12-03 13:54         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252E914A-E305-4841-B39E-470700D355F6@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=rklinda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).