Bug fix: org-mhe links don't work with mairix

Bug fix: org-mhe links don't work with mairix

[Nick Dokos]

Hi Carsten,

Pete Phillips had run into a problem back in November 2007 with mhe
links to emails not working (he was using mairix as the mh search
method). I just sent a patch to Bill Wohler about the mh-e part (and
copied both the mh-e list and the org list: the problem is described in
more detail there). Here is the org-mode patch.

I've tested the patch both with the default "pick" search in mh-e and
with "mairix" search. Pete Phillips also did some testing (I believe
with mairix) - thanks Pete!

I would feel better if there had been some swish++/namazu/etc testing as
well, but it's unlikely that I'll find the time in the foreseeable
future. In particular, I'm not sure where the angle brackets are needed:
it's clear they are needed for the pick search and I've found out that
they are *not* needed for mairix search, but if swish++ needs them, that
would complicate things. The patch assumes that they are not needed for
any search method, other than pick. If somebody on the list could try it
and report success/failure, I, for one, would appreciate it very much.

If it looks OK to you, could you please apply it?

Thanks very much,
Nick

--- a/lisp/org-mhe.el
+++ b/lisp/org-mhe.el
@@ -194,16 +194,16 @@ folders."
   (mh-find-path)
   (if (not article)
       (mh-visit-folder (mh-normalize-folder-name folder))
-    (setq article (org-add-angle-brackets article))
     (mh-search-choose)
     (if (equal mh-searcher 'pick)
         (progn
+          (setq article (org-add-angle-brackets article))
           (mh-search folder (list "--message-id" article))
           (when (and org-mhe-search-all-folders
                      (not (org-mhe-get-message-real-folder)))
             (kill-this-buffer)
             (mh-search "+" (list "--message-id" article))))
-      (mh-search "+" article))
+      (mh-search "+" (funcall mh-search-regexp-builder (list (cons 'message-id article)))))
     (if (org-mhe-get-message-real-folder)
         (mh-show-msg 1)
       (kill-this-buffer)

Re: Bug fix: org-mhe links don't work with mairix

[Carsten Dominik]

I have applied the patch, thank you.

- Carsten

On May 15, 2008, at 5:31 AM, Nick Dokos wrote:

> Hi Carsten,
>
> Pete Phillips had run into a problem back in November 2007 with mhe
> links to emails not working (he was using mairix as the mh search
> method). I just sent a patch to Bill Wohler about the mh-e part (and
> copied both the mh-e list and the org list: the problem is described  
> in
> more detail there). Here is the org-mode patch.
>
> I've tested the patch both with the default "pick" search in mh-e and
> with "mairix" search. Pete Phillips also did some testing (I believe
> with mairix) - thanks Pete!
>
> I would feel better if there had been some swish++/namazu/etc  
> testing as
> well, but it's unlikely that I'll find the time in the foreseeable
> future. In particular, I'm not sure where the angle brackets are  
> needed:
> it's clear they are needed for the pick search and I've found out that
> they are *not* needed for mairix search, but if swish++ needs them,  
> that
> would complicate things. The patch assumes that they are not needed  
> for
> any search method, other than pick. If somebody on the list could  
> try it
> and report success/failure, I, for one, would appreciate it very much.
>
> If it looks OK to you, could you please apply it?
>
> Thanks very much,
> Nick
>
> --- a/lisp/org-mhe.el
> +++ b/lisp/org-mhe.el
> @@ -194,16 +194,16 @@ folders."
>   (mh-find-path)
>   (if (not article)
>       (mh-visit-folder (mh-normalize-folder-name folder))
> -    (setq article (org-add-angle-brackets article))
>     (mh-search-choose)
>     (if (equal mh-searcher 'pick)
>         (progn
> +          (setq article (org-add-angle-brackets article))
>           (mh-search folder (list "--message-id" article))
>           (when (and org-mhe-search-all-folders
>                      (not (org-mhe-get-message-real-folder)))
>             (kill-this-buffer)
>             (mh-search "+" (list "--message-id" article))))
> -      (mh-search "+" article))
> +      (mh-search "+" (funcall mh-search-regexp-builder (list (cons  
> 'message-id article)))))
>     (if (org-mhe-get-message-real-folder)
>         (mh-show-msg 1)
>       (kill-this-buffer)
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Bug fix: org-mhe links don't work with mairix

[Thomas Baumann]

Hi Nick,

your patch actually breaks namazu, swish and grep searches. 

A look at mh-search-choices (mh-search.el) reveals that for namazu,
swish and grep mh-search-regexp-builder is nil and therefore 

(funcall mh-search-regexp-builder ...

raises an error. One might be tempted to solve this on the mh-e side but
there's no reason to add a mh-search-regexp-builder for those search
engines. There's a patch against todays git below.

BTW. Namazu and pick searches work fine without angular brackets, however, it
doesn't harm to have them.


Greetings
Thomas


--- /data/cvs/org-mode/lisp/org-mhe.el	2008-05-17 12:54:07.000000000 +0200
+++ org-mhe.el	2008-05-17 16:55:22.000000000 +0200
@@ -204,8 +204,10 @@
                      (not (org-mhe-get-message-real-folder)))
             (kill-this-buffer)
             (mh-search "+" (list "--message-id" article))))
-      (mh-search "+" (funcall mh-search-regexp-builder
-			      (list (cons 'message-id article)))))
+      (if mh-search-regexp-builder
+          (mh-search "+" (funcall mh-search-regexp-builder
+			      (list (cons 'message-id article))))
+        (mh-search "+" article)))
     (if (org-mhe-get-message-real-folder)
         (mh-show-msg 1)
       (kill-this-buffer)


Nick Dokos <nicholas.dokos@hp.com> writes:

> Pete Phillips had run into a problem back in November 2007 with mhe
> links to emails not working (he was using mairix as the mh search
> method). I just sent a patch to Bill Wohler about the mh-e part (and
> copied both the mh-e list and the org list: the problem is described in
> more detail there). Here is the org-mode patch.
>
> I've tested the patch both with the default "pick" search in mh-e and
> with "mairix" search. Pete Phillips also did some testing (I believe
> with mairix) - thanks Pete!
>
> I would feel better if there had been some swish++/namazu/etc testing as
> well, but it's unlikely that I'll find the time in the foreseeable
> future. In particular, I'm not sure where the angle brackets are needed:
> it's clear they are needed for the pick search and I've found out that
> they are *not* needed for mairix search, but if swish++ needs them, that
> would complicate things. The patch assumes that they are not needed for
> any search method, other than pick. If somebody on the list could try it
> and report success/failure, I, for one, would appreciate it very much.
>
> If it looks OK to you, could you please apply it?
>
> Thanks very much,
> Nick
>
> --- a/lisp/org-mhe.el
> +++ b/lisp/org-mhe.el
> @@ -194,16 +194,16 @@ folders."
>    (mh-find-path)
>    (if (not article)
>        (mh-visit-folder (mh-normalize-folder-name folder))
> -    (setq article (org-add-angle-brackets article))
>      (mh-search-choose)
>      (if (equal mh-searcher 'pick)
>          (progn
> +          (setq article (org-add-angle-brackets article))
>            (mh-search folder (list "--message-id" article))
>            (when (and org-mhe-search-all-folders
>                       (not (org-mhe-get-message-real-folder)))
>              (kill-this-buffer)
>              (mh-search "+" (list "--message-id" article))))
> -      (mh-search "+" article))
> +      (mh-search "+" (funcall mh-search-regexp-builder (list (cons 'message-id article)))))
>      (if (org-mhe-get-message-real-folder)
>          (mh-show-msg 1)
>        (kill-this-buffer)
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Re: Bug fix: org-mhe links don't work with mairix

[Nick Dokos]

Thomas Baumann <dtbaumann@yahoo.de> wrote:

> Hi Nick,
> 
> your patch actually breaks namazu, swish and grep searches. 
> 
> A look at mh-search-choices (mh-search.el) reveals that for namazu,
> swish and grep mh-search-regexp-builder is nil and therefore 
> 
> (funcall mh-search-regexp-builder ...
> 
> raises an error. One might be tempted to solve this on the mh-e side but
> there's no reason to add a mh-search-regexp-builder for those search
> engines. There's a patch against todays git below.
> 
> BTW. Namazu and pick searches work fine without angular brackets, however, it
> doesn't harm to have them.
> 
> 
> Greetings
> Thomas
> 

Thomas,

Yes indeed: sorry for the breakage and thanks for coming up with a
fix. I agree that it's preferable to change the call site rather than
asking for changes to mh-e.

Thanks very much,
Nick

PS. For the record, the patch against mh-e that I sent earlier to both
the mh-e and org lists has also been submitted on the mh-e sourceforge
patches list at

   http://sourceforge.net/tracker/?group_id=13357&atid=313357

It's number 1965704.

> 
> --- /data/cvs/org-mode/lisp/org-mhe.el	2008-05-17 12:54:07.000000000 +0200
> +++ org-mhe.el	2008-05-17 16:55:22.000000000 +0200
> @@ -204,8 +204,10 @@
>                       (not (org-mhe-get-message-real-folder)))
>              (kill-this-buffer)
>              (mh-search "+" (list "--message-id" article))))
> -      (mh-search "+" (funcall mh-search-regexp-builder
> -			      (list (cons 'message-id article)))))

> +      (if mh-search-regexp-builder
> +          (mh-search "+" (funcall mh-search-regexp-builder
> +			      (list (cons 'message-id article))))
> +        (mh-search "+" article)))
>      (if (org-mhe-get-message-real-folder)
>          (mh-show-msg 1)
>        (kill-this-buffer)
> 

--45B245DFCA.1211054880/gamaville.dokosmarshall.org--

Re: Bug fix: org-mhe links don't work with mairix

[Bill Wohler]

Thomas Baumann <dtbaumann@yahoo.de> wrote:

> your patch actually breaks namazu, swish and grep searches. 
> 
> A look at mh-search-choices (mh-search.el) reveals that for namazu,
> swish and grep mh-search-regexp-builder is nil and therefore 
> 
> (funcall mh-search-regexp-builder ...
> 
> raises an error. One might be tempted to solve this on the mh-e side but
> there's no reason to add a mh-search-regexp-builder for those search
> engines.

Thank you, Thomas. I agree.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/