From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell Date: Thu, 20 Feb 2020 17:26:04 +0100 Message-ID: <20aad61e-48e0-ba01-9255-793eacfdbc7e@easy-emacs.de> References: <877e0kjbqq.fsf@gmail.com> <874kvnako5.fsf@gmail.com> <871rqrak5y.fsf@gmail.com> <87wo8ik22r.fsf@gmail.com> <87d0a995hp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87d0a995hp.fsf@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: python-mode-bounces+gcpp-python-mode=m.gmane-mx.org@python.org Sender: "Python-mode" To: emacs-orgmode@gnu.org Cc: stardiviner , Jack Kamm , python-mode@python.org List-Id: emacs-orgmode.gnu.org , On 20.02.20 06:45, stardiviner wrote: Hi, python-mode.el developer here. >> Since python.el is built-in to Emacs, I think that things should >> continue to work for python-mode.el users, even if we entirely switch >> over to only using python.el. Thanks supporting python-mode.el. Both python-modes should not conflict - except for the key-setting, which is taken by the last one loaded: py-mode-map didn't work for some reasons, so both provide now python-mode-map. >> >> The only thing I'm not sure about, is whether the equivalent of >> "python-shell-send-region" in python-mode.el will work with shells >> started by python.el. If not, this could probably be addressed with a >> patch to python-mode.el. It should work. Will check it. Please feel free to send a bug-report resp. feature request to https://gitlab.com/python-mode-devs/python-mode/issues in case of python-mode.el related stuff. >> You could test this by explicitly setting `org-babel-python-mode' to >> `python' (it is probably set to `python-mode' on your system, which is >> the default when python-mode.el is detected). >> >> I'll add a TODO for myself to explicitly mark python-mode-related >> variables as deprecated. I'm also planning a major update to the Worg >> documentation of ob-python when 9.4 comes out, and will mention the >> deprecation there as well. > Thanks for your work! Jack > > - -- > [ stardiviner ] BTW there are some reasons, why python-mode.el still exists: no known indentation bugs, finer navigation commands etc. Maybe have a look at open python.el bugs and check them against python-mode.el Best, Andreas