From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eDz8NcnD62QqwgAA9RJhRA:P1 (envelope-from ) for ; Sun, 27 Aug 2023 23:44:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eDz8NcnD62QqwgAA9RJhRA (envelope-from ) for ; Sun, 27 Aug 2023 23:44:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A92834B63 for ; Sun, 27 Aug 2023 23:44:41 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=kU0LCnuP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=me.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693172681; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=nm1iek3Tbv/ZN63JnNbm4Hn5BNj7GooGmmpcwsaRZUM=; b=F+Y0psZTBYMlh7rOoRq8GkAoM6KDpSHD7RVnA/kE6ziidhEg0Pl8UBwyP8IiRbOkv/SYHm wyQcr6/UQDoXiu0hThuqjfKfAIW0e3JJ89jjheI+TcFI31dthYQHcuuHLMHM9Mjugmd0ny 4WKkCo97fvJ9hsJOSTlSvzk4JqN0KPL8/jmMoFlx57oYZYDVjWLaoYRf+XW8oF6aaWK1aS GB6hzOECbIDTTclK3xUt35DfI/qbwrvv2cDmHy8R0D1GyRKMJC8+4s8ECwRGhn0OoCN964 y77RV830dBM5uttBQrLOXTOcoaFIVfq5aRcjMAfGH21aVCLtmYJufQzRCPp2UA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=me.com header.s=1a1hai header.b=kU0LCnuP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=me.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693172681; a=rsa-sha256; cv=none; b=qhpvzlJKp/d7inj/jNeNeqpn3eA3KPguCGG1WH9IkqjRanGvEDllRTNtE67uWFFuZnCbcs HAGRuM6KFtTF31xojdlahj11keqJ8sWtC0viXsyc+m43QBx1La7gNtX3CldyfXPaTjVJap qs2p2lRN+DTb+lzA0dyQiEBxyXNR3iEvBLbarZwWcLRmylh5SmXCffW3TDvO9UXN5KCBvs L/zqsHKGROVmZ83BgngduOLhURKYG7pH0a182w8jcN3quDcolC2KiiNg4VrfKEA/tpYvW8 8R28yTfA4bba2VcS0gKX/x0C/CPFIbT7Z2gm60SrBkZp9wTbdoJt28eQU6lReg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaNY1-0002Pn-Cm; Sun, 27 Aug 2023 17:43:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaNXz-0002Ox-Qe for emacs-orgmode@gnu.org; Sun, 27 Aug 2023 17:43:51 -0400 Received: from pv50p00im-ztdg10011301.me.com ([17.58.6.40]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaNXx-0003ki-DI for emacs-orgmode@gnu.org; Sun, 27 Aug 2023 17:43:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1693172625; bh=nm1iek3Tbv/ZN63JnNbm4Hn5BNj7GooGmmpcwsaRZUM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kU0LCnuPo1RTJZMa1iFOZzvKGobt5OeUeay0R2cCDgr40Yjdvm7mc2SXgnCENCZrT vnCR9mLgTk2KU9e4FKrXyRveAjQWQN4b3ZDRxJMqlNg4NgKFhmgtm1bt2Q5LkXVIEf PZ9TwPxOiOlOk0zPY9/iEvvO2dtR4nQv1icgNk4rKiXHwHYjpOGWQ6Wf3G/30cKlu/ fhmrIzmC1oGtBRcjUByUWT04EKNniAPCE3VPSR3bbuc4pR32HXqv2vO26iSLF1yRjE umZksSR116bx7UcW0QNVAX3MpRdmEZiYwXCLmbtJbtmcya6qNLVBg78xgK1OCozrE2 4KrtCmQ6ZO0uQ== Received: from localhost.localdomain (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id 3A24E1800A2; Sun, 27 Aug 2023 21:43:43 +0000 (UTC) From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= To: emacs-orgmode@gnu.org Cc: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Subject: [PATCH] Fix a possibly problematic string comparison Date: Sun, 27 Aug 2023 23:43:20 +0200 Message-ID: <20230827214320.46754-1-salutis@me.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: LJ0NpfOrWaMqMywYkWWlUNn2iNRza_lX X-Proofpoint-ORIG-GUID: LJ0NpfOrWaMqMywYkWWlUNn2iNRza_lX X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=780 spamscore=0 clxscore=1015 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2308270206 Received-SPF: pass client-ip=17.58.6.40; envelope-from=salutis@me.com; helo=pv50p00im-ztdg10011301.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -8.19 X-Spam-Score: -8.19 X-Migadu-Queue-Id: 5A92834B63 X-TUID: 4uQDzHoEFrCc * lisp/org-table.el (org-table-make-reference): Replace 'eq' with 'string-empty-p' to resolve "Warning: 'eq' called with literal string that may never match" issued on every 'make' invocation. --- lisp/org-table.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-table.el b/lisp/org-table.el index f5a433c7d..b82749469 100644 --- a/lisp/org-table.el +++ b/lisp/org-table.el @@ -2864,7 +2864,7 @@ list, `literal' is for the format specifier L." (if lispp (if (eq lispp 'literal) elements - (if (and (eq elements "") (not keep-empty)) + (if (and (string-empty-p elements) (not keep-empty)) "" (prin1-to-string (if numbers (string-to-number elements) elements)))) -- 2.41.0