From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gNf/LwoVVGHtUwEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 09:26:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yO+UKwoVVGF9KgAAbx9fmQ (envelope-from ) for ; Wed, 29 Sep 2021 07:26:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3FE9EBD30 for ; Wed, 29 Sep 2021 09:26:02 +0200 (CEST) Received: from localhost ([::1]:49908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVTyb-0004A8-EJ for larch@yhetil.org; Wed, 29 Sep 2021 03:26:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVTuf-0007tZ-RZ; Wed, 29 Sep 2021 03:21:57 -0400 Received: from mail.tuxteam.de ([5.199.139.25]:58680) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.90_1) (envelope-from ) id 1mVTud-00086v-FF; Wed, 29 Sep 2021 03:21:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tuxteam.de; s=mail; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=n0kfYFuniMTUH9GSsj43FZ9u2fOSfqQb6XZBJj3wMts=; b=XGuROnIC94aWOG5u4lW1ZxHZf+8PAQuWy7GJFiLtL4N4PPPolSfJH9LaE0NrrPKq7UiGAeK4dXVEwNpUPccJzpTQFzuv7XHGHENdgG/na2HvzIVZmdlEVxUm0QzuZDXSSSF9yBTtKso0jYFarYEJ92ZbkRT1zsiG/VS205ZpNlKUses2EMkusuCjAGYX45t6e+Rg+SKMLVjKXAe4aZZTJugjkj2qVgqbnLrnbetF2Uo1ZhOsbVObRrteSK5fe8angHDxuqAIHyA4zxn+DPYVztV13mQWOXUHVxhih+6XJGAH4E6Y0jmUv5Lf2Bu0I6+26SWh7Qh/x1qWHQkANUnt3Q==; Received: from tomas by mail.tuxteam.de with local (Exim 4.80) (envelope-from ) id 1mVTuZ-00026j-A6; Wed, 29 Sep 2021 09:21:51 +0200 Date: Wed, 29 Sep 2021 09:21:51 +0200 From: tomas@tuxteam.de To: Jeremy Cowgar Subject: Re: [PATCH] Treat :tangle-mode as an octal value not integer Message-ID: <20210929072151.GD6367@tuxteam.de> References: <20210928145448.245883-1-jeremy@cowgar.com> <20210929063925.GA6367@tuxteam.de> <7e1c208b9fa8845adff5e3c45d6f086b@cowgar.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8w3uRX/HFJGApMzv" Content-Disposition: inline In-Reply-To: <7e1c208b9fa8845adff5e3c45d6f086b@cowgar.com> User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=5.199.139.25; envelope-from=tomas@tuxteam.de; helo=mail.tuxteam.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs-orgmode , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632900362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=n0kfYFuniMTUH9GSsj43FZ9u2fOSfqQb6XZBJj3wMts=; b=pZBSGTkC+05VWrrHDlPn9WQHufB3HvnY9zivPsiRyBAo24KemZ5+bUmank4v4fpA+VY0mg ezqY3BdK+F/A12xhQsF5iiij1gyae/bP1W7WceFqebHD1qOxPJcyHZNA8NEDUHFnypn7pG YZSdbTiVVHpQaq3+pUY0UlR93FZHddWKbHr0obAH5bVR5wqLOXUAZuGJjtCYlb2vRZPHuK oDt3Y9wn2/X3XNfPGDH22dfbVWHygFLUfJQZYNC0qApAWQEJcaEjaPD/XtWYGOCW7Nmk9b /A2qUbdNHCzUGbnUxWzG1tZVuNe8JRhuDROOuGrxW1lAzlyVlA1KIrGDe5OHwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632900362; a=rsa-sha256; cv=none; b=Y3z5DmNXtayviWabwIhhPRHCt98qEocpiebFTee8sR0TGzLC7irHXgJAT5DZU8JU7iMxwj J+3N9aFA4D0fQOPCs3qhGY8iXcoXNurgb5VqbyWyOxdK+jfGiPQ+nxgpkjGMZB34WVpIn5 K2J6XaChb1YPmppxNJn7HfuAz9hmQWUZ5qGtkEPj9HPEADsCfpdnxW7vs65QeT7RAf9bf/ mao5Dv2dY24b86SB+2dbTeyKDUp25FT/CLmchPZw5MH2tjYb2y7ty3tOHtbR5+S4m7CX6A l/G2zVE2Zr3dq6J8Id+Q5Fp3owAsA13mJx497OxcgDP7NKqCdNle4YYqDIGXFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tuxteam.de header.s=mail header.b=XGuROnIC; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tuxteam.de header.s=mail header.b=XGuROnIC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3FE9EBD30 X-Spam-Score: -3.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: WvVSYueCi/Zg --8w3uRX/HFJGApMzv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 29, 2021 at 02:55:46AM -0400, Jeremy Cowgar wrote: > On 2021-09-29 02:39, tomas@tuxteam.de wrote: > >On Tue, Sep 28, 2021 at 10:54:48AM -0400, Jeremy Cowgar wrote: > >>As an org user I would expect :tangle-mode 0660 to produce a file that > >>has user rw, group rw, other nothing. Instead, what really happens > >>currently is 0660 is treated as an integer which is actually > >>3140. This produces unexpected file permissions. > >> > > > >Hm. This looks dangerous: interpreting an integer as octal just > >due to the context? > > > >I do understand why, but still... > > > >Why not recommend Elisp's explicit syntax for octal representation, > >i.e. :tangle-mode #o660? And put a prominent note in the docs, > >of course. >=20 > Are you suggesting this currently works or that the patch should be > changed to make that work? A quick try on my local system (pre-patch), > I receive the error: >=20 > Wrong type argument: fixnump, "#o660" Oh. It seems Org converts that to string based on its own rules instead of on Elisp's. Note that I'm not dead set /against/ your proposal. I was pointing out a possible inconsistency and arguing for some reflection, however it may turn out. I'd have a slight preference for the #oXXX variant (and for Org agreeing with Elisp on what a number is ;-) but it's just that, a slight preference. The UNIX shell's convention "leading zero to denote base 8" (coming=20 =66rom C, I don't know where that comes from) is one not very happy hack, IMO. But if that's what is in people's muscle memory, so be it ;-) Cheers - t --8w3uRX/HFJGApMzv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAmFUFA8ACgkQBcgs9XrR2kYu2gCfZMa1U+u9OvBeQ6Pdii+WtwgN sHsAn1fbPqMmoaURJ4BchT12bE7L2uIR =5/MB -----END PGP SIGNATURE----- --8w3uRX/HFJGApMzv--