From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CIosBZMKVGHDOQEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 08:41:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +D3iAJMKVGHxfgAA1q6Kng (envelope-from ) for ; Wed, 29 Sep 2021 06:41:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AED011FED4 for ; Wed, 29 Sep 2021 08:41:20 +0200 (CEST) Received: from localhost ([::1]:51470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVTHL-0007QB-RQ for larch@yhetil.org; Wed, 29 Sep 2021 02:41:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVTFa-0007PG-5Z for emacs-orgmode@gnu.org; Wed, 29 Sep 2021 02:39:32 -0400 Received: from mail.tuxteam.de ([5.199.139.25]:58592) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.90_1) (envelope-from ) id 1mVTFY-00065d-9n for emacs-orgmode@gnu.org; Wed, 29 Sep 2021 02:39:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tuxteam.de; s=mail; h=From:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:To:Date; bh=kXPSwv/+pFqrKSwZ2CrDN+K70my5F2Z4dK8Q3/19c1M=; b=jXk4jFgUPjaXhXa9koGjFsXksnFWmXyKLlR75wfsAYYxT4LQD0LLcDfZvIVqI3E2mD9SV3WbrIih93FzNuuzZzP0MkKJxIzG8XwsoVVkDBZxMOZbDwXVrIygdSbOtqBb0p19VAM6G61ZyAEilitQW5NgAbs7c+gH3sokAFLJ/14o+/Nj5PTqMYuF/YXkqN4gGkgIGCJ7MQ5stRl7+4HtSkoNihhPfjXHVVinnttZDNb0jP7apCygOs2HwUZxRhK+ewAV8UTYgVPiiDjmwGq5riHznq3nuz73kgVsKyG+kdEq6uOWbjpGi9KB9Xklfj2B8BU2NJcGzzVZ47sqphdm+Q==; Received: from tomas by mail.tuxteam.de with local (Exim 4.80) (envelope-from ) id 1mVTFV-0001iX-Eq for emacs-orgmode@gnu.org; Wed, 29 Sep 2021 08:39:25 +0200 Date: Wed, 29 Sep 2021 08:39:25 +0200 To: emacs-orgmode@gnu.org Subject: Re: [PATCH] Treat :tangle-mode as an octal value not integer Message-ID: <20210929063925.GA6367@tuxteam.de> References: <20210928145448.245883-1-jeremy@cowgar.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <20210928145448.245883-1-jeremy@cowgar.com> User-Agent: Mutt/1.5.21 (2010-09-15) From: Received-SPF: pass client-ip=5.199.139.25; envelope-from=tomas@tuxteam.de; helo=mail.tuxteam.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632897680; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kXPSwv/+pFqrKSwZ2CrDN+K70my5F2Z4dK8Q3/19c1M=; b=P0JPdfcnfXJ/q3nef8dgTq8dVEPTSOk65u+2oy0Ee0zTLtP7PlVqDlPWUMyIxJDAMpaD5+ kQhO5NaPnGMiD38EzPqnOnJRedvRBR9vRjhKo/GKw9JpAqXH5aiLcvtYjkpDNByhlkGyDq lCDH7lr2fAcXUOcadeGKHeMomOMWdCP4QhYggbczOrnlje75PDigY0blfMcWrQdvVpAL5C gIvVkxXMOtQAJsltXLCZ6Ru+pt+UZHiHoBw6WSs0N1c3h+1c9FXDyje1Y2o8zWmCCdPQh0 vT8ujOQkpXKhowp905lfgVqAtc/9ofTRo0RpRj3ykO2RJV05b+sMa7ZXvF9YTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632897680; a=rsa-sha256; cv=none; b=gQ9DQ9Sz2x3afM8OY1wUgv/8CcEZ03Iq4nsNbauMs5cwNAWleLM02aqupnaQ7KYs7i9ZSq 5Ok6txX5HkFteaiOKK6SJNjSyUEt347VytLYscXLT/h/iXMU/fenNzFFOfoR5syKUN2tOo YnodTI/IelQfOCakII/3h44j1xBeqmd9xQjk7xdmsmNWO9hmmNuerDE4Wg6RJprQosOETR GX6sLzGOzP8RvjPVtUtiAmExc8ypGTULUh67QTmgwRYN/HiNkEo8kuxomRg12FiBVNstFO MMOq5OhG/k0+fx0ppwtZFkYK4svefa5oJnqe6QMcUpB47fAG72/4cdDgJvmalg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tuxteam.de header.s=mail header.b=jXk4jFgU; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -4.70 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tuxteam.de header.s=mail header.b=jXk4jFgU; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: AED011FED4 X-Spam-Score: -4.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: MxHV5q0XTdmm --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 28, 2021 at 10:54:48AM -0400, Jeremy Cowgar wrote: > As an org user I would expect :tangle-mode 0660 to produce a file that > has user rw, group rw, other nothing. Instead, what really happens > currently is 0660 is treated as an integer which is actually > 3140. This produces unexpected file permissions. >=20 > Prior to this patch to have rw,rw,none, one has to convert 0660 octal > into an integer (432) and then specify :tangle-mode 432. This is counter > intuitive and requires multiple steps. >=20 > After this patch, one just specifies the octal code as you do with > chmod. :tangle-mode 0660 results in a file that is rw,rw,none. Hm. This looks dangerous: interpreting an integer as octal just due to the context? I do understand why, but still... Why not recommend Elisp's explicit syntax for octal representation, i.e. :tangle-mode #o660? And put a prominent note in the docs, of course. Cheers - t --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAmFUCh0ACgkQBcgs9XrR2kZOGACeI/7ZYn1vukyjUp6MPQaRL67C yLcAn2i/EleRBNtdvK8epx1k/tmTFkdq =QNU+ -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--