emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jeremy Cowgar <jeremy@cowgar.com>
To: emacs-orgmode@gnu.org
Cc: Jeremy Cowgar <jeremy@cowgar.com>
Subject: [PATCH] Treat :tangle-mode as an octal value not integer
Date: Tue, 28 Sep 2021 10:54:48 -0400	[thread overview]
Message-ID: <20210928145448.245883-1-jeremy@cowgar.com> (raw)

As an org user I would expect :tangle-mode 0660 to produce a file that
has user rw, group rw, other nothing. Instead, what really happens
currently is 0660 is treated as an integer which is actually
3140. This produces unexpected file permissions.

Prior to this patch to have rw,rw,none, one has to convert 0660 octal
into an integer (432) and then specify :tangle-mode 432. This is counter
intuitive and requires multiple steps.

After this patch, one just specifies the octal code as you do with
chmod. :tangle-mode 0660 results in a file that is rw,rw,none.
---
 lisp/ob-tangle.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index 2dd1d031c..154bd5145 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -246,7 +246,12 @@ matching a regular expression."
 			     (get-spec (lambda (name) (cdr (assq name (nth 4 spec)))))
 			     (she-bang (let ((sheb (funcall get-spec :shebang)))
 				         (when (> (length sheb) 0) sheb)))
-			     (tangle-mode (funcall get-spec :tangle-mode)))
+			     (tangle-mode (let ((tmode (funcall get-spec :tangle-mode)))
+                                            (when tmode
+                                              ;; convert integer representing an octal
+                                              ;; number to its real octal value
+                                              (string-to-number
+                                               (number-to-string tmode) 8)))))
 		        (unless (string-equal block-lang lang)
 			  (setq lang block-lang)
 			  (let ((lang-f (org-src-get-lang-mode lang)))
-- 
2.30.2



             reply	other threads:[~2021-09-28 21:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 14:54 Jeremy Cowgar [this message]
2021-09-29  6:39 ` [PATCH] Treat :tangle-mode as an octal value not integer tomas
2021-09-29  6:55   ` Jeremy Cowgar
2021-09-29  7:21     ` tomas
2021-09-29  7:52     ` dkrm
2021-09-29  8:22       ` tomas
2021-09-29  9:29         ` Gyro Funch
2021-09-29 11:07           ` tomas
2021-09-29 13:17             ` Jeremy Cowgar
2021-09-29 13:55               ` tomas
2021-09-29  7:10   ` Greg Minshall
2021-09-29 11:35 ` Bastien
2021-09-29 13:48 ` Timothy
2021-09-29 14:26   ` tomas
2021-09-29 14:58     ` Timothy
2021-09-29 15:13       ` Jeremy Cowgar
2021-09-30 18:13         ` Timothy
2021-09-29 15:14       ` tomas
2021-09-29 17:18     ` Greg Minshall
2021-09-29 18:15       ` tomas
2021-11-18 12:04       ` Timothy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928145448.245883-1-jeremy@cowgar.com \
    --to=jeremy@cowgar.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).