From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iL4PGHdvnWCpBQAAgWs5BA (envelope-from ) for ; Thu, 13 May 2021 20:27:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ePCwE3dvnWC4aAAAB5/wlQ (envelope-from ) for ; Thu, 13 May 2021 18:27:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E529312F43 for ; Thu, 13 May 2021 20:27:02 +0200 (CEST) Received: from localhost ([::1]:52058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhG34-0000p0-3b for larch@yhetil.org; Thu, 13 May 2021 14:27:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhFxW-0003ML-Ll for emacs-orgmode@gnu.org; Thu, 13 May 2021 14:21:18 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:40609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhFxU-0000VY-NR for emacs-orgmode@gnu.org; Thu, 13 May 2021 14:21:18 -0400 Received: by mail-pl1-x62f.google.com with SMTP id n3so2703898plf.7 for ; Thu, 13 May 2021 11:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ckFamwvHA5S+uhnzkFfGggK7VM4VfUD87wVL2tUl3c=; b=qTEAJh5pUpfcCvVAkp44yLwQTSg9FCg6HBaZJUSs6CtwEkfgmHR1fTWPaqnb7f5gda 3iVnIl+3QrgUwkFJF1EMMK9MOqGtuROBwQV1f77+OGpxo5xbA9UrI0YGyZcqSHQurZW1 /unEHVOrX54jhmG4GQtkz/nJdKsZHafbmUpgQ5pz76qP+k1wTPQaDTL0EgEhU4m1J8Lq /IDqk6v0d2EkkY1kf5EwhPbfXZ1fbitIOr0YFUlFL1Wt+YqHuq5b2tlj3/ruG5cJSS2S aDHmK2RHoIVufnn2jfCzfNQn6hh1DRmb/UA/zfnI64UUFkIbfFt83/bl2AjX1cvfTezv 9yow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ckFamwvHA5S+uhnzkFfGggK7VM4VfUD87wVL2tUl3c=; b=aBwTNJb4o07j0O2BsKvUCz9RXarGCg92domF+SlJ0bEXc7b5u/6n1Co4VWrJOtECnu 6W1c5HqvZTEPaoPCbI6QBuoRgWYOJj+cw2nO6xz/CTJmVqx/8SqxVeYGp3nfDLTpvyPJ xLsTOQUH8YX/D7WYIBfybrV4L1tmnNA7hO1G8Ty+Os2laJOznQitMLzLZD8SGY1uftHu pmbjxdTand8WKDiKKD0hkY7n6gaiM+QF5KFoOQOn8bmbGYi1TcoQf9xNRT0TtgK3kIz1 D0VzvrQtbJ63o7boStxpIjUiUXik06JctNmgU3a0+DTb8Sy1mbf6APpgIZkIEEI8zPP/ 3Srw== X-Gm-Message-State: AOAM531sgbwdgzumYBGmrzz4/fj6suRv4nvHUg7n5CuhLPSfjwZYzRZT VMIXFQq6JvKrqwlngmiH7uY= X-Google-Smtp-Source: ABdhPJz4eLTYCyJSCkuwMQyicCjsmKmqwJP31L8dEhTPagw/L3PY24GZgsXUe+ahBqxkvXUizmhMiQ== X-Received: by 2002:a17:902:7488:b029:ef:838a:3071 with SMTP id h8-20020a1709027488b02900ef838a3071mr9155433pll.61.1620930074560; Thu, 13 May 2021 11:21:14 -0700 (PDT) Received: from localhost.localdomain (KD106154111012.au-net.ne.jp. [106.154.111.12]) by smtp.gmail.com with ESMTPSA id s3sm2516440pfu.9.2021.05.13.11.21.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 May 2021 11:21:14 -0700 (PDT) From: satotake To: manikulin@gmail.com Subject: Re: org-refile.el: Fix test case (Squashed) Date: Fri, 14 May 2021 03:20:51 +0900 Message-Id: <20210513182052.2798-1-doublequotation@gmail.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=doublequotation@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620930423; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=5ckFamwvHA5S+uhnzkFfGggK7VM4VfUD87wVL2tUl3c=; b=udy5+R0g1rRZ7mMC/unFOl3zsakH8xxgkZhQDcC6nD5N4PhiXGky2ggXVbkhhWRTIBSiAl zuFLzGiledzqIM56x0cF8LYN1mCK79PI8K098M7x7V+r9DY214eNg2JFfFzHbBUzLp3K2X f3YGEfHIqNmh7/H9cN9MThlMTjjDCTJChX/L6pwGv7kGdu0T4/v+XnIeCcGjcApFIY3BHC 65SHDa1+OZ17rnJyG6T7uVg9CjLkkJVeD4tB0pXmj0veXyBn/t2Y21QLg4JQRPRYDiUoi+ bRtK3k6NsClQh6vVU7A2q2ENjVxPk0BK+BK8nIUauU980eebpgg671AwSLdyxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620930423; a=rsa-sha256; cv=none; b=X1YGpqebIwy23hl0JTlanGh498vcYsVrzp7kHgLHp7Unw4QHk1yQ5trEaOELCmKGJB6Aif tZ+Ue2u36jclzpLdarWUuaKWbC2xrBnwYmgR1JQkRNajJo+pbB9ZH926kVfTtfygYdtPl8 Jto45kDYfkyPFRleP0ML+EIS6fJSiBdexmDwSCP89zGd4BIYwuu61y/jWNkFrtZpX79A8L G+7IkNHG5PpLHO3z6+hxkoy2KE+wVzn6DbmIB12HfP2YO9TJ9mCYC86tuHAxb1ZjTayRlf kK+9nHIOQWDyAeIvvfj8wvzrZVSbAAtlFo+VHztqYpYI9e0c1X3Jbm/ZQpRtwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=qTEAJh5p; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: 1.85 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=qTEAJh5p; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E529312F43 X-Spam-Score: 1.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: LbfJCfrMiJtr Thank you for your response. > Maybe I have missed something, but it seems 2 > patches are not logically independent, second one touches the same code > to fix regression in tests. > If so, could you, please, squash both > patches into a single one (e.g. using git rebase --interactive)? Yes. They should be a single patch. I squashed them. > Have you tried org-capture? Yes. Mostly I use org-capture, especially, for creating TODO tasks. I sometimes start with fundamental-mode new buffer. After writing some texts, I switch to org-mode and try to call refile. I do not know why I do it by myself clearly but I tend to do it when I do not have any clear goal for the file. I see this issue not critical for now because I know why this happens and just save it anywhere temporarily to avoid it. But when I was new to Emacs and org-mode, I did not have any idea. Thus, at least, we should show friendly error message. > Code around has at least one more problem: questionable behavior in the > case of indirect buffers (e.g. C-x 4 c). Refile targets cache, when > enabled, is not reused for indirect buffer. In addition to your point, I found that we cannot refile internally even with my patch. In other words, if we can cache and reuse it, error ("Please indicate a target file in the refile path") is raised when we select it as refile target. Probably, we need to some additional fixations. It may be good to filter `files' which does not have `buffer-file-name'.