From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id TgrkBzLpsF7sBgAA0tVLHw (envelope-from ) for ; Tue, 05 May 2020 04:18:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WLqOGDzpsF56DgAAB5/wlQ (envelope-from ) for ; Tue, 05 May 2020 04:19:08 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82FAB944569 for ; Tue, 5 May 2020 04:19:07 +0000 (UTC) Received: from localhost ([::1]:43396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVp2y-0005i7-0z for larch@yhetil.org; Tue, 05 May 2020 00:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVozZ-0001bo-0b for emacs-orgmode@gnu.org; Tue, 05 May 2020 00:15:37 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:57766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVozY-0001ff-1H for emacs-orgmode@gnu.org; Tue, 05 May 2020 00:15:36 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 2C0AB50A75; Tue, 5 May 2020 00:15:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=7MWASBZTjO1oXbX1shaHfzPfJ lg=; b=TbkJbXXQEri4LomIhdBS3jT1Ka2O/Si7yf7lk1dzCsk7AsunHMbCAoear w/Fovwzt9DfV8mZwdUabNTVHv12ZkJ7zeLF8uKEUfhzT5PZxQ+ia2J3VcmLIltmQ bThFV23bW5g6LWjWACQfsygxh7NDCkWxNW+5ccmU6tkPjO3Pf8= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 2528050A74; Tue, 5 May 2020 00:15:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=mesmtp; bh=pWYLKuXiel6+xiT+I0a727SY+xq552MzajKHQQecb9g=; b=p8euulabotLQoKj7VJlJgRYgVIPkNRBgdfuSIIu9lWfwyMKanNt28WBOFD/MKF2V5Q5/hMDkm33SzNhJh0FbmZGQx20xaQ58QMz1uwgd+YigZ/McHsA2CXrOw7kJ+olsJ/+Cx+7edmo+JBFaeq7Nigktz00Dofwi1D0tp/BNfoM= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 9DB0B50A73; Tue, 5 May 2020 00:15:34 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Axel Kielhorn , emacs-orgmode@gnu.org Subject: [PATCH 3/4] Autoload dynamic block definitions Date: Tue, 5 May 2020 00:15:21 -0400 Message-Id: <20200505041522.30222-4-kyle@kyleam.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200505041522.30222-1-kyle@kyleam.com> References: <3CE37EF0-6C7A-4CC0-AFEE-2B82296D63E1@axelkielhorn.de> <20200505041522.30222-1-kyle@kyleam.com> MIME-Version: 1.0 X-Pobox-Relay-ID: 111619E0-8E87-11EA-A76A-D1361DBA3BAF-24757444!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 00:15:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: 3.49 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=TbkJbXXQ; dkim=fail (body hash did not verify) header.d=kyleam.com header.s=mesmtp header.b=p8euulab; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [3.49 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49535510566204]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_MISSING_CHARSET(2.50)[]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_DKIM_REJECT(1.00)[pobox.com:s=sasl,kyleam.com:s=mesmtp]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.13), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[pobox.com:-,kyleam.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[kyle@kyleam.com,emacs-orgmode-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[axelkielhorn.de:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[kyleam.com]; HAS_LIST_UNSUB(-0.01)[]; MID_CONTAINS_FROM(1.00)[]; RCVD_COUNT_SEVEN(0.00)[7]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: H25rzB4IQeTn * lisp/org-clock.el: * lisp/org-colview.el: Autoload call to org-dynamic-block-define. The dynamic block dispatcher added in 34b71a0ca (Add a dispatcher command for inserting dynamic blocks, 2018-12-23) offers an entry for "clocktable" and "columnview" only after the corresponding library is loaded. However, before that commit, the autoloaded org-clock-report and org-columns-insert-dblock commands were accessible via plain key bindings. Restore the ability to access these commands before the associated library is loaded. Reported-by: Axel Kielhorn --- lisp/org-clock.el | 5 ++++- lisp/org-colview.el | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index a95c85437..690ba05b2 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2068,7 +2068,10 @@ (defun org-clock-report (&optional arg) (start (goto-char start))) (org-update-dblock)) =20 -(org-dynamic-block-define "clocktable" #'org-clock-report) +;;;###autoload +(eval-after-load 'org + '(progn + (org-dynamic-block-define "clocktable" #'org-clock-report))) =20 (defun org-day-of-week (day month year) "Return the day of the week as an integer." diff --git a/lisp/org-colview.el b/lisp/org-colview.el index e967154ab..3569b231b 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -1550,7 +1550,10 @@ (defun org-columns-insert-dblock () (id))))) (org-update-dblock)) =20 -(org-dynamic-block-define "columnview" #'org-columns-insert-dblock) +;;;###autoload +(eval-after-load 'org + '(progn + (org-dynamic-block-define "columnview" #'org-columns-insert-dblock)= )) =20 =0C ;;; Column view in the agenda --=20 2.26.1