emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* ox-confluence.el: omit radio target links (that end up being dead links)
@ 2020-03-17 15:09 Karl Voit
  2020-03-17 18:19 ` Karl Voit
  0 siblings, 1 reply; 4+ messages in thread
From: Karl Voit @ 2020-03-17 15:09 UTC (permalink / raw)
  To: emacs-orgmode

Hi!

As stated on [1] I do have an issue with export to Confluence markup
via org-mode/contrib/lisp/ox-confluence.el and radio targets[2].

When I am using a snippet like:

| - <<foo bar>> :: this is the explanation to this weird term
| 
|   [...]
| 
|   Please respect the foo bar everyhere.

... it gets exported like that:

| - *foo bar* - this is the explanation to this weird term
| 
|   [...]
| 
|   Please respect the [foo bar|foo bar] everyhere.

These "[foo bar|foo bar]" snippets are then interpreted by
Confluence as links to the Confluence pages named "foo bar" which
usually don't exist.

I think it would be a good improvement to ignore radio links in the
ox-confluence output.

Thanks!


[1] https://www.reddit.com/r/emacs/comments/fk5z1b/how_to_remove_foo_barfoo_bar_links_via/
    I'm asking how to search/replace current expressions as a
    short-term workaround.

[2] https://orgmode.org/manual/Radio-Targets.html

-- 
get mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML into Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <
Personal Information Management > http://Karl-Voit.at/tags/pim/
Emacs-related > http://Karl-Voit.at/tags/emacs/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ox-confluence.el: omit radio target links (that end up being dead links)
  2020-03-17 15:09 ox-confluence.el: omit radio target links (that end up being dead links) Karl Voit
@ 2020-03-17 18:19 ` Karl Voit
  2020-05-22 14:38   ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Karl Voit @ 2020-03-17 18:19 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

* Karl Voit <devnull@Karl-Voit.at> wrote:
>
> As stated on [1] I do have an issue with export to Confluence markup
> via org-mode/contrib/lisp/ox-confluence.el and radio targets[2].
>
> When I am using a snippet like:
>
>| - <<foo bar>> :: this is the explanation to this weird term
>| 
>|   [...]
>| 
>|   Please respect the foo bar everyhere.
>
> ... it gets exported like that:
>
>| - *foo bar* - this is the explanation to this weird term
>| 
>|   [...]
>| 
>|   Please respect the [foo bar|foo bar] everyhere.
>
> These "[foo bar|foo bar]" snippets are then interpreted by
> Confluence as links to the Confluence pages named "foo bar" which
> usually don't exist.
>
> I think it would be a good improvement to ignore radio links in the
> ox-confluence output.

Meanwhile, somebody posted a fix on [1]:

(defun export-radio-links-as-plain-text (link desc info)
  (when (string= "radio" (org-element-property :type link))
    desc))

(advice-add #'org-confluence-link :before-until
            #'export-radio-links-as-plain-text)

Maybe this is a good idea to include this in the official source code?

> [1] https://www.reddit.com/r/emacs/comments/fk5z1b/how_to_remove_foo_barfoo_bar_links_via/
>     I'm asking how to search/replace current expressions as a
>     short-term workaround.
>
> [2] https://orgmode.org/manual/Radio-Targets.html

-- 
get mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML into Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <
Personal Information Management > http://Karl-Voit.at/tags/pim/
Emacs-related > http://Karl-Voit.at/tags/emacs/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ox-confluence.el: omit radio target links (that end up being dead links)
  2020-03-17 18:19 ` Karl Voit
@ 2020-05-22 14:38   ` Bastien
  2020-05-22 14:58     ` Karl Voit
  0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2020-05-22 14:38 UTC (permalink / raw)
  To: Karl Voit; +Cc: Karl Voit, emacs-orgmode

Hi Karl,

I fixed this here:
https://code.orgmode.org/bzg/org-mode/commit/ceb0ef95fb

Thanks for the report,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ox-confluence.el: omit radio target links (that end up being dead links)
  2020-05-22 14:38   ` Bastien
@ 2020-05-22 14:58     ` Karl Voit
  0 siblings, 0 replies; 4+ messages in thread
From: Karl Voit @ 2020-05-22 14:58 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Bastien (bzg@gnu.org) wrote:

> Hi Karl,

Hi Bastien,

> I fixed this here:
> https://code.orgmode.org/bzg/org-mode/commit/ceb0ef95fb
> Thanks for the report,

Perfect timing for the fix - thank you!

-- 
Karl Voit


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-23 12:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 15:09 ox-confluence.el: omit radio target links (that end up being dead links) Karl Voit
2020-03-17 18:19 ` Karl Voit
2020-05-22 14:38   ` Bastien
2020-05-22 14:58     ` Karl Voit

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).