emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
@ 2017-10-20 11:12 Louis Strous
  2017-10-22 17:30 ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Louis Strous @ 2017-10-20 11:12 UTC (permalink / raw)
  To: emacs-orgmode

When I edit a c++ code block using C-c ' and then finish the edit using
C-c ' again, then org-mode sometimes adds a comma to the code.

Start of reproduction scenario:

1. Start emacs using "emacs -Q"

2. Execute "org-mode" to change the *scratch* buffer's major mode to
    org-mode.

3. Add the following text to the buffer:

#+BEGIN_SRC c++
#+END_SRC

4. Put the cursor at the beginning of the #+BEGIN_SRC line and press 
"C-c
    '" to start editing the code block.  The "*Org Src *scratch*[ c++ ]*"
    buffer is displayed.

5. Enter the following c++ code in the "*Org Src *scratch*[ c++ ]*" 
buffer:

if (foo)
   *foo = 3;

6. Note the absence of a comma in front of the "*".  Now press "C-c '"
    again to end editing the code block.  The code block in the *scratch*
    buffer changes to

#+BEGIN_SRC c++
   if (foo)
     ,*foo = 3;
#+END_SRC

    Note the appearance of a comma in front of the "*".

7. Press "C-c '" to edit the code block again.  The code displayed in
    the "*Org Src *scratch*[ c++ ]*" buffer does not contain the comma:

if (foo)
   *foo = 3;

8. Press "C-c '" to finish the editing.  The code in the *scratch*
    buffer still contains the comma.

End of reproduction scenario.

So far I have seen this behavior only when there is a * at the beginning
of the line of code.  I've seen it on three different systems, the one
mentioned below and also

Emacs  : GNU Emacs 25.2.1 (x86_64-w64-mingw32)
  of 2017-04-24
Package: Org-mode version 8.2.10 (release_8.2.10 @ 
d:/Documents/emacs/share/emacs/25.2/lisp/org/)

and

Emacs  : GNU Emacs 25.3.1 (x86_64-redhat-linux-gnu, GTK+ Version 
3.22.19)
  of 2017-09-15
Package: Org-mode version 8.2.10 (release_8.2.10 @ 
/usr/share/emacs/25.3/lisp/org/)

Regards,
Louis Strous

Emacs  : GNU Emacs 24.5.1 (i686-pc-mingw32)
  of 2015-04-11 on LEG570
Package: Org-mode version 8.2.10 (release_8.2.10 @ 
c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)

current state:
==============
(setq
  org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
			  org-babel-execute-safely-maybe)
  org-tab-first-hook '(org-hide-block-toggle-maybe
		      org-src-native-tab-command-maybe
		      org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
  org-cycle-hook '(org-cycle-hide-archived-subtrees 
org-cycle-hide-drawers
		  org-cycle-hide-inline-tasks org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
  org-agenda-before-write-hook '(org-agenda-add-entry-text)
  org-speed-command-hook '(org-speed-command-default-hook
			  org-babel-speed-command-hook)
  org-babel-pre-tangle-hook '(save-buffer)
  org-occur-hook '(org-first-headline-recenter)
  org-metaup-hook '(org-babel-load-in-session-maybe)
  org-confirm-elisp-link-function 'yes-or-no-p
  org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
  org-mode-hook '(#[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all
		    append local]
		   5]
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook
		    org-babel-show-result-all append local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
  org-metadown-hook '(org-babel-pop-to-session-maybe)
  org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
  org-after-todo-state-change-hook '(org-clock-out-if-current)
  org-confirm-shell-link-function 'yes-or-no-p
  )

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
  2017-10-20 11:12 Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)] Louis Strous
@ 2017-10-22 17:30 ` Nicolas Goaziou
  2017-10-23  9:25   ` Michal Politowski
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2017-10-22 17:30 UTC (permalink / raw)
  To: Louis Strous; +Cc: emacs-orgmode

Hello,

Louis Strous <louis@quae.nl> writes:

> When I edit a c++ code block using C-c ' and then finish the edit using
> C-c ' again, then org-mode sometimes adds a comma to the code.
>
> Start of reproduction scenario:
>
> 1. Start emacs using "emacs -Q"
>
> 2. Execute "org-mode" to change the *scratch* buffer's major mode to
>     org-mode.
>
> 3. Add the following text to the buffer:
>
> #+BEGIN_SRC c++
> #+END_SRC
>
>
> 4. Put the cursor at the beginning of the #+BEGIN_SRC line and press 
> "C-c
>     '" to start editing the code block.  The "*Org Src *scratch*[ c++ ]*"
>     buffer is displayed.
>
> 5. Enter the following c++ code in the "*Org Src *scratch*[ c++ ]*" 
> buffer:
>
> if (foo)
>    *foo = 3;
>
> 6. Note the absence of a comma in front of the "*".  Now press "C-c '"
>     again to end editing the code block.  The code block in the *scratch*
>     buffer changes to
>
> #+BEGIN_SRC c++
>    if (foo)
>      ,*foo = 3;
> #+END_SRC
>
>     Note the appearance of a comma in front of the "*".
>
> 7. Press "C-c '" to edit the code block again.  The code displayed in
>     the "*Org Src *scratch*[ c++ ]*" buffer does not contain the comma:
>
> if (foo)
>    *foo = 3;
>
> 8. Press "C-c '" to finish the editing.  The code in the *scratch*
>     buffer still contains the comma.
>
> End of reproduction scenario.

See (info "(org) Literal examples"), fourth footnote

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
  2017-10-22 17:30 ` Nicolas Goaziou
@ 2017-10-23  9:25   ` Michal Politowski
  2017-10-23 10:15     ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Politowski @ 2017-10-23  9:25 UTC (permalink / raw)
  To: emacs-orgmode

On Sun, 22 Oct 2017 19:30:55 +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Louis Strous <louis@quae.nl> writes:
> 
> > When I edit a c++ code block using C-c ' and then finish the edit using
> > C-c ' again, then org-mode sometimes adds a comma to the code.
[...]
> >     Note the appearance of a comma in front of the "*".
> >
> > 7. Press "C-c '" to edit the code block again.  The code displayed in
> >     the "*Org Src *scratch*[ c++ ]*" buffer does not contain the comma:
> >
> > if (foo)
> >    *foo = 3;
> >
> > 8. Press "C-c '" to finish the editing.  The code in the *scratch*
> >     buffer still contains the comma.
> >
> > End of reproduction scenario.
> 
> See (info "(org) Literal examples"), fourth footnote

Interesting, even if not very likely to hit anyone, that lines
intentionally starting with ,,* are not escaped and thus
lose one comma on the next edit.

-- 
Michał Politowski
Talking has been known to lead to communication if practiced carelessly.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
  2017-10-23  9:25   ` Michal Politowski
@ 2017-10-23 10:15     ` Nicolas Goaziou
  2017-10-23 13:00       ` Michal Politowski
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2017-10-23 10:15 UTC (permalink / raw)
  To: Michal Politowski; +Cc: emacs-orgmode

Hello,

Michal Politowski <mpol@meep.pl> writes:

> Interesting, even if not very likely to hit anyone, that lines
> intentionally starting with ,,* are not escaped and thus
> lose one comma on the next edit.

Could you provide an ECM?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
  2017-10-23 10:15     ` Nicolas Goaziou
@ 2017-10-23 13:00       ` Michal Politowski
  2017-10-24  7:57         ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Politowski @ 2017-10-23 13:00 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

On Mon, 23 Oct 2017 12:15:29 +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Michal Politowski <mpol@meep.pl> writes:
> 
> > Interesting, even if not very likely to hit anyone, that lines
> > intentionally starting with ,,* are not escaped and thus
> > lose one comma on the next edit.
> 
> Could you provide an ECM?

I mean something like this. I'm new to org and don't know any practical
examples where it matters, but it's interesting.

#+BEGIN_EXAMPLE
  Start editing with C-c ' enter ,* and ,,* at the beginninng of the next two lines,
  end end editing with C-c ' - you get two identical lines.
#+END_EXAMPLE

-- 
Michał Politowski
Talking has been known to lead to communication if practiced carelessly.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)]
  2017-10-23 13:00       ` Michal Politowski
@ 2017-10-24  7:57         ` Nicolas Goaziou
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2017-10-24  7:57 UTC (permalink / raw)
  To: Michal Politowski; +Cc: emacs-orgmode

Hello,

Michal Politowski <mpol@meep.pl> writes:

> On Mon, 23 Oct 2017 12:15:29 +0200, Nicolas Goaziou wrote:
>> Hello,
>> 
>> Michal Politowski <mpol@meep.pl> writes:
>> 
>> > Interesting, even if not very likely to hit anyone, that lines
>> > intentionally starting with ,,* are not escaped and thus
>> > lose one comma on the next edit.
>> 
>> Could you provide an ECM?
>
> I mean something like this. I'm new to org and don't know any practical
> examples where it matters, but it's interesting.
>
> #+BEGIN_EXAMPLE
>   Start editing with C-c ' enter ,* and ,,* at the beginninng of the next two lines,
>   end end editing with C-c ' - you get two identical lines.
> #+END_EXAMPLE

Fixed. Thank you.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-24  7:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-20 11:12 Bug: c++ code block automatically adds comma [8.2.10 (release_8.2.10 @ c:/Users/Louis/home/bin/emacs-24.5/share/emacs/24.5/lisp/org/)] Louis Strous
2017-10-22 17:30 ` Nicolas Goaziou
2017-10-23  9:25   ` Michal Politowski
2017-10-23 10:15     ` Nicolas Goaziou
2017-10-23 13:00       ` Michal Politowski
2017-10-24  7:57         ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).