From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Frankel Subject: Re: S5 HTML export - org9.1.1 Date: Sat, 7 Oct 2017 15:33:58 -0400 Message-ID: <20171007193358.i7uwhuzglbeoxv4b@eyeBook> References: <87376v81pn.fsf@pclin.dcthindom.org> <87fuavoufs.fsf@kyleam.com> <87shev6jxw.fsf@pclin.dcthindom.org> <87d15ypzae.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0urq-0008UV-G7 for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 15:34:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0urm-00005N-5j for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 15:34:34 -0400 Received: from mail.cybercode.nyc ([45.55.183.129]:47600) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0urm-0008VW-0h for emacs-orgmode@gnu.org; Sat, 07 Oct 2017 15:34:30 -0400 Received: from authenticated-user (mail.cybercode.nyc [45.55.183.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.cybercode.nyc (Postfix) with ESMTPSA id E7BEC1401BC for ; Sat, 7 Oct 2017 15:33:58 -0400 (EDT) Content-Disposition: inline In-Reply-To: <87d15ypzae.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org As the orginal author -- who hasn't looked @ or used ox-s5 in years ;O, just confirming the patch looks correct to me. I don't think i have commit privilges anymore (lost that ssh key), so i appreciate your applying it. thanks, rick On Sat, Oct 07, 2017 at 06:51:05PM +0000, Kyle Meyer wrote: > dchechin92@gmail.com writes: > > I have evaluated the following function found in ox-html.el > > and indeed the S5 html works when this function is defined. > > > > (defun org-html-end-plain-list (type) > > "Insert the end of the HTML list depending on TYPE." > > (case type > > (`ordered "") > > (`unordered "") > > (`descriptive ""))) > > Yes, that's the function that was removed in 8855c23c6. > > > I don't know if this function should appear accordly in > > ox-S5.el or elsewhere. As I don't use development environment > > I don't know how a patch has to be submitted. > > > > Anyway thank for your help. Hope it can be useful for the > > person who knows how to implement it and where. > > I don't use ox-s5.el, but the I think the below fix should do. I'll > push it in a few days if no one objects. > > -- >8 -- > Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list > > * contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of > org-html-end-plain-list. > > The function org-html-end-plain-list was deleted in > 8855c23c6 (ox-html: Plain list supports arbitrary attributes, > 2017-02-13). > > Reported-by: > > --- > contrib/lisp/ox-s5.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el > index 8f9501058..0496aae19 100644 > --- a/contrib/lisp/ox-s5.el > +++ b/contrib/lisp/ox-s5.el > @@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info) > "<%s class='org-%s%s'>" tag tag > (if (org-export-get-node-property :INCREMENTAL plain-list t) > " incremental" "")) > - contents (org-html-end-plain-list type)))) > + contents > + (format "" tag)))) > > (defun org-s5-inner-template (contents info) > "Return body of document string after HTML conversion.