S5 HTML export - org9.1.1

S5 HTML export - org9.1.1

[dchechin92]

Hello,

Since I upgrade to org-9.1.1, the export to S5 HTML seems not to work
whereas it used to work before this upgrade.

I have the following message :
"format: Symbol's function definition is void: org-html-end-plain-list"
I use GNU Emacs 25.1.1 (x86_64-w64-mingw32).

Do someone as the same problem ? Is there something wrong in my configuration ?

Regards

Re: S5 HTML export - org9.1.1

[Kyle Meyer]

Hello,

dchechin92@gmail.com writes:

> Since I upgrade to org-9.1.1, the export to S5 HTML seems not to work
> whereas it used to work before this upgrade.
>
> I have the following message :
> "format: Symbol's function definition is void: org-html-end-plain-list"
> I use GNU Emacs 25.1.1 (x86_64-w64-mingw32).
>
> Do someone as the same problem ? Is there something wrong in my configuration ?

It looks like org-html-end-plain-list was removed in 8855c23c6 (ox-html:
Plain list supports arbitrary attributes, 2017-02-13).  ox-s5.el needs
to be adjusted accordingly (essentially following the changes that
8855c23c6 made to org-html-plain-list, I think).  Would you like to
submit a patch?

-- 
Kyle

Re: S5 HTML export - org9.1.1

[dchechin92]

Hello,

I have evaluated the following function found in ox-html.el
and indeed the S5 html works when this function is defined.

(defun org-html-end-plain-list (type)
  "Insert the end of the HTML list depending on TYPE."
  (case type
    (`ordered "</ol>")
    (`unordered "</ul>")
    (`descriptive "</dl>")))


I don't know if this function should appear accordly in
ox-S5.el or elsewhere. As I don't use development environment
I don't know how a patch has to be submitted.

Anyway thank for your help. Hope it can be useful for the
person who knows how to implement it and where.

Regards

Re: S5 HTML export - org9.1.1

[Kyle Meyer]

dchechin92@gmail.com writes:

> I have evaluated the following function found in ox-html.el
> and indeed the S5 html works when this function is defined.
>
> (defun org-html-end-plain-list (type)
>   "Insert the end of the HTML list depending on TYPE."
>   (case type
>     (`ordered "</ol>")
>     (`unordered "</ul>")
>     (`descriptive "</dl>")))

Yes, that's the function that was removed in 8855c23c6.

> I don't know if this function should appear accordly in
> ox-S5.el or elsewhere. As I don't use development environment
> I don't know how a patch has to be submitted.
>
> Anyway thank for your help. Hope it can be useful for the
> person who knows how to implement it and where.

I don't use ox-s5.el, but the I think the below fix should do.  I'll
push it in a few days if no one objects.

-- >8 --
Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list

* contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of
org-html-end-plain-list.

The function org-html-end-plain-list was deleted in
8855c23c6 (ox-html: Plain list supports arbitrary attributes,
2017-02-13).

Reported-by: <dchechin92@gmail.com>
<https://lists.gnu.org/archive/html/emacs-orgmode/2017-10/msg00123.html>
---
 contrib/lisp/ox-s5.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el
index 8f9501058..0496aae19 100644
--- a/contrib/lisp/ox-s5.el
+++ b/contrib/lisp/ox-s5.el
@@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info)
              "<%s class='org-%s%s'>" tag tag
              (if (org-export-get-node-property :INCREMENTAL plain-list t)
                  " incremental" ""))
-            contents (org-html-end-plain-list type))))
+            contents
+	    (format "</%s>" tag))))
 
 (defun org-s5-inner-template (contents info)
   "Return body of document string after HTML conversion.
-- 
2.14.2

Re: S5 HTML export - org9.1.1

[Rick Frankel]

As the orginal author -- who hasn't looked @ or used ox-s5 in years ;O, just
confirming the patch looks correct to me. I don't think i have commit
privilges anymore (lost that ssh key), so i appreciate your applying it.

thanks,
rick

On Sat, Oct 07, 2017 at 06:51:05PM +0000, Kyle Meyer wrote:
> dchechin92@gmail.com writes:
> > I have evaluated the following function found in ox-html.el
> > and indeed the S5 html works when this function is defined.
> >
> > (defun org-html-end-plain-list (type)
> >   "Insert the end of the HTML list depending on TYPE."
> >   (case type
> >     (`ordered "</ol>")
> >     (`unordered "</ul>")
> >     (`descriptive "</dl>")))
> 
> Yes, that's the function that was removed in 8855c23c6.
> 
> > I don't know if this function should appear accordly in
> > ox-S5.el or elsewhere. As I don't use development environment
> > I don't know how a patch has to be submitted.
> >
> > Anyway thank for your help. Hope it can be useful for the
> > person who knows how to implement it and where.
> 
> I don't use ox-s5.el, but the I think the below fix should do.  I'll
> push it in a few days if no one objects.
> 
> -- >8 --
> Subject: [PATCH] ox-s5: Don't use org-html-end-plain-list
> 
> * contrib/lisp/ox-s5.el (org-s5-plain-list): Adjust for the removal of
> org-html-end-plain-list.
> 
> The function org-html-end-plain-list was deleted in
> 8855c23c6 (ox-html: Plain list supports arbitrary attributes,
> 2017-02-13).
> 
> Reported-by: <dchechin92@gmail.com>
> <https://lists.gnu.org/archive/html/emacs-orgmode/2017-10/msg00123.html>
> ---
>  contrib/lisp/ox-s5.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/lisp/ox-s5.el b/contrib/lisp/ox-s5.el
> index 8f9501058..0496aae19 100644
> --- a/contrib/lisp/ox-s5.el
> +++ b/contrib/lisp/ox-s5.el
> @@ -292,7 +292,8 @@ (defun org-s5-plain-list (plain-list contents info)
>               "<%s class='org-%s%s'>" tag tag
>               (if (org-export-get-node-property :INCREMENTAL plain-list t)
>                   " incremental" ""))
> -            contents (org-html-end-plain-list type))))
> +            contents
> +	    (format "</%s>" tag))))
>  
>  (defun org-s5-inner-template (contents info)
>    "Return body of document string after HTML conversion.

Re: S5 HTML export - org9.1.1

[Nicolas Goaziou]

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> I don't use ox-s5.el, but the I think the below fix should do.  I'll
> push it in a few days if no one objects.

I think this is an uncontroversial patch. You can go ahead and push it
right now.

Thank you.

Regards,

-- 
Nicolas Goaziou