emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: buffer local variables handled wrong [9.0.5 (release_9.0.5-497-g5bc540 @ /home/hs/.emacs.d/lib/org-mode/lisp/)]
Date: Sun, 4 Jun 2017 11:18:19 +0200	[thread overview]
Message-ID: <20170604091819.GI7145@seven> (raw)
In-Reply-To: <877f0snorq.fsf@nicolasgoaziou.fr>

Mail von Nicolas Goaziou, Sun, 04 Jun 2017 at 10:24:57 +0200:

Hello,

> "Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:
> 
> > I looked at it, but sorry, I think this also is not right, it expands to:
> >
> > Both looking wrong for me. Sorry.
> 
> What do you think is wrong?
> 
> In particular
> 
>   (let (res)
>     (dolist (pair (buffer-local-variables))
>       (pcase pair
>         (`(,var . ,val)
>          (push (list 'set var val) res))))
>     res)
> 
> expands to
> 
>   ((set flyspell-word-cache-result _)
>    (set flyspell-word-cache-end -1)
>    (set undo-auto--last-boundary-cause (2 #<buffer *scratch*>))
>    (set syntax-ppss-last (1 0 nil nil nil nil nil 0 nil nil nil))
>    (set syntax-propertize--done 139)
>    (set flyspell-changes nil)
>    (set deactivate-mark nil)
>    (set flyspell-pre-point 139)
>    (set auto-revert-notify-modified-p nil)
>    ...
>    )
> 
> which looks correct.

Obviously you are right, I get the ame result when evaluating it.

What I don't understand is, if I expand the pcase with (macrostep-expand) I
get the following:

,----
|     (let (res)
|     (dolist (pair (buffer-local-variables))
|       (if
|           (consp pair)
|           (let*
|               ((x
|                 (car pair))
|                (x
|                 (cdr pair)))
|             (let
|                 ((val x)
|                  (var x))
|               (push
|                (list 'set var val)
|                res)))
|         nil))
|     res)
`----

And this is obviously wrong.

With kind regards,
Stefan

-- 
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.

  reply	other threads:[~2017-06-04  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 11:48 Bug: buffer local variables handled wrong [9.0.5 (release_9.0.5-497-g5bc540 @ /home/hs/.emacs.d/lib/org-mode/lisp/)] Stefan-W. Hahn
2017-06-03 20:46 ` Nicolas Goaziou
2017-06-04  6:57   ` Stefan-W. Hahn
2017-06-04  7:19     ` Nicolas Goaziou
2017-06-04  8:08       ` Stefan-W. Hahn
2017-06-04  8:24         ` Nicolas Goaziou
2017-06-04  9:18           ` Stefan-W. Hahn [this message]
2017-06-04  9:35             ` Nicolas Goaziou
2017-06-04  9:52               ` Stefan-W. Hahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170604091819.GI7145@seven \
    --to=stefan.hahn@s-hahn.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).