From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
Subject: Re: Bug: buffer local variables handled wrong [9.0.5
 (release_9.0.5-497-g5bc540 @ /home/hs/.emacs.d/lib/org-mode/lisp/)]
Date: Sun, 4 Jun 2017 10:08:22 +0200
Message-ID: <20170604080822.GH7145@seven>
References: <20170603114859.GE7145@seven> <87a85olrzq.fsf@nicolasgoaziou.fr>
	<20170604065733.GG7145@seven> <87o9u4nrte.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.hahn@s-hahn.de>) id 1dHQak-0007n5-A2
	for emacs-orgmode@gnu.org; Sun, 04 Jun 2017 04:08:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefan.hahn@s-hahn.de>) id 1dHQag-0001bo-7a
	for emacs-orgmode@gnu.org; Sun, 04 Jun 2017 04:08:54 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:53593)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <stefan.hahn@s-hahn.de>)
	id 1dHQaf-0001al-P7
	for emacs-orgmode@gnu.org; Sun, 04 Jun 2017 04:08:50 -0400
Content-Disposition: inline
In-Reply-To: <87o9u4nrte.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Mail von Nicolas Goaziou, Sun, 04 Jun 2017 at 09:19:09 +0200:

Good morning again,

> Hello,
> 
> "Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:
> 
> > For me both cases don't look correct or do I missinterpret something?
> 
> No, you're right. I fixed it. Thank you.

I looked at it, but sorry, I think this also is not right, it expands to:

,----
| (defun org-agenda-mode ()
| ...
| 	   (mapc #'make-local-variable org-agenda-local-vars)
| 	   (dolist (elem save)
| 	     (if
| 		 (consp elem)
| 		 (let*
| 		     ((x
| 		       (car elem))
| 		      (x
| 		       (cdr elem)))
| 		   (let
| 		       ((val x)
| 			(var x))
| 		     (when
| 			 (and val
| 			      (memq var org-agenda-local-vars))
| 		       (set var val))))
| 	       nil)))
| 	 (setq-local org-agenda-this-buffer-is-sticky t))
| 	(org-agenda-sticky
`----

and the second one:

,----
| (defun org-clone-local-variables (from-buffer &optional regexp)
| ...
|   (dolist (pair (buffer-local-variables from-buffer))
|     (if
| 	(consp pair)
| 	(let*
| 	    ((x
| 	      (car pair))
| 	     (x
| 	      (cdr pair)))
| 	  (if
| 	      (consp x)
| 	      (let*
| 		  ((x
| 		    (cdr x)))
| 		(if
| 		    (null x)
| 		    (let
| 			((name x))
| 		      (when
| 			  (and
| 			   (not
| 			    (memq name org-unique-local-variables))
| 			   (or
| 			    (null regexp)
| 			    (string-match-p regexp
| 					    (symbol-name name))))
| 			(set
| 			 (make-local-variable name)
| 			 (cdr pair))))
| 		  nil))
| 	    nil))
|       nil)))
`----

Both looking wrong for me. Sorry.

With kind regards,
Stefan

-- 
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.