From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
Subject: Re: commit 4e864643 breaks org-return
Date: Sat, 24 Oct 2015 08:48:47 +0200
Message-ID: <20151024064847.GA14197@pille.home>
References: <20151022165708.GL12141@scotty.home>
	<20151023200734.GM12141@scotty.home>
	<87twphxlgx.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.hahn@s-hahn.de>) id 1ZpsdM-0006rA-Rg
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 02:48:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefan.hahn@s-hahn.de>) id 1ZpsdJ-0006Lr-Lm
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 02:48:56 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:63594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.hahn@s-hahn.de>) id 1ZpsdJ-0006Lb-FN
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 02:48:53 -0400
Content-Disposition: inline
In-Reply-To: <87twphxlgx.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Mail von Nicolas Goaziou, Sat, 24 Oct 2015 at 00:34:54 +0200:

Hello,

> >> commit 4e864643bdb6bba3e000ea51fb746a26e40b1f77
> >> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> >> Date:   Sun Oct 18 09:36:15 2015 +0200
> >>=20
> >> changes the behaviour of org-return when positioned right after a link=
 with
> >> org-return-follows-link set to t.
> >
> > the following patch seems to repair the behaviour:
>=20
> But is the current behaviour broken in the first place? At least it is
> consistent with `org-open-at-point' (C-c C-o).

Yes. Yes.

Before commit 4e86464 the behaviour was:

[[link][description]]x

with cursor at x hitting <RET> I got a line opened with cursor positioned
at the beginning of the new line (or indented).

But you are right, org-open-at-point with cursor at position x jumps
to the link. This behaviour is not changed with the commit but I think
this is also not the right behaviour. If you go with the mouse over the x
then you don't get any popup from the link. For this you have to
go at least over the last character "]" of the link resp. the visual "n"
of the description. Even if you describe-text-properties with cursor at x
you don't get any hint of the link. You have to go over the "]" (resp. "n")
to see the link hint.

=46rom my point of view the commit 4e86464 changes the behaviour of org-ret=
urn
in a manner of which I think is not natural. org-open-at-point is, in my
opinion, wrong in the same way because description says:
"... When point is on a link, follow it."
And being with cursor at x is obviously not "on a link".

Any opinions from you or other org'ers?

With kind regards,
Stefan

--=20
Stefan-W. Hahn                          It is easy to make things.
                                        It is hard to make things simple.