From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregor Zattler Subject: fix is with another glitch when adding two dates (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]) Date: Wed, 4 Feb 2015 17:37:10 +0100 Message-ID: <20150204163710.GJ24678@boo.workgroup> References: <87mw4xjpgc.fsf@boo.workgroup> <87bnlc449s.fsf@nicolasgoaziou.fr> <20150203212701.GG1231@boo.workgroup> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2xe-0000QV-NH for emacs-orgmode@gnu.org; Wed, 04 Feb 2015 11:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ2xY-0008Q4-P7 for emacs-orgmode@gnu.org; Wed, 04 Feb 2015 11:37:54 -0500 Received: from mout.gmx.net ([212.227.15.18]:61614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ2xY-0008Py-F9 for emacs-orgmode@gnu.org; Wed, 04 Feb 2015 11:37:48 -0500 Received: from boo.workgroup ([87.185.189.227]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LqiJO-1Xf3En1TLG-00eJqf for ; Wed, 04 Feb 2015 17:37:47 +0100 Content-Disposition: inline In-Reply-To: <20150203212701.GG1231@boo.workgroup> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode Hi Nicolas, org-mode developers, there is still a glitch. If I now add two items at the same day.: rm /tmp/*diary* ; emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw --eval '(setq org-agenda-diary-file „/tmp/diary.org“)' "/tmp/diary.org" -f org-agenda a i d error1 i d error2 the result is: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> * 2015 ** 2015-02 Februar *** 2015-02-04 Mittwoch **** error2 <2015-02-04 Mi>**** error1 <2015-02-04 Mi> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< instead of: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> * 2015 ** 2015-02 Februar *** 2015-02-04 Mittwoch **** error2 <2015-02-04 Mi> **** error1 <2015-02-04 Mi> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< With org-mode as of f9ab1e8ab6b5b6604e838ac992ad51a594ed7130 it’s correct and „error1“ is above „error2“. This seems more natural (at least for me). I did a git bisect and the first bad commit is Nicolas fix for my original bug report: 1d4c79d41525113f9e43b82dc9b24d353dc311bd is the first bad commit commit 1d4c79d41525113f9e43b82dc9b24d353dc311bd Author: Nicolas Goaziou Date: Mon Feb 2 18:19:30 2015 +0100 org-agenda: Fix agenda diary corruption * lisp/org-agenda.el (org-agenda-insert-diary-make-new-entry): Do not save excursion or final position is lost. Reported-by: Gregor Zattler :040000 040000 9226a2e0b05d53fcc633f89663ee9cb6803e2701 dc0856aa67db029d63f64b9159626468bd93f7f7 M lisp Thanks for your attention, gregor * Gregor Zattler [03. Feb. 2015]: > * Nicolas Goaziou [02. Feb. 2015]: >> Gregor Zattler writes: >>> adding a date to the datetree in the org-agenda-diary-file >>> produces a mess: >>> >>> - emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org") >>> - Mx org-agenda >>> - a >>> - i >>> - d >>> - error >>> >>> gives: >>> >>>>>>>>>>>>>>>>>> >>> >>> * 2015 >>> ** 2015-02 Februar >>> <2015-02-01 So>*** 2015-02-01 Sonntag >>> **** error >>> >>> <<<<<<<<<<<<<<<<<<<< >>> >>> >>> instead of: >>> >>>>>>>>>>>>>>>>>> >>> * 2015 >>> ** 2015-02 Februar >>> *** 2015-02-01 Sonntag >>> **** error >>> <2015-02-01 So> >>> <<<<<<<<<<<<<<<<<<<< >> >> This should be fixed. Thank you. > > Confirmed, thank you. > > Ciao, Gregor > -- > -... --- .-. . -.. ..--.. ...-.- > Ciao, Gregor -- -... --- .-. . -.. ..--.. ...-.-