* Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]
@ 2015-02-01 21:23 Gregor Zattler
2015-02-02 17:22 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Gregor Zattler @ 2015-02-01 21:23 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
Dear org-mode developers,
adding a date to the datetree in the org-agenda-diary-file
produces a mess:
- emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org")
- Mx org-agenda
- a
- i
- d
- error
gives:
>>>>>>>>>>>>>>>
* 2015
** 2015-02 Februar
<2015-02-01 So>*** 2015-02-01 Sonntag
**** error
<<<<<<<<<<<<<<<<<<<<
instead of:
>>>>>>>>>>>>>>>
* 2015
** 2015-02 Februar
*** 2015-02-01 Sonntag
**** error
<2015-02-01 So>
<<<<<<<<<<<<<<<<<<<<
This is with:
Emacs : GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 3.14.5)
of 2015-02-01 on boo
Package: Org-mode version 8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)
I did a git bisect and got:
a1116aa54ee4befd8fa52e3f92207db200ebfd59 is the first bad commit
commit a1116aa54ee4befd8fa52e3f92207db200ebfd59
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Fri Jan 30 10:23:47 2015 +0100
Fix ‘org-agenda-insert-diary-make-new-entry’
* lisp/org-agenda.el (org-agenda-insert-diary-make-new-entry): Ensure
point is at a real body line and not in front of meta data, so
regular contents can be inserted safely after a call to this
function.
Reported-by: Samuel Loury <konubinix@gmail.com>
<http://permalink.gmane.org/gmane.emacs.orgmode/94482>
:040000 040000 c02a04761fd8b4f2b518852afca3b44f4f0642ae 60b6dc4cf3232b8059b8e8c778949d8b466a2e75 M lisp
Thanks for your attention, Gregor
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]
2015-02-01 21:23 Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)] Gregor Zattler
@ 2015-02-02 17:22 ` Nicolas Goaziou
2015-02-03 21:27 ` fix confirmed (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]) Gregor Zattler
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2015-02-02 17:22 UTC (permalink / raw)
To: emacs-orgmode
Hello,
Gregor Zattler <grfz@gmx.de> writes:
> Dear org-mode developers,
>
> adding a date to the datetree in the org-agenda-diary-file
> produces a mess:
>
> - emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org")
> - Mx org-agenda
> - a
> - i
> - d
> - error
>
> gives:
>
>>>>>>>>>>>>>>>>
>
> * 2015
> ** 2015-02 Februar
> <2015-02-01 So>*** 2015-02-01 Sonntag
> **** error
>
> <<<<<<<<<<<<<<<<<<<<
>
>
> instead of:
>
>>>>>>>>>>>>>>>>
> * 2015
> ** 2015-02 Februar
> *** 2015-02-01 Sonntag
> **** error
> <2015-02-01 So>
> <<<<<<<<<<<<<<<<<<<<
This should be fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* fix confirmed (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)])
2015-02-02 17:22 ` Nicolas Goaziou
@ 2015-02-03 21:27 ` Gregor Zattler
2015-02-04 16:37 ` fix is with another glitch when adding two dates " Gregor Zattler
0 siblings, 1 reply; 6+ messages in thread
From: Gregor Zattler @ 2015-02-03 21:27 UTC (permalink / raw)
To: emacs-orgmode
Hi Nicolas,
* Nicolas Goaziou <mail@nicolasgoaziou.fr> [02. Feb. 2015]:
> Gregor Zattler <grfz@gmx.de> writes:
>> adding a date to the datetree in the org-agenda-diary-file
>> produces a mess:
>>
>> - emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org")
>> - Mx org-agenda
>> - a
>> - i
>> - d
>> - error
>>
>> gives:
>>
>>>>>>>>>>>>>>>>>
>>
>> * 2015
>> ** 2015-02 Februar
>> <2015-02-01 So>*** 2015-02-01 Sonntag
>> **** error
>>
>> <<<<<<<<<<<<<<<<<<<<
>>
>>
>> instead of:
>>
>>>>>>>>>>>>>>>>>
>> * 2015
>> ** 2015-02 Februar
>> *** 2015-02-01 Sonntag
>> **** error
>> <2015-02-01 So>
>> <<<<<<<<<<<<<<<<<<<<
>
> This should be fixed. Thank you.
Confirmed, thank you.
Ciao, Gregor
--
-... --- .-. . -.. ..--.. ...-.-
^ permalink raw reply [flat|nested] 6+ messages in thread
* fix is with another glitch when adding two dates (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)])
2015-02-03 21:27 ` fix confirmed (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]) Gregor Zattler
@ 2015-02-04 16:37 ` Gregor Zattler
2015-02-05 9:06 ` fix is with another glitch when adding two dates Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Gregor Zattler @ 2015-02-04 16:37 UTC (permalink / raw)
To: emacs-orgmode
Hi Nicolas, org-mode developers,
there is still a glitch. If I now add two items at the same day.:
rm /tmp/*diary* ; emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw --eval '(setq org-agenda-diary-file „/tmp/diary.org“)' "/tmp/diary.org" -f org-agenda
a
i
d
error1
i
d
error2
the result is:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
* 2015
** 2015-02 Februar
*** 2015-02-04 Mittwoch
**** error2
<2015-02-04 Mi>**** error1
<2015-02-04 Mi>
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
instead of:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
* 2015
** 2015-02 Februar
*** 2015-02-04 Mittwoch
**** error2
<2015-02-04 Mi>
**** error1
<2015-02-04 Mi>
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
With org-mode as of f9ab1e8ab6b5b6604e838ac992ad51a594ed7130 it’s
correct and „error1“ is above „error2“. This seems more natural
(at least for me).
I did a git bisect and the first bad commit is Nicolas fix for my
original bug report:
1d4c79d41525113f9e43b82dc9b24d353dc311bd is the first bad commit
commit 1d4c79d41525113f9e43b82dc9b24d353dc311bd
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Mon Feb 2 18:19:30 2015 +0100
org-agenda: Fix agenda diary corruption
* lisp/org-agenda.el (org-agenda-insert-diary-make-new-entry): Do not
save excursion or final position is lost.
Reported-by: Gregor Zattler <grfz@gmx.de>
<http://permalink.gmane.org/gmane.emacs.orgmode/94543>
:040000 040000 9226a2e0b05d53fcc633f89663ee9cb6803e2701 dc0856aa67db029d63f64b9159626468bd93f7f7 M lisp
Thanks for your attention, gregor
* Gregor Zattler <telegraph@gmx.net> [03. Feb. 2015]:
> * Nicolas Goaziou <mail@nicolasgoaziou.fr> [02. Feb. 2015]:
>> Gregor Zattler <grfz@gmx.de> writes:
>>> adding a date to the datetree in the org-agenda-diary-file
>>> produces a mess:
>>>
>>> - emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org")
>>> - Mx org-agenda
>>> - a
>>> - i
>>> - d
>>> - error
>>>
>>> gives:
>>>
>>>>>>>>>>>>>>>>>>
>>>
>>> * 2015
>>> ** 2015-02 Februar
>>> <2015-02-01 So>*** 2015-02-01 Sonntag
>>> **** error
>>>
>>> <<<<<<<<<<<<<<<<<<<<
>>>
>>>
>>> instead of:
>>>
>>>>>>>>>>>>>>>>>>
>>> * 2015
>>> ** 2015-02 Februar
>>> *** 2015-02-01 Sonntag
>>> **** error
>>> <2015-02-01 So>
>>> <<<<<<<<<<<<<<<<<<<<
>>
>> This should be fixed. Thank you.
>
> Confirmed, thank you.
>
> Ciao, Gregor
> --
> -... --- .-. . -.. ..--.. ...-.-
>
Ciao, Gregor
--
-... --- .-. . -.. ..--.. ...-.-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix is with another glitch when adding two dates
2015-02-04 16:37 ` fix is with another glitch when adding two dates " Gregor Zattler
@ 2015-02-05 9:06 ` Nicolas Goaziou
2015-02-06 14:08 ` Gregor Zattler
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2015-02-05 9:06 UTC (permalink / raw)
To: emacs-orgmode
Hello,
Gregor Zattler <telegraph@gmx.net> writes:
> there is still a glitch. If I now add two items at the same day.:
>
> rm /tmp/*diary* ; emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw --eval '(setq org-agenda-diary-file €ž/tmp/diary.org€œ)' "/tmp/diary.org" -f org-agenda
> a
> i
> d
> error1
> i
> d
> error2
>
>
> the result is:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>
> * 2015
> ** 2015-02 Februar
> *** 2015-02-04 Mittwoch
> **** error2
> <2015-02-04 Mi>**** error1
> <2015-02-04 Mi>
>
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>
> instead of:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>
> * 2015
> ** 2015-02 Februar
> *** 2015-02-04 Mittwoch
> **** error2
> <2015-02-04 Mi>
> **** error1
> <2015-02-04 Mi>
>
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
This should be fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix is with another glitch when adding two dates
2015-02-05 9:06 ` fix is with another glitch when adding two dates Nicolas Goaziou
@ 2015-02-06 14:08 ` Gregor Zattler
0 siblings, 0 replies; 6+ messages in thread
From: Gregor Zattler @ 2015-02-06 14:08 UTC (permalink / raw)
To: emacs-orgmode
Hi Nicolas,
I confirm this is fixed. Thank you very much,
Gregor
* Nicolas Goaziou <mail@nicolasgoaziou.fr> [05. Feb. 2015]:
> Gregor Zattler <telegraph@gmx.net> writes:
>
>> there is still a glitch. If I now add two items at the same day.:
>>
>> rm /tmp/*diary* ; emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw --eval '(setq org-agenda-diary-file ??/tmp/diary.org??)' "/tmp/diary.org" -f org-agenda
>> a
>> i
>> d
>> error1
>> i
>> d
>> error2
>>
>>
>> the result is:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>
>> * 2015
>> ** 2015-02 Februar
>> *** 2015-02-04 Mittwoch
>> **** error2
>> <2015-02-04 Mi>**** error1
>> <2015-02-04 Mi>
>>
>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>>
>> instead of:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
>>
>> * 2015
>> ** 2015-02 Februar
>> *** 2015-02-04 Mittwoch
>> **** error2
>> <2015-02-04 Mi>
>> **** error1
>> <2015-02-04 Mi>
>>
>> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>
> This should be fixed. Thank you.
--
-... --- .-. . -.. ..--.. ...-.-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-06 14:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-01 21:23 Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)] Gregor Zattler
2015-02-02 17:22 ` Nicolas Goaziou
2015-02-03 21:27 ` fix confirmed (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)]) Gregor Zattler
2015-02-04 16:37 ` fix is with another glitch when adding two dates " Gregor Zattler
2015-02-05 9:06 ` fix is with another glitch when adding two dates Nicolas Goaziou
2015-02-06 14:08 ` Gregor Zattler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).