fix is with another glitch when adding two dates (was: Re: Bug: org-agenda-diary-entry messes with datetree in org-agenda-diary-file [8.3beta (release_8.3beta-785-gb5d9f4 @ /home/grfz/src/org-mode/lisp/)])

[Gregor Zattler <telegraph@gmx.net>]

Hi Nicolas, org-mode developers,

there is still a glitch.  If I now add two items at the same day.:

rm /tmp/*diary* ; emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw --eval '(setq org-agenda-diary-file „/tmp/diary.org“)'  "/tmp/diary.org" -f org-agenda
a
i
d
error1
i
d
error2


the result is:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

* 2015
** 2015-02 Februar
*** 2015-02-04 Mittwoch
**** error2
     <2015-02-04 Mi>**** error1
          <2015-02-04 Mi>

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

instead of:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

* 2015
** 2015-02 Februar
*** 2015-02-04 Mittwoch
**** error2
     <2015-02-04 Mi>
**** error1
     <2015-02-04 Mi>

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<


With org-mode as of f9ab1e8ab6b5b6604e838ac992ad51a594ed7130 it’s
correct and „error1“ is above „error2“.  This seems more natural
(at least for me).


I did a git bisect and the first bad commit is Nicolas fix for my
original bug report:
1d4c79d41525113f9e43b82dc9b24d353dc311bd is the first bad commit
commit 1d4c79d41525113f9e43b82dc9b24d353dc311bd
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Mon Feb 2 18:19:30 2015 +0100

    org-agenda: Fix agenda diary corruption

    * lisp/org-agenda.el (org-agenda-insert-diary-make-new-entry): Do not
          save excursion or final position is lost.

    Reported-by: Gregor Zattler <grfz@gmx.de>
        <http://permalink.gmane.org/gmane.emacs.orgmode/94543>

:040000 040000 9226a2e0b05d53fcc633f89663ee9cb6803e2701 dc0856aa67db029d63f64b9159626468bd93f7f7 M      lisp


Thanks for your attention, gregor

* Gregor Zattler <telegraph@gmx.net> [03. Feb. 2015]:
> * Nicolas Goaziou <mail@nicolasgoaziou.fr> [02. Feb. 2015]:
>> Gregor Zattler <grfz@gmx.de> writes:
>>> adding a date to the datetree in the org-agenda-diary-file
>>> produces a mess:
>>>
>>> - emacs-snapshot -Q -L /home/grfz/src/org-mode/lisp/ -nw –eval (setq org-agenda-diary-file "/tmp/diary.org")
>>> - Mx org-agenda
>>> - a
>>> - i
>>> - d
>>> - error
>>>
>>> gives:
>>>
>>>>>>>>>>>>>>>>>>
>>>
>>> * 2015
>>> ** 2015-02 Februar
>>> <2015-02-01 So>*** 2015-02-01 Sonntag
>>> **** error
>>>
>>> <<<<<<<<<<<<<<<<<<<<
>>>
>>>
>>> instead of:
>>>
>>>>>>>>>>>>>>>>>>
>>> * 2015
>>> ** 2015-02 Februar
>>> *** 2015-02-01 Sonntag
>>> **** error
>>> <2015-02-01 So>
>>> <<<<<<<<<<<<<<<<<<<<
>> 
>> This should be fixed. Thank you.
> 
> Confirmed, thank you.
> 
> Ciao, Gregor
> -- 
>  -... --- .-. . -.. ..--.. ...-.-
> 

Ciao, Gregor
-- 
 -... --- .-. . -.. ..--.. ...-.-