From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps Date: Sun, 11 Aug 2013 17:09:14 +0200 Message-ID: <20130811150913.GB70709@kenny.local> References: <20130811020358.GA30350@kenny.local> <87mwooznuk.fsf@gmail.com> <20130811124214.GA69042@kenny.local> <87a9koz7ul.fsf@gmail.com> <20130811141439.GD69042@kenny.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8XGq-00059C-K5 for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 11:09:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8XGi-0000dB-6O for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 11:09:28 -0400 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:64781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8XGh-0000cz-W6 for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 11:09:20 -0400 Received: by mail-ea0-f178.google.com with SMTP id a15so2901291eae.23 for ; Sun, 11 Aug 2013 08:09:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130811141439.GD69042@kenny.local> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou , emacs-orgmode@gnu.org Hi Nicolas, Viktor Rosenfeld wrote: > So I propose to append the docstring of > `org-icalendar-export-timestamps': > > This variable has precedence over and overrides the behavior of > `org-export-with-timestamps'. The setting is applied to every > timestamp below a headline and not only to those which are isolated in > a paragraph containing only timestamps. > > It can also be set with the #+OPTIONS line, e.g. "<:t". I just realized that this is not enough. The option `org-icalendar-with-timestamps' already changes the meaning of `org-export-with-timestamps'. The latter only removes timestamps from the export whereas during the iCalendar export the presence of a timestamp determines whether the heading is exported at all. So it's more akin to the behavior of :export: and :noexport: tags. I would change the docstring of `org-icalendar-export-timestamps' as such: Non-nil means export headlines with timestamps. It can be set to any of the following values: t export headlines containing any kind of timestamp `active' export headlines containing active timestamps `inactive' export headlines containing inactive timestamps nil do not any headlines Note: This variable overrides the behavior of `org-export-with-timestamps'. `org-export-with-timestamps' controls whether a timestamp is exported or removed from the export. `org-icalendar-export-timestamps' controls whether a headline is exported or removed from the exported. In addition, `org-icalendar-export-timestamps' applies to every timestamp below a headline and not only to those which are isolated in a paragraph containing only timestamps. This variable can also be set with the #+OPTIONS line, e.g. "<:t". Note that setting the variable in the OPTIONS line is useful to remove a file from the iCalendar export even though it is displayed in the agenda. I actually have this usecase (although right now I exclude by tag). Cheers, Viktor