Re: Proper use of 'org-file-apps'

[Vladimir Lomov <lomov.vl@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hello,
** Nick Dokos [2013-06-27 09:33:41 -0400]:

> Vladimir Lomov <lomov.vl@gmail.com> writes:

>> ** Nick Dokos [2013-06-27 01:52:49 -0400]:

>>> Vladimir Lomov <lomov.vl@gmail.com> writes:

>>>> #+BEGIN_SRC emacs-lisp :tangle org-apps-c.el
>>>>   (add-to-list 'load-path "/usr/share/emacs/site-lisp/org")
>>>>   (require 'org)
>>>>   (setq org-file-apps
>>>>    '( ("\\.pdf::\\(\\d+\\)\\'" . "run-me --page %1 %s")
>>>>       ("\\.pdf\\'" . "run-me %s")
>>>>     )
>>>>   )
>>>> #+END_SRC


>>> \d is Perl regexp syntax for matching a digit, but (afaik) not emacs
>>> syntax. Try

>>>>    '( ("\\.pdf::\\([0-9]+\\)\\'" . "run-me --page %1 %s")

>>>or

>>>>    '( ("\\.pdf::\\([[:digit:]]+\\)\\'" . "run-me --page %1 %s")

>>> instead.
>> D'oh, I had searched Emacs manual about meaning of \' but didn't try to
>> check if \d is acceptable. Nevertheless, 'org-file-apps' docstring must
>> be updated then, because this \\d part is from it.

> Yes, indeed. There's also the vexing question of backslashes. At least
> in my version of the C-h v org-file-apps output, the examples appear
> with single backslashes in the quoted strings, so if somebody just cuts
> and pastes, it is *not* going to work.

> Could you make a patch?

Something like that?

---
WBR, Vladimir Lomov

-- 
Are we running light with overbyte?

[-- Attachment #2: 0001-Fix-docstring-for-org-file-apps.patch --]
[-- Type: text/x-diff, Size: 1609 bytes --]

From 7840435bd76b38ab536108dfc105fdc53a6aa80d Mon Sep 17 00:00:00 2001
From: Vladimir Lomov <lomov.vl@gmail.com>
Date: Fri, 28 Jun 2013 08:42:15 +0900
Subject: [PATCH] Fix docstring for `org-file-apps'

  * lisp/org.el: `org-file-apps' docstring: doubled backslashes (would
    give usable output when run 'C-h v org-file-apps') and use correct
    regexp to match digits.

  TINYCHANGE
---
 lisp/org.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index d0dffc7..5e56231 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -1940,8 +1940,8 @@ file identifier are
                  filename matches the regexp.  If you want to
                  use groups here, use shy groups.
 
-                 Example: (\"\\.x?html\\'\" . \"firefox %s\")
-                          (\"\\(?:xhtml\\|html\\)\" . \"firefox %s\")
+                 Example: (\"\\\\.x?html\\\\'\" . \"firefox %s\")
+                          (\"\\\\(?:xhtml\\\\|html\\\\)\" . \"firefox %s\")
                           to open *.html and *.xhtml with firefox.
 
                - Regular expression which contains (non-shy) groups:
@@ -1956,7 +1956,7 @@ file identifier are
                  In a custom lisp form, you can access the group matches with
                  (match-string n link).
 
-                 Example: (\"\\.pdf::\\(\\d+\\)\\'\" . \"evince -p %1 %s\")
+                 Example: (\"\\\\.pdf::\\\\([[:digit:]]+\\\\)\\\\'\" . \"evince -p %1 %s\")
                      to open [[file:document.pdf::5]] with evince at page 5.
 
  `directory'   Matches a directory
-- 
1.8.3.1